github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5390] [MERGED] Mobile rules page #5910

New Issue
Closed
opened 2026-02-28 21:20:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:20:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5390
Author: @MatissJanis
Created: 7/25/2025
Status: ✅ Merged
Merged: 8/6/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/refine-mobile-rules-page-layout-and-clean-code-3700

📝 Commits (10+)

  • 31ab954 Checkpoint before follow-up message
  • 511870b Refactor mobile rules page and components with UI and type improvements
  • 4de58ea Refactor mobile rules list item styling and layout
  • b7dac3c Add mobile rules page for improved mobile device management
  • 8bb9de4 Adjust RulesListItem styling with min-height and padding tweaks
  • f374aea Adjust mobile rules list item layout for consistent alignment and spacing
  • 0d88edb Refactor RulesListItem layout to improve readability and alignment
  • 7af234e Add search and filter functionality to mobile rules page
  • 4bd4ff8 [autofix.ci] apply automated fixes
  • 19b417d Checkpoint before follow-up message

📊 Changes

33 files changed (+803 additions, -26 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/mobile-navigation.ts (+9 -0)
➕ packages/desktop-client/e2e/page-models/mobile-rules-page.ts (+118 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts (+90 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-add-button-opens-rule-creation-modal-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-add-button-opens-rule-creation-modal-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-add-button-opens-rule-creation-modal-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-modal-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-modal-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-modal-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-displays-the-rules-page-with-proper-header-and-search-bar-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-displays-the-rules-page-with-proper-header-and-search-bar-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-displays-the-rules-page-with-proper-header-and-search-bar-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-page-handles-empty-state-gracefully-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-page-handles-empty-state-gracefully-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-page-handles-empty-state-gracefully-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-search-functionality-filters-rules-correctly-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-search-functionality-filters-rules-correctly-2-chromium-linux.png (+0 -0)

...and 13 more files

📄 Description

This PR introduces a new mobile-friendly rules management page.

Out of scope in order to keep this PR from exploding in size:

  • deletion of rules
  • changes to the rules modal to make it responsive

I plan on picking these up as follow-ups after merging this PR.

Open in Web • Open in Cursor

Learn more about Background Agents

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5390 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 8/6/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/refine-mobile-rules-page-layout-and-clean-code-3700` --- ### 📝 Commits (10+) - [`31ab954`](https://github.com/actualbudget/actual/commit/31ab9541cded9bc34adb074fb9a4ce33eb6cdce8) Checkpoint before follow-up message - [`511870b`](https://github.com/actualbudget/actual/commit/511870b394cf1445f926c8618d1ae0231b01c2f2) Refactor mobile rules page and components with UI and type improvements - [`4de58ea`](https://github.com/actualbudget/actual/commit/4de58ea78610b2fbd7396bd0024b1b7c619b5ee3) Refactor mobile rules list item styling and layout - [`b7dac3c`](https://github.com/actualbudget/actual/commit/b7dac3c5e2a2bac9f7ec703d182421e7537fdecd) Add mobile rules page for improved mobile device management - [`8bb9de4`](https://github.com/actualbudget/actual/commit/8bb9de4dfaa884f7dc2ebc3ce1d7f70d9a1ddab7) Adjust RulesListItem styling with min-height and padding tweaks - [`f374aea`](https://github.com/actualbudget/actual/commit/f374aead751afa79f61a8db44b991cf3e3b4ea32) Adjust mobile rules list item layout for consistent alignment and spacing - [`0d88edb`](https://github.com/actualbudget/actual/commit/0d88edb2c81eb22f5e5a3e114ac6e49420801129) Refactor RulesListItem layout to improve readability and alignment - [`7af234e`](https://github.com/actualbudget/actual/commit/7af234e41c78609d152ade18032e994c091503e1) Add search and filter functionality to mobile rules page - [`4bd4ff8`](https://github.com/actualbudget/actual/commit/4bd4ff877cdd4bb4b310a9387cc26f1fbbd64fb1) [autofix.ci] apply automated fixes - [`19b417d`](https://github.com/actualbudget/actual/commit/19b417dd56cd15f79ab93bd61179f29e8d168eea) Checkpoint before follow-up message ### 📊 Changes **33 files changed** (+803 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/mobile-navigation.ts` (+9 -0) ➕ `packages/desktop-client/e2e/page-models/mobile-rules-page.ts` (+118 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts` (+90 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-add-button-opens-rule-creation-modal-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-add-button-opens-rule-creation-modal-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-add-button-opens-rule-creation-modal-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-modal-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-modal-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-modal-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-displays-the-rules-page-with-proper-header-and-search-bar-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-displays-the-rules-page-with-proper-header-and-search-bar-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-displays-the-rules-page-with-proper-header-and-search-bar-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-page-handles-empty-state-gracefully-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-page-handles-empty-state-gracefully-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-page-handles-empty-state-gracefully-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-search-functionality-filters-rules-correctly-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-search-functionality-filters-rules-correctly-2-chromium-linux.png` (+0 -0) _...and 13 more files_ </details> ### 📄 Description This PR introduces a new mobile-friendly rules management page. Out of scope in order to keep this PR from exploding in size: - deletion of rules - changes to the rules modal to make it responsive I plan on picking these up as follow-ups after merging this PR. --- [Open in Web](https://www.cursor.com/agents?id=bc-941e6b88-1e4e-4fbe-a1c5-6f114f8d36e1) • [Open in Cursor](https://cursor.com/background-agent?bcId=bc-941e6b88-1e4e-4fbe-a1c5-6f114f8d36e1) Learn more about [Background Agents](https://docs.cursor.com/background-agent/web-and-mobile) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:20:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5910
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?