github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 04:49:45 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #4035] [CLOSED] Include translations in builds #58813

New Issue
Closed
opened 2026-05-06 23:33:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 23:33:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4035
Author: @jfdoming
Created: 12/24/2024
Status: ❌ Closed

Base: master ← Head: jfdoming/include-translations-in-builds

📝 Commits (5)

📊 Changes

12 files changed (+76 additions, -1 deletions)

View changed files

📝 .github/actions/setup/action.yml (+10 -0)
📝 .github/workflows/build.yml (+12 -0)
📝 .github/workflows/check.yml (+14 -0)
📝 .github/workflows/codeql.yml (+2 -0)
📝 .github/workflows/e2e-test.yml (+12 -0)
📝 .github/workflows/electron-master.yml (+4 -0)
📝 .github/workflows/electron-pr.yml (+4 -0)
📝 .github/workflows/netlify-release.yml (+5 -1)
📝 .github/workflows/update-vrt.yml (+3 -0)
➕ .gitmodules (+3 -0)
➕ packages/desktop-client/locale (+1 -0)
➕ upcoming-release-notes/4035.md (+6 -0)

📄 Description

This is the final step in getting translations rolled out! We're using Git Submodules here, which allow us to keep the https://github.com/actualbudget/translations logically inside a locale/ directory on checkouts. Note that anyone who wants to contribute translations will need to run git submodule update --init before they will see the translations locally, and anyone with a local web-only install (not actual-server) will need to do the same in order to see the translations.

Also see this PR for a small update to the release process.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4035 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 12/24/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `jfdoming/include-translations-in-builds` --- ### 📝 Commits (5) - [`69ddd55`](https://github.com/actualbudget/actual/commit/69ddd55e2bc518dacb0998d5659f6c3eae2c4f7f) Add submodule for translations - [`efcba89`](https://github.com/actualbudget/actual/commit/efcba89b6b09f5b7f31d333264b245c42810ffe1) Checkout submodules in GitHub actions - [`aee6f72`](https://github.com/actualbudget/actual/commit/aee6f7256cee6211bf5bcf11609a20e27ecc3083) Add release notes - [`383a662`](https://github.com/actualbudget/actual/commit/383a662750bdcb47074d29f51f10cb6528d6939c) Attempt to fix containerized tests - [`93a3f64`](https://github.com/actualbudget/actual/commit/93a3f64724f8087b740743db57f7f174031ee603) fix: typo ### 📊 Changes **12 files changed** (+76 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/setup/action.yml` (+10 -0) 📝 `.github/workflows/build.yml` (+12 -0) 📝 `.github/workflows/check.yml` (+14 -0) 📝 `.github/workflows/codeql.yml` (+2 -0) 📝 `.github/workflows/e2e-test.yml` (+12 -0) 📝 `.github/workflows/electron-master.yml` (+4 -0) 📝 `.github/workflows/electron-pr.yml` (+4 -0) 📝 `.github/workflows/netlify-release.yml` (+5 -1) 📝 `.github/workflows/update-vrt.yml` (+3 -0) ➕ `.gitmodules` (+3 -0) ➕ `packages/desktop-client/locale` (+1 -0) ➕ `upcoming-release-notes/4035.md` (+6 -0) </details> ### 📄 Description This is the final step in getting translations rolled out! We're using [Git Submodules](https://git-scm.com/book/en/v2/Git-Tools-Submodules) here, which allow us to keep the https://github.com/actualbudget/translations logically inside a `locale/` directory on checkouts. Note that anyone who wants to contribute translations will need to run `git submodule update --init` before they will see the translations locally, and anyone with a local web-only install (not `actual-server`) will need to do the same in order to see the translations. Also see [this PR](https://github.com/actualbudget/docs/pull/586/files) for a small update to the release process. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 23:33:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#58813
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?