github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #3637] [CLOSED] [WIP] Use react-aria-component Input as base of Actual's Input component #58626

New Issue
Closed
opened 2026-05-06 23:14:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 23:14:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3637
Author: @joel-jeremy
Created: 10/12/2024
Status: ❌ Closed

Base: master ← Head: react-aria-input

📝 Commits (7)

  • b78f1fd Use react-aria-component input as base of Actual's Input component
  • b3d0348 Remove FocusScope contain
  • 46977b5 Delay Input autoSelect a bit
  • db7d890 Fix styling issues
  • e6a49b1 Rename className var
  • 7e1cc49 Fix import
  • d2bf2e9 Fix InputWithContent

📊 Changes

59 files changed (+2262 additions, -2150 deletions)

View changed files

📝 packages/desktop-client/src/components/EditablePageHeaderTitle.tsx (+18 -19)
📝 packages/desktop-client/src/components/ManageRules.tsx (+1 -1)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+20 -21)
📝 packages/desktop-client/src/components/accounts/Reconcile.tsx (+36 -30)
📝 packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+28 -36)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+3 -10)
📝 packages/desktop-client/src/components/budget/envelope/CoverMenu.tsx (+45 -42)
📝 packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx (+10 -3)
📝 packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx (+56 -55)
📝 packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx (+53 -51)
📝 packages/desktop-client/src/components/budget/tracking/TrackingBudgetComponents.tsx (+7 -2)
📝 packages/desktop-client/src/components/common/Button2.tsx (+1 -1)
➖ packages/desktop-client/src/components/common/InitialFocus.ts (+0 -36)
📝 packages/desktop-client/src/components/common/Input.tsx (+104 -76)
📝 packages/desktop-client/src/components/common/InputWithContent.tsx (+29 -55)
📝 packages/desktop-client/src/components/common/Modal.tsx (+10 -6)
📝 packages/desktop-client/src/components/common/Search.tsx (+75 -78)
📝 packages/desktop-client/src/components/filters/FiltersMenu.jsx (+1 -1)

...and 39 more files

📄 Description

Changes:

  1. Use react-aria-components' Input component as base of Actual's Input component
  2. Replace InitialFocus with usage of autoFocus prop
  3. Use Form to standardize handling of user inputs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3637 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 10/12/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `react-aria-input` --- ### 📝 Commits (7) - [`b78f1fd`](https://github.com/actualbudget/actual/commit/b78f1fd575ffbbed4f216421c4e7e8dec4d447bf) Use react-aria-component input as base of Actual's Input component - [`b3d0348`](https://github.com/actualbudget/actual/commit/b3d03484937a52a9780fd39fe655fc89143bf009) Remove FocusScope contain - [`46977b5`](https://github.com/actualbudget/actual/commit/46977b59ca1f54ff4e63aaa52964bb0ddb20d1bd) Delay Input autoSelect a bit - [`db7d890`](https://github.com/actualbudget/actual/commit/db7d890e7910311124c353e953378b7ac297cb33) Fix styling issues - [`e6a49b1`](https://github.com/actualbudget/actual/commit/e6a49b1d993a695e15ac9ce4e85fda6a60908dc7) Rename className var - [`7e1cc49`](https://github.com/actualbudget/actual/commit/7e1cc494789cdcd9b550a1e8de9bd0962d88348f) Fix import - [`d2bf2e9`](https://github.com/actualbudget/actual/commit/d2bf2e9cc900ac2ba58e027d748779f384b5f0bc) Fix InputWithContent ### 📊 Changes **59 files changed** (+2262 additions, -2150 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/EditablePageHeaderTitle.tsx` (+18 -19) 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+20 -21) 📝 `packages/desktop-client/src/components/accounts/Reconcile.tsx` (+36 -30) 📝 `packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+28 -36) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+3 -10) 📝 `packages/desktop-client/src/components/budget/envelope/CoverMenu.tsx` (+45 -42) 📝 `packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx` (+10 -3) 📝 `packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx` (+56 -55) 📝 `packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx` (+53 -51) 📝 `packages/desktop-client/src/components/budget/tracking/TrackingBudgetComponents.tsx` (+7 -2) 📝 `packages/desktop-client/src/components/common/Button2.tsx` (+1 -1) ➖ `packages/desktop-client/src/components/common/InitialFocus.ts` (+0 -36) 📝 `packages/desktop-client/src/components/common/Input.tsx` (+104 -76) 📝 `packages/desktop-client/src/components/common/InputWithContent.tsx` (+29 -55) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+10 -6) 📝 `packages/desktop-client/src/components/common/Search.tsx` (+75 -78) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.jsx` (+1 -1) _...and 39 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Changes: 1. Use react-aria-components' Input component as base of Actual's Input component 2. Replace `InitialFocus` with usage of `autoFocus` prop 3. Use Form to standardize handling of user inputs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 23:14:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#58626
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?