github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 12:30:06 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5220] [MERGED] fix: reapply thousand separators before passing input to appendDecimals #5830

New Issue
Closed
opened 2026-02-28 21:19:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:19:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5220
Author: @intagaming
Created: 6/22/2025
Status: ✅ Merged
Merged: 6/28/2025
Merged by: @youngcw

Base: master ← Head: fix-hide-decimals-delete

📝 Commits (4)

  • 0db8caf fix: reapply thousand separators before passing input to appendDecimals
  • 272934c Handle edge cases for reapplyThousandSeparators
  • 81baa56 [autofix.ci] apply automated fixes
  • e202224 Merge branch 'master' into fix-hide-decimals-delete

📊 Changes

4 files changed (+37 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx (+2 -0)
📝 packages/desktop-client/src/components/util/AmountInput.tsx (+6 -1)
📝 packages/loot-core/src/shared/util.ts (+23 -0)
➕ upcoming-release-notes/5220.md (+6 -0)

📄 Description

Fixes #5218

This ensures that the input going into appendDecimals is not malformed when the hideFraction option is On, otherwise when hitting delete on the text "1,234,567", it will result in the text "1,234,56" which the formatter will parse as 1234.56. This doesn't happen when hideFraction is off since hitting delete on the text "12,345.67" results in "12,345.6", which appendDecimals will happily handle in a separate case to provide "12345.6" as the input into currencyToAmount.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5220 **Author:** [@intagaming](https://github.com/intagaming) **Created:** 6/22/2025 **Status:** ✅ Merged **Merged:** 6/28/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix-hide-decimals-delete` --- ### 📝 Commits (4) - [`0db8caf`](https://github.com/actualbudget/actual/commit/0db8caf55ded26da29ee45aa0c2cb90baf7a2b25) fix: reapply thousand separators before passing input to appendDecimals - [`272934c`](https://github.com/actualbudget/actual/commit/272934c332c1122471dafd4056c97040634b00a2) Handle edge cases for reapplyThousandSeparators - [`81baa56`](https://github.com/actualbudget/actual/commit/81baa56dc2ee4042f75cefa9a0851a70684e70dc) [autofix.ci] apply automated fixes - [`e202224`](https://github.com/actualbudget/actual/commit/e202224f81cab5aec735c80c3b36d813d5770eba) Merge branch 'master' into fix-hide-decimals-delete ### 📊 Changes **4 files changed** (+37 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/util/AmountInput.tsx` (+6 -1) 📝 `packages/loot-core/src/shared/util.ts` (+23 -0) ➕ `upcoming-release-notes/5220.md` (+6 -0) </details> ### 📄 Description Fixes #5218 This ensures that the input going into `appendDecimals` is not malformed when the `hideFraction` option is On, otherwise when hitting delete on the text `"1,234,567"`, it will result in the text `"1,234,56"` which the formatter will parse as `1234.56`. This doesn't happen when `hideFraction` is off since hitting delete on the text `"12,345.67"` results in `"12,345.6"`, which `appendDecimals` will happily handle in a separate case to provide `"12345.6"` as the input into `currencyToAmount`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:19:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5830
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?