github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #2672] [MERGED] [Feature] Make comma's and period interchangeable when entering figures #58102

New Issue
Closed
opened 2026-05-06 22:25:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 22:25:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2672
Author: @Wizmaster
Created: 4/26/2024
Status: ✅ Merged
Merged: 5/16/2024
Merged by: @joel-jeremy

Base: master ← Head: feature/merge-comma-dot

📝 Commits (1)

  • b90402c Make comma's and period interchangeable when entering figures

📊 Changes

3 files changed (+30 additions, -27 deletions)

View changed files

📝 packages/loot-core/src/shared/arithmetic.ts (+4 -19)
📝 packages/loot-core/src/shared/util.ts (+20 -8)
➕ upcoming-release-notes/2672.md (+6 -0)

📄 Description

Implements #2318

It's only allowed for formats not using period or comma as a thousand separator. I don't think somebody using a format with comma and dot as decimal and thousand separator would have the issue in the first place.

I reworked the arithmetic parser to let currencyToAmount() handle number formatting with active format. I noticed it also made an exception for a leading currency symbol but not for a tailing one. I fixed it to allow that case. (actually in my implementation you could also put a currency symbol in the middle of a value but it would be ignored anyway, I don't think it's an issue)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2672 **Author:** [@Wizmaster](https://github.com/Wizmaster) **Created:** 4/26/2024 **Status:** ✅ Merged **Merged:** 5/16/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `feature/merge-comma-dot` --- ### 📝 Commits (1) - [`b90402c`](https://github.com/actualbudget/actual/commit/b90402c340c92dabaec91ed2d397860761df66ff) Make comma's and period interchangeable when entering figures ### 📊 Changes **3 files changed** (+30 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/shared/arithmetic.ts` (+4 -19) 📝 `packages/loot-core/src/shared/util.ts` (+20 -8) ➕ `upcoming-release-notes/2672.md` (+6 -0) </details> ### 📄 Description Implements #2318 It's only allowed for formats not using period or comma as a thousand separator. I don't think somebody using a format with comma and dot as decimal and thousand separator would have the issue in the first place. I reworked the arithmetic parser to let `currencyToAmount()` handle number formatting with active format. I noticed it also made an exception for a leading currency symbol but not for a tailing one. I fixed it to allow that case. (actually in my implementation you could also put a currency symbol in the middle of a value but it would be ignored anyway, I don't think it's an issue) <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 22:25:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#58102
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?