github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5189] [MERGED] Update parsing of schedule names (issue #4607) #5805

New Issue
Closed
opened 2026-02-28 21:18:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:18:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5189
Author: @MattFaz
Created: 6/18/2025
Status: ✅ Merged
Merged: 6/18/2025
Merged by: @youngcw

Base: master ← Head: bug-4607

📝 Commits (1)

📊 Changes

2 files changed (+12 additions, -6 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goal-template.pegjs (+6 -6)
➕ upcoming-release-notes/5189.md (+6 -0)

📄 Description

Fixes issue #4607 which was introduced by feature #4257

The changes fix parsing of schedule names containing square brackets by modifying the grammar rules:

  • Before: Schedule names couldn't contain [ characters at all, causing failures when brackets appeared
    in schedule names
  • After: Schedule names can now contain brackets, but the parser stops parsing the name when it
    encounters [increase or [decrease modifiers (using negative lookahead)
  • Also trims whitespace from the parsed schedule name

This allows schedule names like "My Schedule [2024]" to work properly while still recognizing increase/decrease modifiers.

https://github.com/user-attachments/assets/6221058c-954e-4b3a-9b6a-b5a1c18ffa93

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5189 **Author:** [@MattFaz](https://github.com/MattFaz) **Created:** 6/18/2025 **Status:** ✅ Merged **Merged:** 6/18/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `bug-4607` --- ### 📝 Commits (1) - [`4be96d1`](https://github.com/actualbudget/actual/commit/4be96d17d6ac6fda4ca5449883e5cbbfdd55a039) fixes ### 📊 Changes **2 files changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goal-template.pegjs` (+6 -6) ➕ `upcoming-release-notes/5189.md` (+6 -0) </details> ### 📄 Description Fixes issue #4607 which was introduced by feature #4257 The changes fix parsing of schedule names containing square brackets by modifying the grammar rules: - **Before:** Schedule names couldn't contain `[` characters at all, causing failures when brackets appeared in schedule names - **After:** Schedule names can now contain brackets, but the parser stops parsing the name when it encounters `[increase` or `[decrease` modifiers (using negative lookahead) - Also trims whitespace from the parsed schedule name This allows schedule names like "My Schedule [2024]" to work properly while still recognizing increase/decrease modifiers. https://github.com/user-attachments/assets/6221058c-954e-4b3a-9b6a-b5a1c18ffa93 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:18:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5805
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?