github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-22 12:12:11 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #2506] [MERGED] modify existing LineGraph to track budget items over time #57993

New Issue
Closed
opened 2026-05-06 22:18:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 22:18:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2506
Author: @qedi-r
Created: 3/25/2024
Status: ✅ Merged
Merged: 4/4/2024
Merged by: @carkom

Base: master ← Head: line-graph-prototype

📝 Commits (10+)

  • 63fcd77 modify exiting LineGraph to track budget items over time
  • 2aadf94 linter pass 1
  • 6284031 increase line weight, add sorting and colour to tooltip
  • 18c35fc second lint pass
  • f921341 add release note
  • e957d1b use new disabledLists, format tooltip, other nits from review
  • 02bfcd6 add margins to LineGraph
  • c055e22 adding missed linting
  • cca55dd remove new line icon, add disable options for split, legend, label
  • 1e42191 Update ReportTopbar.jsx

📊 Changes

6 files changed (+70 additions, -27 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ChooseGraph.tsx (+2 -4)
📝 packages/desktop-client/src/components/reports/ReportTopbar.jsx (+14 -0)
📝 packages/desktop-client/src/components/reports/disabledList.ts (+10 -1)
📝 packages/desktop-client/src/components/reports/graphs/BarLineGraph.tsx (+4 -4)
📝 packages/desktop-client/src/components/reports/graphs/LineGraph.tsx (+34 -18)
➕ upcoming-release-notes/2506.md (+6 -0)

📄 Description

Modify the unused custom reports' LineGraph to graph category data over time, as an alternate to the stacked bar chart view.

If the LineGraph was planned on being used, I could take this further to maintain the old code.

I'll note that the icon was just something grabbed from (mit licensed) ionicons, as there wasn't an additional icon to differentiate from the area graph.

Items still to do:

  • linting
  • release notes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2506 **Author:** [@qedi-r](https://github.com/qedi-r) **Created:** 3/25/2024 **Status:** ✅ Merged **Merged:** 4/4/2024 **Merged by:** [@carkom](https://github.com/carkom) **Base:** `master` ← **Head:** `line-graph-prototype` --- ### 📝 Commits (10+) - [`63fcd77`](https://github.com/actualbudget/actual/commit/63fcd777b087d1d8fe0f62e646273f784df51a49) modify exiting LineGraph to track budget items over time - [`2aadf94`](https://github.com/actualbudget/actual/commit/2aadf945dff3f8ed87223fc8d80bae1ebfc38844) linter pass 1 - [`6284031`](https://github.com/actualbudget/actual/commit/62840313a455caa9da738434a2ce43fe1a637cf6) increase line weight, add sorting and colour to tooltip - [`18c35fc`](https://github.com/actualbudget/actual/commit/18c35fcf3d4d2688083389d648c07c1ed8e45942) second lint pass - [`f921341`](https://github.com/actualbudget/actual/commit/f92134110795aa21b200118260ae47ac90d8b4c6) add release note - [`e957d1b`](https://github.com/actualbudget/actual/commit/e957d1ba2c171eb0e2ba5e53f6ae77d50d1523ea) use new disabledLists, format tooltip, other nits from review - [`02bfcd6`](https://github.com/actualbudget/actual/commit/02bfcd63eb94575a34235822210a228e3308abd3) add margins to LineGraph - [`c055e22`](https://github.com/actualbudget/actual/commit/c055e2217ea37c5713a4fc44e9927a9b9aae0494) adding missed linting - [`cca55dd`](https://github.com/actualbudget/actual/commit/cca55dd5cc966ea68cb16f32feb13ed276f9b3f7) remove new line icon, add disable options for split, legend, label - [`1e42191`](https://github.com/actualbudget/actual/commit/1e421915c0e942b75aa02a85141f71108ef5cc7f) Update ReportTopbar.jsx ### 📊 Changes **6 files changed** (+70 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ChooseGraph.tsx` (+2 -4) 📝 `packages/desktop-client/src/components/reports/ReportTopbar.jsx` (+14 -0) 📝 `packages/desktop-client/src/components/reports/disabledList.ts` (+10 -1) 📝 `packages/desktop-client/src/components/reports/graphs/BarLineGraph.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/reports/graphs/LineGraph.tsx` (+34 -18) ➕ `upcoming-release-notes/2506.md` (+6 -0) </details> ### 📄 Description Modify the unused custom reports' LineGraph to graph category data over time, as an alternate to the stacked bar chart view. If the LineGraph was planned on being used, I could take this further to maintain the old code. I'll note that the icon was just something grabbed from (mit licensed) ionicons, as there wasn't an additional icon to differentiate from the area graph. Items still to do: - [x] linting - [x] release notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 22:18:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#57993
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?