github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5129] [MERGED] Fix net worth graph gradient conflict #5773

New Issue
Closed
opened 2026-02-28 21:18:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:18:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5129
Author: @OlivierKamers
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @matt-fidd

Base: master ← Head: oli/fix-net-worth-gradient

📝 Commits (2)

  • 983e60d Fix net worth graph gradient conflict
  • 1bd3fce Apply review suggestion

📊 Changes

2 files changed (+11 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx (+5 -3)
➕ upcoming-release-notes/5129.md (+6 -0)

📄 Description

Fixes #3965

Ensures that the net worth graph's gradient ID is unique to prevent conflicts when multiple graphs are rendered on the same page.

To verify, I added a Net Worth Chart to the reports page of the test budget, where I simply added a filter amount < 1000 to make the net worth negative.

Before

Screenshot 2025-06-08 at 15 53 53

After

Screenshot 2025-06-08 at 15 54 00

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5129 **Author:** [@OlivierKamers](https://github.com/OlivierKamers) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `oli/fix-net-worth-gradient` --- ### 📝 Commits (2) - [`983e60d`](https://github.com/actualbudget/actual/commit/983e60d3fe46a5bd3d6c03e2d7ad768997a10436) Fix net worth graph gradient conflict - [`1bd3fce`](https://github.com/actualbudget/actual/commit/1bd3fcef53475efdbe356b7bef971ae26733772d) Apply review suggestion ### 📊 Changes **2 files changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx` (+5 -3) ➕ `upcoming-release-notes/5129.md` (+6 -0) </details> ### 📄 Description Fixes #3965 Ensures that the net worth graph's gradient ID is unique to prevent conflicts when multiple graphs are rendered on the same page. To verify, I added a Net Worth Chart to the reports page of the test budget, where I simply added a filter `amount < 1000` to make the net worth negative. **Before** <img width="1170" alt="Screenshot 2025-06-08 at 15 53 53" src="https://github.com/user-attachments/assets/46a9f3d6-3f77-48c0-a768-4e6667e32d8f" /> **After** <img width="1126" alt="Screenshot 2025-06-08 at 15 54 00" src="https://github.com/user-attachments/assets/c79fbeea-d35d-4da5-9142-6c89f5da198b" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:18:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5773
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?