github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5101] [MERGED] Trim EndToEndID from the Danish Danske Bank branch #5757

New Issue
Closed
opened 2026-02-28 21:18:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:18:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5101
Author: @AlbertSPedersen
Created: 6/4/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (4)

  • f865393 Trim EndToEndID from the Danish Danske Bank
  • e221a79 Add release note for PR #5101
  • 7ef089f Merge branch 'actualbudget:master' into master
  • 3a0cdc2 Merge branch 'master' into master

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 packages/sync-server/src/app-gocardless/banks/danskebank_privat.js (+3 -1)
➕ upcoming-release-notes/5101.md (+6 -0)

📄 Description

For the Norwegian Branch of Danske Bank, a EndToEndID: NOTPROVIDED suffix is appended to all SEPA transactions. The Danish branch of Danske Bank seems to use the same system as the Norwegian branch, and so EndToEndID: NOTPROVIDED is also appended to notes from this bank. This PR adds the Danish branch to institutionIds.

I've looked at the code responsible for loading bank overrides, and it seems like this fix should work, but I am not familiar with the code-base of Actual Budget, so please keep that in mind when reviewing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5101 **Author:** [@AlbertSPedersen](https://github.com/AlbertSPedersen) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`f865393`](https://github.com/actualbudget/actual/commit/f865393fcb8e4f8ff39aa6c67c0fc2dd083f265c) Trim EndToEndID from the Danish Danske Bank - [`e221a79`](https://github.com/actualbudget/actual/commit/e221a79076809a443996b14c2bb37b051f781be6) Add release note for PR #5101 - [`7ef089f`](https://github.com/actualbudget/actual/commit/7ef089fb4a7688930215885e193ac2d2ce4b257b) Merge branch 'actualbudget:master' into master - [`3a0cdc2`](https://github.com/actualbudget/actual/commit/3a0cdc22cabc347c21e76b970a094d2ba801623f) Merge branch 'master' into master ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-gocardless/banks/danskebank_privat.js` (+3 -1) ➕ `upcoming-release-notes/5101.md` (+6 -0) </details> ### 📄 Description For the Norwegian Branch of Danske Bank, a `EndToEndID: NOTPROVIDED` suffix is appended to all SEPA transactions. The Danish branch of Danske Bank seems to use the same system as the Norwegian branch, and so `EndToEndID: NOTPROVIDED` is also appended to notes from this bank. This PR adds the Danish branch to `institutionIds`. I've looked at the code responsible for loading bank overrides, and it seems like this fix should work, but I am not familiar with the code-base of Actual Budget, so please keep that in mind when reviewing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:18:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5757
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?