github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 12:43:09 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5081] [MERGED] 🔧 (eslint) patch no-restricted-imports rule #5745

New Issue
Closed
opened 2026-02-28 21:17:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:17:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5081
Author: @MatissJanis
Created: 6/2/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/eslint-patch

📝 Commits (1)

  • 790d35b 🔧 (eslint) patch no-restriced-imports rule

📊 Changes

11 files changed (+46 additions, -105 deletions)

View changed files

📝 eslint.config.mjs (+31 -105)
📝 packages/desktop-client/src/hooks/useNavigate.ts (+1 -0)
📝 packages/desktop-client/src/redux/index.ts (+1 -0)
📝 packages/desktop-client/src/style/index.ts (+1 -0)
📝 packages/desktop-client/src/style/palette.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/dark.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/development.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/light.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/midnight.ts (+1 -0)
📝 packages/desktop-electron/e2e/onboarding.test.ts (+1 -0)
➕ upcoming-release-notes/5081.md (+6 -0)

📄 Description

This issue has been annoying me for a while now. Let me explain what I'm doing here.

Eslint has a flat configuration object. It does not support partial rule config overrides.

For example: we can globally restrict importing from dependency A. If some file needs to have another different import restriction - there is no way to merge "restrict importing A" + "local restriction". The last applied config always takes priority.

Fortunately we don't have any violations because of the rule conflicts. But better fix this issue now and forget about it..

Alternative solution would be to bring back package-specific eslint runners & config files (& maybe also a shared config package so we could inherit the global config). But that would be a significantly heavier lift with more long-term maintenance costs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5081 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/eslint-patch` --- ### 📝 Commits (1) - [`790d35b`](https://github.com/actualbudget/actual/commit/790d35b5c932a437b766ef2a4d4f9b6b5f729a5b) :wrench: (eslint) patch no-restriced-imports rule ### 📊 Changes **11 files changed** (+46 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `eslint.config.mjs` (+31 -105) 📝 `packages/desktop-client/src/hooks/useNavigate.ts` (+1 -0) 📝 `packages/desktop-client/src/redux/index.ts` (+1 -0) 📝 `packages/desktop-client/src/style/index.ts` (+1 -0) 📝 `packages/desktop-client/src/style/palette.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/dark.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/development.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/light.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/midnight.ts` (+1 -0) 📝 `packages/desktop-electron/e2e/onboarding.test.ts` (+1 -0) ➕ `upcoming-release-notes/5081.md` (+6 -0) </details> ### 📄 Description This issue has been annoying me for a while now. Let me explain what I'm doing here. Eslint has a flat configuration object. It does not support partial rule config overrides. For example: we can globally restrict importing from dependency A. If some file needs to have another different import restriction - there is no way to merge "restrict importing A" + "local restriction". The last applied config always takes priority. Fortunately we don't have any violations because of the rule conflicts. But better fix this issue now and forget about it.. --- Alternative solution would be to bring back package-specific eslint runners & config files (& maybe also a shared config package so we could inherit the global config). But that would be a significantly heavier lift with more long-term maintenance costs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:17:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5745
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?