github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5031] [MERGED] enable GoCardless account selection if supported by the target institution #5716

New Issue
Closed
opened 2026-02-28 21:17:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:17:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5031
Author: @lorenzenv
Created: 5/19/2025
Status: ✅ Merged
Merged: 5/27/2025
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (7)

  • a5a6264 Update gocardless-service.js
  • aa85042 Merge branch 'actualbudget:master' into master
  • c99576e Allow account selection during requisition based on institution support
  • 2ce1322 Merge branch 'master' into master
  • ccadaaa lint
  • 16c1158 note
  • 0884347 Merge branch 'master' into master

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 packages/sync-server/src/app-gocardless/services/gocardless-service.js (+3 -1)
➕ upcoming-release-notes/5031.md (+6 -0)

📄 Description

Replaces https://github.com/actualbudget/actual/pull/4993, same fix after fork was deleted by accident.

Original PR message:

Problem:

Users attempting to link bank accounts via GoCardless frequently encounter "Daily request limit set by the Institution has been exceeded" errors (as reported in issue #4039). This error prevents successful account linking and occurs because the previous integration attempted to fetch details for all of an institution's accounts upfront.

Solution:

This PR fixes the issue by modifying the GoCardless integration (packages/sync-server/src/app-gocardless/services/gocardless-service.js) to enable server-side account selection provided by GoCardless.

The accountSelection parameter in the client.initSession call (within the createRequisition function) has been changed from false to true.

Impact:

  • When a user initiates a new bank link with GoCardless, they will now be redirected to the GoCardless platform, which should prompt them to select the specific account(s) they wish to grant Actual access to.
  • Actual's backend will then only receive the IDs for these pre-selected accounts in the requisition.
  • This drastically reduces the number of subsequent API calls Actual needs to make, effectively resolving the institutional rate limit errors during the account discovery phase.
  • This leads to a more reliable bank linking experience for GoCardless users affected by these limits.

Testing:

  1. Set up GoCardless credentials in Actual.
  2. Attempt to add a new linked account using GoCardless with an institution previously causing rate limit errors.
  3. Observe that during the redirection to GoCardless, an account selection step is presented.
  4. Select one or more accounts.
  5. Upon redirection back to Actual, verify that only the selected accounts are listed and can be linked successfully without rate limit errors.

Closes #4039

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5031 **Author:** [@lorenzenv](https://github.com/lorenzenv) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`a5a6264`](https://github.com/actualbudget/actual/commit/a5a626444a1cddcae1439d88cf8ada1560dc9529) Update gocardless-service.js - [`aa85042`](https://github.com/actualbudget/actual/commit/aa8504227a214f940acd1a258f284a388d2628f8) Merge branch 'actualbudget:master' into master - [`c99576e`](https://github.com/actualbudget/actual/commit/c99576e2a901a569cf9d2a843a460f6c8fbd2f2b) Allow account selection during requisition based on institution support - [`2ce1322`](https://github.com/actualbudget/actual/commit/2ce1322d24951922c42b0fa83fe56074768b8611) Merge branch 'master' into master - [`ccadaaa`](https://github.com/actualbudget/actual/commit/ccadaaa7cc067189e0201c1d6455ba7c2a194269) lint - [`16c1158`](https://github.com/actualbudget/actual/commit/16c11583933bcd95d6a941c345c6f045330dc02c) note - [`0884347`](https://github.com/actualbudget/actual/commit/088434709e6e5734993ec9e31d8c3715824f3760) Merge branch 'master' into master ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-gocardless/services/gocardless-service.js` (+3 -1) ➕ `upcoming-release-notes/5031.md` (+6 -0) </details> ### 📄 Description Replaces https://github.com/actualbudget/actual/pull/4993, same fix after fork was deleted by accident. Original PR message: **Problem:** Users attempting to link bank accounts via GoCardless frequently encounter "Daily request limit set by the Institution has been exceeded" errors (as reported in issue #4039). This error prevents successful account linking and occurs because the previous integration attempted to fetch details for all of an institution's accounts upfront. **Solution:** This PR fixes the issue by modifying the GoCardless integration (`packages/sync-server/src/app-gocardless/services/gocardless-service.js`) to enable server-side account selection provided by GoCardless. The `accountSelection` parameter in the `client.initSession` call (within the `createRequisition` function) has been changed from `false` to `true`. **Impact:** - When a user initiates a new bank link with GoCardless, they will now be redirected to the GoCardless platform, which should prompt them to select the specific account(s) they wish to grant Actual access to. - Actual's backend will then only receive the IDs for these pre-selected accounts in the requisition. - This drastically reduces the number of subsequent API calls Actual needs to make, effectively resolving the institutional rate limit errors during the account discovery phase. - This leads to a more reliable bank linking experience for GoCardless users affected by these limits. **Testing:** 1. Set up GoCardless credentials in Actual. 2. Attempt to add a new linked account using GoCardless with an institution previously causing rate limit errors. 3. Observe that during the redirection to GoCardless, an account selection step is presented. 4. Select one or more accounts. 5. Upon redirection back to Actual, verify that only the selected accounts are listed and can be linked successfully without rate limit errors. Closes #4039 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:17:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5716
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?