github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5007] [MERGED] Move spreadsheet bindings to spreadsheets feature folder and move hooks in src/components/spreadsheets to src/hooks #5703

New Issue
Closed
opened 2026-02-28 21:17:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:17:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5007
Author: @joel-jeremy
Created: 5/16/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @joel-jeremy

Base: master ← Head: move-bindings-to-spreadsheets-feature-folder

📝 Commits (10+)

  • fb0ce02 Move loot-core/client/modals code over to desktop-client package
  • d167fe2 Fix lint error
  • 9e6840d Move loot-core/client/data-hooks over to desktop-client package
  • b61745f Fix typecheck and lint errors
  • c443a11 Fix lint error
  • 55f3068 Fix typecheck error
  • 652cbd5 Fix test
  • fc17229 Move spreadsheet bindings to spreadsheets feature folder and move hooks from src/components/spreadsheets to src/hooks
  • 820c1ee Move NamespaceContext to useSheetName
  • 801d00d Rename NamespaceContext to SheetNameContext and use SheetNameProvider

📊 Changes

70 files changed (+337 additions, -339 deletions)

View changed files

📝 packages/desktop-client/src/components/Modals.tsx (+31 -31)
📝 packages/desktop-client/src/components/Titlebar.tsx (+3 -3)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+1 -1)
📝 packages/desktop-client/src/components/accounts/Balance.tsx (+3 -3)
📝 packages/desktop-client/src/components/accounts/Reconcile.tsx (+4 -4)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx (+3 -3)
📝 packages/desktop-client/src/components/budget/RenderMonths.tsx (+3 -6)
📝 packages/desktop-client/src/components/budget/envelope/BalanceMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/envelope/BalanceMovementMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx (+4 -7)
📝 packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/envelope/IncomeMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/envelope/budgetsummary/BudgetSummary.tsx (+3 -3)
📝 packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudget.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudgetAmount.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudgetMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/envelope/budgetsummary/TotalsList.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/index.tsx (+3 -3)
📝 packages/desktop-client/src/components/budget/tracking/BalanceMenu.tsx (+1 -1)

...and 50 more files

📄 Description

Just some cleanup after moving loot-core/client over to desktop-client to co-locate spreadsheet related files. Right now, the queries.ts file contains both AQL queries (to be used for aqlQuery calls) and spreadsheet bindings (to be used for useSheetValue calls). This PR is just to separate those 2 to make it clear that one is for AQL queries and one is for spreadsheets.

Changes done:

  1. Renamed src/queries/queries.ts to src/queries/index.ts
    • src/queries/index.ts now only contains AQL queries
  2. Moved spreadsheet bindings from src/queries/index.ts to src/spreadsheets/bindings.ts
  3. Moved spreadsheet types from src/components/spreadsheets to src/spreadsheets/index.ts
  4. Moved hooks from src/components/spreadsheets to src/hooks
    • NamespaceContext.ts --> Renamed this to SheetNameContext and moved inside useSheetName
    • useFormat.ts
    • useSheetName.ts
    • useSheetValue.ts
  5. Created a SheetNameProvider and replaced calls to NamespaceContext.Provider with this provider

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5007 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 5/16/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `move-bindings-to-spreadsheets-feature-folder` --- ### 📝 Commits (10+) - [`fb0ce02`](https://github.com/actualbudget/actual/commit/fb0ce02c1bc0a1dcba1458dc86e344d5d4d161ca) Move loot-core/client/modals code over to desktop-client package - [`d167fe2`](https://github.com/actualbudget/actual/commit/d167fe218ca82124ea2f4a09b350fe06f91f5d86) Fix lint error - [`9e6840d`](https://github.com/actualbudget/actual/commit/9e6840da1ed6f7b16ffff0fc711df9836fbbb4e5) Move loot-core/client/data-hooks over to desktop-client package - [`b61745f`](https://github.com/actualbudget/actual/commit/b61745f2d3caf46c6a2162a7b5abe60c6d40f7e6) Fix typecheck and lint errors - [`c443a11`](https://github.com/actualbudget/actual/commit/c443a11625503f5dd398875382a010e2197a565b) Fix lint error - [`55f3068`](https://github.com/actualbudget/actual/commit/55f3068f23b8475eed2a1bf7eea70582bd4ba37c) Fix typecheck error - [`652cbd5`](https://github.com/actualbudget/actual/commit/652cbd5158e3188037e02ff31cfa59755edeb4d1) Fix test - [`fc17229`](https://github.com/actualbudget/actual/commit/fc172291e60f2b479713d1707c003b4e422f02fb) Move spreadsheet bindings to spreadsheets feature folder and move hooks from src/components/spreadsheets to src/hooks - [`820c1ee`](https://github.com/actualbudget/actual/commit/820c1ee78427f55c4652caf4c8ef241906242961) Move NamespaceContext to useSheetName - [`801d00d`](https://github.com/actualbudget/actual/commit/801d00d74216fe94fda67cfe8cbd7ea052ca9635) Rename NamespaceContext to SheetNameContext and use SheetNameProvider ### 📊 Changes **70 files changed** (+337 additions, -339 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Modals.tsx` (+31 -31) 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Balance.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/accounts/Reconcile.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/budget/RenderMonths.tsx` (+3 -6) 📝 `packages/desktop-client/src/components/budget/envelope/BalanceMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/envelope/BalanceMovementMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx` (+4 -7) 📝 `packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/envelope/IncomeMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/envelope/budgetsummary/BudgetSummary.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudget.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudgetAmount.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudgetMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/envelope/budgetsummary/TotalsList.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/budget/tracking/BalanceMenu.tsx` (+1 -1) _...and 50 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Just some cleanup after moving loot-core/client over to desktop-client to co-locate spreadsheet related files. Right now, the queries.ts file contains both AQL queries (to be used for `aqlQuery` calls) and spreadsheet bindings (to be used for `useSheetValue` calls). This PR is just to separate those 2 to make it clear that one is for AQL queries and one is for spreadsheets. Changes done: 1. Renamed `src/queries/queries.ts` to `src/queries/index.ts` - `src/queries/index.ts` now only contains AQL queries 2. Moved spreadsheet bindings from `src/queries/index.ts` to `src/spreadsheets/bindings.ts` 3. Moved spreadsheet types from `src/components/spreadsheets` to `src/spreadsheets/index.ts` 4. Moved hooks from `src/components/spreadsheets` to `src/hooks` - NamespaceContext.ts --> Renamed this to `SheetNameContext` and moved inside `useSheetName` - useFormat.ts - useSheetName.ts - useSheetValue.ts 5. Created a `SheetNameProvider` and replaced calls to `NamespaceContext.Provider` with this provider --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:17:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5703
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?