github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5001] [CLOSED] Add transfers to merge #5700

New Issue
Closed
opened 2026-02-28 21:16:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:16:58 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5001
Author: @alecbakholdin
Created: 5/16/2025
Status: ❌ Closed

Base: master ← Head: add-transfers-to-merge

📝 Commits (2)

📊 Changes

3 files changed (+182 additions, -2 deletions)

View changed files

📝 packages/loot-core/src/server/transactions/merge.test.ts (+164 -0)
📝 packages/loot-core/src/server/transactions/merge.ts (+12 -2)
➕ upcoming-release-notes/5001.md (+6 -0)

📄 Description

Closes #5000

Initially discussed in #4899

Adds support for merging transferred transaction.

  1. If a kept transaction has no payee (including transfer) and the dropped transaction is a transfer, the dropped transaction's transfer is redirected to point to the kept transaction. Notably, this also clears out the kept transaction's category
  2. Otherwise, if the dropped transaction is a transfer and is not going to be redirected, the corresponding transfer in the other account is also dropped

Please, someone confirm if this sounds okay. This is all reversible with ctrl + z but I worry especially about the second point. To me it sounds reasonable but the alternative is we make the other transaction payee-less instead of deleting it. That seems odd as well but need advice.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5001 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 5/16/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add-transfers-to-merge` --- ### 📝 Commits (2) - [`e3cb22d`](https://github.com/actualbudget/actual/commit/e3cb22d748965d4a932213caabe343a0b3222b87) added support for transfer merging - [`bd5b938`](https://github.com/actualbudget/actual/commit/bd5b938d2fb742a1273f443bf15d16715067b459) release notes ### 📊 Changes **3 files changed** (+182 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/transactions/merge.test.ts` (+164 -0) 📝 `packages/loot-core/src/server/transactions/merge.ts` (+12 -2) ➕ `upcoming-release-notes/5001.md` (+6 -0) </details> ### 📄 Description Closes #5000 Initially discussed in #4899 Adds support for merging transferred transaction. 1) If a kept transaction has no payee (including transfer) and the dropped transaction is a transfer, the dropped transaction's transfer is redirected to point to the kept transaction. **Notably, this also clears out the kept transaction's category** 2) Otherwise, if the dropped transaction is a transfer and is not going to be redirected, the corresponding transfer in the other account is **also dropped** Please, someone confirm if this sounds okay. This is all reversible with ctrl + z but I worry especially about the second point. To me it sounds reasonable but the alternative is we make the other transaction payee-less instead of deleting it. That seems odd as well but need advice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:16:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?