github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-25 07:42:48 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4952] [MERGED] Add test that docker images are working #5677

New Issue
Closed
opened 2026-02-28 21:16:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:16:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4952
Author: @rgoldfinger
Created: 5/6/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @matt-fidd

Base: master ← Head: rg-docker-build-dir

📝 Commits (10+)

📊 Changes

3 files changed (+36 additions, -1 deletions)

View changed files

📝 .github/workflows/check.yml (+10 -0)
📝 .github/workflows/docker-edge.yml (+20 -1)
➕ upcoming-release-notes/4952.md (+6 -0)

📄 Description

In https://github.com/actualbudget/actual/pull/4887, I broke the docker images, as well as the sync-server cli. This adds tests that would have caught the issues.

Example failing build: https://github.com/actualbudget/actual/actions/runs/14887683220/job/41811565952?pr=4952

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4952 **Author:** [@rgoldfinger](https://github.com/rgoldfinger) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `rg-docker-build-dir` --- ### 📝 Commits (10+) - [`845aeff`](https://github.com/actualbudget/actual/commit/845aeffe1dff504b5414c29cf0e5d8f546538b97) use build directory in dockerfiles - [`3399e90`](https://github.com/actualbudget/actual/commit/3399e908e242c0d6f7fff217ace5bd6f88ac2c06) add release notes - [`8f024d0`](https://github.com/actualbudget/actual/commit/8f024d0bd69f4c412bd1d57e9a4f61913e47471b) add test - [`b4633c8`](https://github.com/actualbudget/actual/commit/b4633c86b30706a443d5fdb7bbb8818882fb3d66) Add test for cli, try to fix image test - [`49edbec`](https://github.com/actualbudget/actual/commit/49edbec3c8a9559f6e87c33dea0aa903b8efd73b) - fail - [`20a9c57`](https://github.com/actualbudget/actual/commit/20a9c571c2d7989535419dbead6e8bfddabc3d1b) try again - [`c3bc7fa`](https://github.com/actualbudget/actual/commit/c3bc7fa6c96918465ddd2e0962ae8562dad28699) try again to fail - [`4870ec7`](https://github.com/actualbudget/actual/commit/4870ec7968f7085766d1a88be960e1022bce0c4b) done testing - [`4374a34`](https://github.com/actualbudget/actual/commit/4374a3448561c2ed91f6b5ace5b0c73253878856) Code review - [`e81a1e2`](https://github.com/actualbudget/actual/commit/e81a1e2f5140c9cf6a8549aed4de81c07b5d2c26) publish is unecessary ### 📊 Changes **3 files changed** (+36 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/check.yml` (+10 -0) 📝 `.github/workflows/docker-edge.yml` (+20 -1) ➕ `upcoming-release-notes/4952.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> In https://github.com/actualbudget/actual/pull/4887, I broke the docker images, as well as the sync-server cli. This adds tests that would have caught the issues. Example failing build: https://github.com/actualbudget/actual/actions/runs/14887683220/job/41811565952?pr=4952 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:16:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5677
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?