github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4935] [MERGED] [Mobile] 🐛 Fix viewing pie/donut charts on mobile #5669

New Issue
Closed
opened 2026-02-28 21:16:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:16:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4935
Author: @OhNoBigO
Created: 5/4/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (4)

  • 214a0e7 Fix viewing pie/donut charts on mobile
  • 4c0b5eb Add release note
  • 0dba58c Fix onMouseEnter firing on ios devices
  • 02a6e49 Change isTouchDevice to canDeviceHover

📊 Changes

2 files changed (+0 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx (+33 -21)
➕ upcoming-release-notes/4935.md (+6 -0)

📄 Description

Fixes pie/donut charts viewing on mobile. This change allows users to click on the individual slice of the pie chart on mobile for it to "focus" on that slice. The change only affects touch screen devices, functionality remains in the same for desktop.

Prior to this fix focusing on a slice of the pie chart did not work properly on IOS devices. I am unsure if this was also the case on other mobile devices as I did have some success focusing on a slice by clicking and holding when testing via chrome dev tools but still did not work on my IOS device.

Unlike in desktop view hovering over the slice doesn't work, clicking a slice of the pie chart results in user being navigated to the "accounts" section instead of focusing on the slice, and click and holding also does not work on my IOS device, therefore there was no way to properly use this type of custom report on these devices.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4935 **Author:** [@OhNoBigO](https://github.com/OhNoBigO) **Created:** 5/4/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`214a0e7`](https://github.com/actualbudget/actual/commit/214a0e7fb1d45eea85db68ea829605da68cf7ffe) Fix viewing pie/donut charts on mobile - [`4c0b5eb`](https://github.com/actualbudget/actual/commit/4c0b5eb21262ebe5e4b23bbbd27bc3a16df43d1a) Add release note - [`0dba58c`](https://github.com/actualbudget/actual/commit/0dba58c38a6c3c6a1d20f1d3c393b7c350aa453e) Fix onMouseEnter firing on ios devices - [`02a6e49`](https://github.com/actualbudget/actual/commit/02a6e4906bcabb74f186fe98363d59c3cc221bf0) Change isTouchDevice to canDeviceHover ### 📊 Changes **2 files changed** (+0 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx` (+33 -21) ➕ `upcoming-release-notes/4935.md` (+6 -0) </details> ### 📄 Description Fixes pie/donut charts viewing on mobile. This change allows users to click on the individual slice of the pie chart on mobile for it to "focus" on that slice. The change only affects touch screen devices, functionality remains in the same for desktop. Prior to this fix focusing on a slice of the pie chart did not work properly on IOS devices. I am unsure if this was also the case on other mobile devices as I did have some success focusing on a slice by clicking and holding when testing via chrome dev tools but still did not work on my IOS device. Unlike in desktop view hovering over the slice doesn't work, clicking a slice of the pie chart results in user being navigated to the "accounts" section instead of focusing on the slice, and click and holding also does not work on my IOS device, therefore there was no way to properly use this type of custom report on these devices. ![image](https://s1.ezgif.com/tmp/ezgif-13873e7a62fec4.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:16:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5669
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?