github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 00:13:45 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4933] [MERGED] Use the latest release tag instead of the latest tag for version checks #5668

New Issue
Closed
opened 2026-02-28 21:16:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:16:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4933
Author: @jfdoming
Created: 5/4/2025
Status: ✅ Merged
Merged: 5/5/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/check-release-not-tags

📝 Commits (2)

  • 40472df Use the latest release tag instead of the latest tag for version checks
  • fb4a13f Add release notes

📊 Changes

2 files changed (+8 additions, -7 deletions)

View changed files

📝 packages/desktop-client/src/util/versions.ts (+2 -7)
➕ upcoming-release-notes/4933.md (+6 -0)

📄 Description

Motivation: Currently, releasing is a multi-step process. First, a PR is merged and tagged on master, which triggers release builds to start. Second, completed desktop app release builds create a draft GitHub release. Finally, a maintainer manually marks the release as non-draft. This results in a poor user experience with updates, because the first step (tagging) would trigger a notification in all apps before the builds are even completed.

This PR updates the notification checking logic to use the latest (non-draft) release, rather than the latest tag. This means that update notifications will not be sent out until a maintainer manually un-drafts a GitHub release as the final step of the process (we do this anyway as noted above).

There's still a bit of a confusing situation for folks on Pikapods and in the Windows Store, where updates are not available as soon as we push them. But this should result in a better experience for those who do manage their own updates.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4933 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 5/4/2025 **Status:** ✅ Merged **Merged:** 5/5/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/check-release-not-tags` --- ### 📝 Commits (2) - [`40472df`](https://github.com/actualbudget/actual/commit/40472dfd749af30c3a6336fc5fb8452d4d16b042) Use the latest release tag instead of the latest tag for version checks - [`fb4a13f`](https://github.com/actualbudget/actual/commit/fb4a13f6884a48108de83338954fa75451b8db06) Add release notes ### 📊 Changes **2 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/util/versions.ts` (+2 -7) ➕ `upcoming-release-notes/4933.md` (+6 -0) </details> ### 📄 Description Motivation: Currently, releasing is a multi-step process. First, a PR is merged and tagged on master, which triggers release builds to _start_. Second, completed _desktop app_ release builds create a draft GitHub release. Finally, a maintainer manually marks the release as non-draft. This results in a poor user experience with updates, because the first step (tagging) would trigger a notification in all apps before the builds are even completed. This PR updates the notification checking logic to use the latest (non-draft) release, rather than the latest tag. This means that update notifications will not be sent out until a maintainer manually un-drafts a GitHub release as the final step of the process (we do this anyway as noted above). There's still a bit of a confusing situation for folks on Pikapods and in the Windows Store, where updates are not available as soon as we push them. But this should result in a better experience for those who do manage their own updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:16:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5668
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?