github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7658] feat(reports): scoped ErrorBoundaries for individual report routes #56621

New Issue
Open
opened 2026-05-01 04:36:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 04:36:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7658
Author: @tmchow
Created: 4/29/2026
Status: 🔄 Open

Base: master ← Head: osc/7391-error-boundaries-reports

📝 Commits (2)

  • 3f47d4f feat(reports): scoped ErrorBoundaries for individual report routes (#7391)
  • d32cf9f chore: rename release note to PR number

📊 Changes

2 files changed (+252 additions, -23 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ReportRouter.tsx (+246 -23)
➕ upcoming-release-notes/7658.md (+6 -0)

📄 Description

Description

This PR adds scoped ErrorBoundary wrappers around each individual report route in ReportRouter.tsx (NetWorth, CashFlow, Spending, CustomReport, Calendar, Formula, Summary, Crossover, AgeOfMoney, BudgetAnalysis, Sankey).

Today, a render error inside any of those report views bubbles up to the top-level FatalError boundary in App.tsx and crashes the whole app to the fatal-error screen. Wrapping each route in a FeatureErrorFallback boundary contains the failure to that one report — the rest of the app keeps working.

This is the next slice of #7391's table; the prior PRs (#7382 dashboard widgets, #7437 rules, #7497 budget/account/transactions/schedules/sidebar) already handled their respective areas. The dashboard view uses Overview.tsx's per-widget boundaries so it's intentionally not wrapped here.

The pattern matches the one already used for /rules routes in FinancesApp.tsx:

<Route
  path="/net-worth"
  element={
    <ErrorBoundary FallbackComponent={FeatureErrorFallback} resetKeys={[location.pathname]}>
      <NetWorth />
    </ErrorBoundary>
  }
/>

The resetKeys={[location.pathname]} lets the boundary auto-reset when the user navigates to a different report.

Related issue(s)

Relates to #7391

Testing

Manual:

  • Temporarily threw inside one of the wrapped report components and confirmed only that report shows the FeatureErrorFallback; the sidebar, header, and account list keep rendering.
  • Navigated between reports with the boundary tripped and confirmed the boundary resets on pathname change.
  • Removed test errors, ran yarn oxlint --type-aware --quiet and yarn oxfmt --check against the changed file — clean.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 35 14.01 MB → 14.02 MB (+6.94 kB) +0.05%
loot-core 1 5.26 MB 0%
api 2 3.89 MB 0%
cli 1 7.97 MB 0%
crdt 1 41.83 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
35 14.01 MB → 14.02 MB (+6.94 kB) +0.05%
Changeset
File Δ Size
src/components/reports/ReportRouter.tsx 📈 +6.94 kB (+97.60%) 7.11 kB → 14.04 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.22 MB → 1.23 MB (+6.94 kB) +0.56%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.87 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/PayeeRuleCountLabel.js 52.52 kB 0%
static/js/ScheduleEditForm.js 145.68 kB 0%
static/js/TransactionEdit.js 189.54 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.94 MB 0%
static/js/ca.js 191.46 kB 0%
static/js/chart-theme.js 796.5 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 104.22 kB 0%
static/js/de.js 173.88 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.89 kB 0%
static/js/es.js 182.3 kB 0%
static/js/extends.js 518.76 kB 0%
static/js/fr.js 182.5 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 168.33 kB 0%
static/js/narrow.js 364.31 kB 0%
static/js/nb-NO.js 151.39 kB 0%
static/js/nl.js 108.46 kB 0%
static/js/pl.js 88.14 kB 0%
static/js/pt-BR.js 193.24 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/ru.js 121.6 kB 0%
static/js/th.js 178.63 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 212.03 kB 0%
static/js/useFormatList.js 8.63 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 119.88 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.26 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.B5tkfYkU.js 5.26 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.89 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 41.83 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 41.83 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7658 **Author:** [@tmchow](https://github.com/tmchow) **Created:** 4/29/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `osc/7391-error-boundaries-reports` --- ### 📝 Commits (2) - [`3f47d4f`](https://github.com/actualbudget/actual/commit/3f47d4fc12b2801ec642c1d3cbf9d0d12260776f) feat(reports): scoped ErrorBoundaries for individual report routes (#7391) - [`d32cf9f`](https://github.com/actualbudget/actual/commit/d32cf9f58403e542d8a27a3656b3894a503e9935) chore: rename release note to PR number ### 📊 Changes **2 files changed** (+252 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ReportRouter.tsx` (+246 -23) ➕ `upcoming-release-notes/7658.md` (+6 -0) </details> ### 📄 Description ## Description This PR adds scoped `ErrorBoundary` wrappers around each individual report route in `ReportRouter.tsx` (NetWorth, CashFlow, Spending, CustomReport, Calendar, Formula, Summary, Crossover, AgeOfMoney, BudgetAnalysis, Sankey). Today, a render error inside any of those report views bubbles up to the top-level `FatalError` boundary in `App.tsx` and crashes the whole app to the fatal-error screen. Wrapping each route in a `FeatureErrorFallback` boundary contains the failure to that one report — the rest of the app keeps working. This is the next slice of #7391's table; the prior PRs (#7382 dashboard widgets, #7437 rules, #7497 budget/account/transactions/schedules/sidebar) already handled their respective areas. The dashboard view uses `Overview.tsx`'s per-widget boundaries so it's intentionally not wrapped here. The pattern matches the one already used for `/rules` routes in `FinancesApp.tsx`: ```tsx <Route path="/net-worth" element={ <ErrorBoundary FallbackComponent={FeatureErrorFallback} resetKeys={[location.pathname]}> <NetWorth /> </ErrorBoundary> } /> ``` The `resetKeys={[location.pathname]}` lets the boundary auto-reset when the user navigates to a different report. ## Related issue(s) Relates to #7391 ## Testing Manual: - Temporarily threw inside one of the wrapped report components and confirmed only that report shows the `FeatureErrorFallback`; the sidebar, header, and account list keep rendering. - Navigated between reports with the boundary tripped and confirmed the boundary resets on `pathname` change. - Removed test errors, ran `yarn oxlint --type-aware --quiet` and `yarn oxfmt --check` against the changed file — clean. ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 35 | 14.01 MB → 14.02 MB (+6.94 kB) | +0.05% loot-core | 1 | 5.26 MB | 0% api | 2 | 3.89 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 41.83 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 35 | 14.01 MB → 14.02 MB (+6.94 kB) | +0.05% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/ReportRouter.tsx` | 📈 +6.94 kB (+97.60%) | 7.11 kB → 14.04 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.22 MB → 1.23 MB (+6.94 kB) | +0.56% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.87 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/PayeeRuleCountLabel.js | 52.52 kB | 0% static/js/ScheduleEditForm.js | 145.68 kB | 0% static/js/TransactionEdit.js | 189.54 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.94 MB | 0% static/js/ca.js | 191.46 kB | 0% static/js/chart-theme.js | 796.5 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 104.22 kB | 0% static/js/de.js | 173.88 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.89 kB | 0% static/js/es.js | 182.3 kB | 0% static/js/extends.js | 518.76 kB | 0% static/js/fr.js | 182.5 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 168.33 kB | 0% static/js/narrow.js | 364.31 kB | 0% static/js/nb-NO.js | 151.39 kB | 0% static/js/nl.js | 108.46 kB | 0% static/js/pl.js | 88.14 kB | 0% static/js/pt-BR.js | 193.24 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/ru.js | 121.6 kB | 0% static/js/th.js | 178.63 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 212.03 kB | 0% static/js/useFormatList.js | 8.63 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 119.88 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.26 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.B5tkfYkU.js | 5.26 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.89 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 41.83 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 41.83 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 04:36:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#56621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?