github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7630] [CLOSED] Fix Category Group filtering in Monthly Spending report budgeted type #56604

New Issue
Closed
opened 2026-05-01 04:34:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 04:34:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7630
Author: @vedparkasharya
Created: 4/26/2026
Status: ❌ Closed

Base: master ← Head: fix/category-group-filter-monthly-spending

📝 Commits (1)

  • 323aff7 Fix category group filtering in Monthly Spending report

📊 Changes

2 files changed (+124 additions, -14 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts (+118 -14)
➕ upcoming-release-notes/7627.md (+6 -0)

📄 Description

Summary

Adds Category Group filtering support to the Monthly Spending report when using the Budgeted type, mirroring the fix previously applied to the Custom Report in #7628 and the Budget Analysis Report in #7116.

Problem

When creating a Monthly Spending report with Live/Budgeted mode, users could not filter by Category Group. The filter either had no effect or was silently stripped out because spending-spreadsheet.ts only allowed category conditions when building budgetFilters for the AQL budget query.

Solution

  1. Fetch all categories and category groups via get-categories
  2. Evaluate both category and category_group conditions client-side against the category list
  3. Remove the budgetFilters AQL restriction and instead fetch all budget rows for the month
  4. Filter the returned budgets by the allowed category IDs
  5. Calculate dailyBudget from the filtered set

This ensures the budgeted line in the Monthly Spending graph correctly respects Category Group filters.

Testing

  • Verified that category_group filters now correctly restrict the budgeted line
  • Existing category filters continue to work as before
  • No conditions still includes all categories (preserving existing behavior)

Fixes #7627

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7630 **Author:** [@vedparkasharya](https://github.com/vedparkasharya) **Created:** 4/26/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/category-group-filter-monthly-spending` --- ### 📝 Commits (1) - [`323aff7`](https://github.com/actualbudget/actual/commit/323aff7ce7277502c164ac1d1dea88368f697792) Fix category group filtering in Monthly Spending report ### 📊 Changes **2 files changed** (+124 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts` (+118 -14) ➕ `upcoming-release-notes/7627.md` (+6 -0) </details> ### 📄 Description ## Summary Adds Category Group filtering support to the Monthly Spending report when using the Budgeted type, mirroring the fix previously applied to the Custom Report in #7628 and the Budget Analysis Report in #7116. ## Problem When creating a Monthly Spending report with Live/Budgeted mode, users could not filter by Category Group. The filter either had no effect or was silently stripped out because `spending-spreadsheet.ts` only allowed `category` conditions when building `budgetFilters` for the AQL budget query. ## Solution 1. Fetch all categories and category groups via `get-categories` 2. Evaluate both `category` and `category_group` conditions client-side against the category list 3. Remove the `budgetFilters` AQL restriction and instead fetch all budget rows for the month 4. Filter the returned budgets by the allowed category IDs 5. Calculate `dailyBudget` from the filtered set This ensures the budgeted line in the Monthly Spending graph correctly respects Category Group filters. ## Testing - Verified that `category_group` filters now correctly restrict the budgeted line - Existing `category` filters continue to work as before - No conditions still includes all categories (preserving existing behavior) Fixes #7627 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 04:34:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#56604
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?