github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7584] [MERGED] [AI] Revert release note edit and make npm publish workflow ACT-compatible #56575

New Issue
Closed
opened 2026-05-01 04:31:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 04:31:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7584
Author: @Copilot
Created: 4/22/2026
Status: ✅ Merged
Merged: 4/22/2026
Merged by: @jfdoming

Base: copilot/refactor-npm-publish-workflows ← Head: copilot/sub-pr-7583

📝 Commits (2)

  • 5b211d6 Initial plan
  • f95b373 [AI] Revert release note edit and validate workflow with act

📊 Changes

4 files changed (+10 additions, -3 deletions)

View changed files

📝 .github/actions/setup/action.yml (+2 -2)
📝 .github/workflows/publish-npm-packages.yml (+1 -0)
📝 upcoming-release-notes/7579.md (+1 -1)
➕ upcoming-release-notes/7583.md (+6 -0)

📄 Description

This follow-up addresses review feedback on the unified npm publish workflow PR: the previous release-note file edit was reverted, a new PR-numbered release note was added, and local act execution was validated up to the pre-publish boundary.
During that act validation, workflow steps that are GitHub-runtime-specific were gated to avoid local-run failures.

  • Release notes

    • Reverted changes to upcoming-release-notes/7579.md.
    • Added a new note at upcoming-release-notes/7583.md (filename matches PR number).

  • ACT-safe CI behavior

    • Updated composite setup action to skip translation checkout/cleanup when running under act (env.ACT).
    • Updated npm publish workflow to skip artifact upload when running under act (env.ACT), since local act artifact runtime behavior differs from GitHub-hosted runs.

  • Workflow semantics preserved for GitHub Actions

    • The new guards only apply to local act runs; normal GitHub workflow paths remain unchanged.
# .github/actions/setup/action.yml
if: ${{ inputs.download-translations == 'true' && !env.ACT }}

# .github/workflows/publish-npm-packages.yml
- name: Upload package artifacts
  if: ${{ !env.ACT }}
  uses: actions/upload-artifact@...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7584 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 4/22/2026 **Status:** ✅ Merged **Merged:** 4/22/2026 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `copilot/refactor-npm-publish-workflows` ← **Head:** `copilot/sub-pr-7583` --- ### 📝 Commits (2) - [`5b211d6`](https://github.com/actualbudget/actual/commit/5b211d635d7e06b5036a7f9c0391e92c15884003) Initial plan - [`f95b373`](https://github.com/actualbudget/actual/commit/f95b3733163126c5964f62c0058a13efd85727b3) [AI] Revert release note edit and validate workflow with act ### 📊 Changes **4 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/setup/action.yml` (+2 -2) 📝 `.github/workflows/publish-npm-packages.yml` (+1 -0) 📝 `upcoming-release-notes/7579.md` (+1 -1) ➕ `upcoming-release-notes/7583.md` (+6 -0) </details> ### 📄 Description This follow-up addresses review feedback on the unified npm publish workflow PR: the previous release-note file edit was reverted, a new PR-numbered release note was added, and local `act` execution was validated up to the pre-publish boundary. During that `act` validation, workflow steps that are GitHub-runtime-specific were gated to avoid local-run failures. - **Release notes** - Reverted changes to `upcoming-release-notes/7579.md`. - Added a new note at `upcoming-release-notes/7583.md` (filename matches PR number). - **ACT-safe CI behavior** - Updated composite setup action to skip translation checkout/cleanup when running under `act` (`env.ACT`). - Updated npm publish workflow to skip artifact upload when running under `act` (`env.ACT`), since local `act` artifact runtime behavior differs from GitHub-hosted runs. - **Workflow semantics preserved for GitHub Actions** - The new guards only apply to local `act` runs; normal GitHub workflow paths remain unchanged. ```yaml # .github/actions/setup/action.yml if: ${{ inputs.download-translations == 'true' && !env.ACT }} # .github/workflows/publish-npm-packages.yml - name: Upload package artifacts if: ${{ !env.ACT }} uses: actions/upload-artifact@... ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 04:31:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#56575
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?