[PR #7520] [MERGED] fix some more GitHub code quality issues #56528

New Issue

GiteaMirror · 2026-05-01T04:27:24-05:00

GiteaMirror commented

2026-05-01 04:27:24 -05:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7520
Author: @matt-fidd
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/16/2026
Merged by: @matt-fidd

Base: master ← Head: ai-findings-autofix/packages-desktop-client-src-components-modals-EditFieldModal.tsx

📝 Commits (5)

fb7c063 Apply suggested fix to packages/desktop-client/src/components/modals/EditFieldModal.tsx from Copilot Autofix
1371ae5 Apply suggested fix to packages/desktop-client/src/components/modals/EditFieldModal.tsx from Copilot Autofix
89ca036 note
f1d19fc fix typo in note
606d2b9 remove useless conditions

📊 Changes

13 files changed (+29 additions, -33 deletions)

View changed files

📝 packages/desktop-client/src/components/Notes.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+1 -5)
📝 packages/desktop-client/src/components/budget/util.ts (+1 -1)
📝 packages/desktop-client/src/components/modals/EditFieldModal.tsx (+3 -1)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/Crossover.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+7 -9)
📝 packages/loot-core/src/platform/server/connection/index.electron.ts (+1 -3)
📝 packages/loot-core/src/platform/server/connection/index.ts (+1 -3)
📝 packages/loot-core/src/server/budget/actions.ts (+1 -1)
📝 packages/sync-server/src/account-db.js (+4 -6)
📝 upcoming-release-notes/7496.md (+1 -1)
➕ upcoming-release-notes/7520.md (+6 -0)

📄 Description

Fixes some dead conditionals, and some more things flagged in https://github.com/actualbudget/actual/security/quality/ai-findings

Bundle Stats

Bundle	Files count	Total bundle size	% Changed
desktop-client	34	12.92 MB → 12.92 MB (-185 B)	-0.00%
loot-core	1	4.85 MB → 4.85 MB (-35 B)	-0.00%
api	1	3.88 MB → 3.88 MB (-14 B)	-0.00%
cli	1	7.91 MB	0%

View detailed bundle stats

desktop-client

Total

Files count	Total bundle size	% Changed
34	12.92 MB → 12.92 MB (-185 B)	-0.00%

Changeset

File	Δ	Size
`src/components/modals/EditFieldModal.tsx`	📈 +63 B (+0.75%)	8.18 kB → 8.25 kB
`src/components/transactions/TransactionsTable.tsx`	📉 -24 B (-0.03%)	88.41 kB → 88.39 kB
`src/components/reports/reports/Calendar.tsx`	📉 -25 B (-0.09%)	27.61 kB → 27.58 kB
`src/components/reports/reports/Crossover.tsx`	📉 -117 B (-0.28%)	41.27 kB → 41.16 kB
`src/components/budget/util.ts`	📉 -16 B (-0.48%)	3.24 kB → 3.22 kB
`src/components/budget/SidebarGroup.tsx`	📉 -54 B (-0.58%)	9.17 kB → 9.11 kB
`src/components/Notes.tsx`	📉 -12 B (-0.59%)	2 kB → 1.99 kB

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	1.85 MB → 1.85 MB (+9 B)	+0.00%

Smaller

Asset	File Size	% Changed
static/js/ReportRouter.js	1.18 MB → 1.18 MB (-142 B)	-0.01%
static/js/Value.js	4.34 MB → 4.34 MB (-52 B)	-0.00%

Unchanged

Asset	File Size	% Changed
static/js/BackgroundImage.js	121.09 kB	0%
static/js/FormulaEditor.js	814.39 kB	0%
static/js/PayeeRuleCountLabel.js	52.12 kB	0%
static/js/ScheduleEditForm.js	136.13 kB	0%
static/js/TransactionEdit.js	185.13 kB	0%
static/js/TransactionList.js	82.8 kB	0%
static/js/ca.js	191.72 kB	0%
static/js/chart-theme.js	705.55 kB	0%
static/js/client.js	450.92 kB	0%
static/js/da.js	104.4 kB	0%
static/js/de.js	174.12 kB	0%
static/js/en-GB.js	8.2 kB	0%
static/js/en.js	176.5 kB	0%
static/js/es.js	181.54 kB	0%
static/js/extends.js	486.5 kB	0%
static/js/fr.js	176.79 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.46 kB	0%
static/js/it.js	165.68 kB	0%
static/js/narrow.js	363.68 kB	0%
static/js/nb-NO.js	151.58 kB	0%
static/js/nl.js	108.66 kB	0%
static/js/pl.js	88.34 kB	0%
static/js/pt-BR.js	177.18 kB	0%
static/js/resize-observer.js	18.06 kB	0%
static/js/th.js	178.91 kB	0%
static/js/theme.js	30.79 kB	0%
static/js/uk.js	212.28 kB	0%
static/js/useFormatList.js	9.86 kB	0%
static/js/wide.js	292 B	0%
static/js/workbox-window.prod.es5.js	7.33 kB	0%
static/js/zh-Hans.js	110.19 kB	0%

loot-core

Total

Files count	Total bundle size	% Changed
1	4.85 MB → 4.85 MB (-35 B)	-0.00%

Changeset

File	Δ	Size
`home/runner/work/actual/actual/packages/loot-core/src/server/budget/actions.ts`	📉 -14 B (-0.12%)	11.36 kB → 11.35 kB
`home/runner/work/actual/actual/packages/loot-core/src/platform/server/connection/index.ts`	📉 -21 B (-0.67%)	3.07 kB → 3.05 kB

View detailed bundle breakdown

Added

Asset	File Size	% Changed
kcab.worker.CkAYdgmR.js	0 B → 4.85 MB (+4.85 MB)	-

Removed

Asset	File Size	% Changed
kcab.worker.Dtv5lNQw.js	4.85 MB → 0 B (-4.85 MB)	-100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count	Total bundle size	% Changed
1	3.88 MB → 3.88 MB (-14 B)	-0.00%

Changeset

File	Δ	Size
`home/runner/work/actual/actual/packages/loot-core/src/server/budget/actions.ts`	📉 -14 B (-0.12%)	11.06 kB → 11.04 kB

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset	File Size	% Changed
index.js	3.88 MB → 3.88 MB (-14 B)	-0.00%

Unchanged
No assets were unchanged

cli

Total

Files count	Total bundle size	% Changed
1	7.91 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
cli.js	7.91 MB	0%

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7520 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/16/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `ai-findings-autofix/packages-desktop-client-src-components-modals-EditFieldModal.tsx` --- ### 📝 Commits (5) - [`fb7c063`](https://github.com/actualbudget/actual/commit/fb7c0633009a20c1468444326be2ee2ed4360d16) Apply suggested fix to packages/desktop-client/src/components/modals/EditFieldModal.tsx from Copilot Autofix - [`1371ae5`](https://github.com/actualbudget/actual/commit/1371ae5efa575ae7829212a27aed7b6ce4037638) Apply suggested fix to packages/desktop-client/src/components/modals/EditFieldModal.tsx from Copilot Autofix - [`89ca036`](https://github.com/actualbudget/actual/commit/89ca03681600cd04ffcae9462ff3f8b8dd6c92a7) note - [`f1d19fc`](https://github.com/actualbudget/actual/commit/f1d19fc9a64b4e89d732ec8645e70be22694e49e) fix typo in note - [`606d2b9`](https://github.com/actualbudget/actual/commit/606d2b9341dfa54a849ec29e49fa3cf2fa5ff911) remove useless conditions ### 📊 Changes **13 files changed** (+29 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Notes.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+1 -5) 📝 `packages/desktop-client/src/components/budget/util.ts` (+1 -1) 📝 `packages/desktop-client/src/components/modals/EditFieldModal.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/Crossover.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+7 -9) 📝 `packages/loot-core/src/platform/server/connection/index.electron.ts` (+1 -3) 📝 `packages/loot-core/src/platform/server/connection/index.ts` (+1 -3) 📝 `packages/loot-core/src/server/budget/actions.ts` (+1 -1) 📝 `packages/sync-server/src/account-db.js` (+4 -6) 📝 `upcoming-release-notes/7496.md` (+1 -1) ➕ `upcoming-release-notes/7520.md` (+6 -0) </details> ### 📄 Description Fixes some dead conditionals, and some more things flagged in https://github.com/actualbudget/actual/security/quality/ai-findings  <hr />  ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 12.92 MB → 12.92 MB (-185 B) | -0.00% loot-core | 1 | 4.85 MB → 4.85 MB (-35 B) | -0.00% api | 1 | 3.88 MB → 3.88 MB (-14 B) | -0.00% cli | 1 | 7.91 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 12.92 MB → 12.92 MB (-185 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/modals/EditFieldModal.tsx` | 📈 +63 B (+0.75%) | 8.18 kB → 8.25 kB `src/components/transactions/TransactionsTable.tsx` | 📉 -24 B (-0.03%) | 88.41 kB → 88.39 kB `src/components/reports/reports/Calendar.tsx` | 📉 -25 B (-0.09%) | 27.61 kB → 27.58 kB `src/components/reports/reports/Crossover.tsx` | 📉 -117 B (-0.28%) | 41.27 kB → 41.16 kB `src/components/budget/util.ts` | 📉 -16 B (-0.48%) | 3.24 kB → 3.22 kB `src/components/budget/SidebarGroup.tsx` | 📉 -54 B (-0.58%) | 9.17 kB → 9.11 kB `src/components/Notes.tsx` | 📉 -12 B (-0.59%) | 2 kB → 1.99 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.85 MB → 1.85 MB (+9 B) | +0.00% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.18 MB → 1.18 MB (-142 B) | -0.01% static/js/Value.js | 4.34 MB → 4.34 MB (-52 B) | -0.00% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 814.39 kB | 0% static/js/PayeeRuleCountLabel.js | 52.12 kB | 0% static/js/ScheduleEditForm.js | 136.13 kB | 0% static/js/TransactionEdit.js | 185.13 kB | 0% static/js/TransactionList.js | 82.8 kB | 0% static/js/ca.js | 191.72 kB | 0% static/js/chart-theme.js | 705.55 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 104.4 kB | 0% static/js/de.js | 174.12 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.5 kB | 0% static/js/es.js | 181.54 kB | 0% static/js/extends.js | 486.5 kB | 0% static/js/fr.js | 176.79 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.68 kB | 0% static/js/narrow.js | 363.68 kB | 0% static/js/nb-NO.js | 151.58 kB | 0% static/js/nl.js | 108.66 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.18 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.91 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.28 kB | 0% static/js/useFormatList.js | 9.86 kB | 0% static/js/wide.js | 292 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 110.19 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.85 MB → 4.85 MB (-35 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/budget/actions.ts` | 📉 -14 B (-0.12%) | 11.36 kB → 11.35 kB `home/runner/work/actual/actual/packages/loot-core/src/platform/server/connection/index.ts` | 📉 -21 B (-0.67%) | 3.07 kB → 3.05 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.CkAYdgmR.js | 0 B → 4.85 MB (+4.85 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Dtv5lNQw.js | 4.85 MB → 0 B (-4.85 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.88 MB → 3.88 MB (-14 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/budget/actions.ts` | 📉 -14 B (-0.12%) | 11.06 kB → 11.04 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.88 MB → 3.88 MB (-14 B) | -0.00% **Unchanged** No assets were unchanged </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.91 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.91 MB | 0% </div> </details> </details>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-01 04:27:24 -05:00

GiteaMirror closed this issue

2026-05-01 04:27:27 -05:00

Sign in to join this conversation.

Branches Tags

master

claude/hide-default-categories-1cwBZ

matiss/crdt-source-loading

youngcw/unlock-duplicates

matiss/crdt-protobuf

release/26.5.0

claude/update-issue-template-ykMNn

claude/fix-issue-7667-DPXi3

cursor/formula-feedback-improvements-4223

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

jfdoming/api-tokens-part-3

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-1

claude/speed-up-vrt-workflow-ZAyI5

claude/crdt-version-auto-publish-Ph1BH

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

worktree-mellow-strolling-dawn

matiss/browser-api

claude/api-consumer-verification-kfz1K

feature/enable-banking

cursor/transaction-table-rewrite-f077

pr-7454

claude/fix-issue-7410-LLLQ4

release/v100.0.0

revert-7350-trim-deps

revert-7220-sankey-report

revert-7242-fix/split-parent-update-corruption

revert-7281-generate-icons

claude/electron-to-tauri-migration-LjBN8

worktree-remotion

release/vv26.4.0-pre

claude/browser-compatible-api-QbhHh

claude/improve-cli-transactions-waTUY

claude/publish-react-native-ios-j8qoT

js-proxy

claude/fix-flaky-ci-job-5gDdz

react-query-rules

react-query-useSchedules

claude/nightly-theme-validation-scan-DzOGD

claude/debug-simplefin-error-ZuKzB

matiss/desktop-client-subpath-imports

claude/fix-simplefin-ssrf-T31gX

claude/release-notes-validation-X7rvR

add-claude-github-actions-1772738270730

cursor/sync-performance-notification-9899

react-query-prefs

matiss/chunked-sync-and-progress-ux

v26.2.1

copilot/sub-pr-6880

fix-react-query-clear-on-close-budget

copilot/sub-pr-6140

feat/auto-note

feat/scoped-bank-sync

cursor/desktop-transactions-react-table-1d0c

fix-exhaustive-deps-App

copilot/fix-find-replace-bug

release/v26.2.0-pre

matiss/browser-tests

mobile-fix-drag-and-drop-across-groups

budget-table-v2

PayeeAutocomplete2

pglite

bugfix/plugins/fix-plugins-sw

feat/plugins/plugins-core-package

prerelease

matiss/unicode-minus-fix

cursor/fix-actual-github-issue-6206-gemini-3-pro-preview-9c37

TransactionFormPage

cursor/implement-mortgage-and-loan-account-type-78ca

tests-update-fill-with-pressSequentially

mobile/link-modal

deps/25.11

cursor/fix-update-vrt-apply-ci-job-dispatch-b324

sync-server-plugins

cursor/propose-patch-for-github-issue-5680-2a18

fix/compiler-preserve-inner-dollar-escapes

cursor/analyze-actual-budget-issue-and-propose-fix-5b70

coderabbitai/docstrings/0c070e5

cursor/add-wip-prefix-and-comment-to-prs-d78d

jfdoming/08-21-auto-focus-on-navigate-in-all-browsers

show-totals-on-mobile-budget-banners

allow-child-transactions-make-transfer

mobile-calculator-keyboard

payee-geolocation

enhance/restore_scroll_position

dm-fix-second-click-on-mobile-new-transaction-2

scrollToLocationBudget

alert-autofix-38

tsconfig-composite

mobile-fix-uncategorized-transactions-on-tracking-budgets

server-budget-handlers

fix-sql-injection-in-cleanup-template

non-chrome-draggable-workaround

mobile-budget-page-swipe-navigation

ts-db-all

stable

dark-theme-with-brand-colors

fix-mobile-delete-group

ts-db-select

UnderKoen/reconcile-context-menu

master-before-server-merge

v25.2.1

ts-runQuery

rename-redux-hooks

UnderKoen/3557-persist-state-in-history

remove-redux-CLOSE_BUDGET

fix-exhaustive-deps-errors-FinancesApp

redux-toolkit-createSlice-backup

accounts-function-component

ts-useSplitsExpanded

loot-core-server-package

useTransactios-in-TransactionEdit

react-aria-input

move-redux-to-desktop-client

QueryState-type

fix-themes-applied-late

mobile-vrts

revert-3295-spendingCardFix

react-aria-button-4

split-payee-on-mobile

twk3/pin-apis-crdt

notes-tag-autocomplete

ts-LoadBackup

dnd-kit

package-upgrades

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#56528