github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7397] [MERGED] Add documentation for self-signed cert healthchecks #56437

New Issue
Closed
opened 2026-05-01 04:18:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 04:18:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7397
Author: @Kennedy242
Created: 4/6/2026
Status: ✅ Merged
Merged: 4/7/2026
Merged by: @matt-fidd

Base: master ← Head: update/self-host-docs

📝 Commits (10+)

  • 607064c Add documentation for self-signed cert healthchecks
  • 6f60913 [autofix.ci] apply automated fixes
  • 35c0671 fixup! Add documentation for self-signed cert healthchecks
  • 13f5887 [autofix.ci] apply automated fixes
  • bb4e8cf Update Docker health checks with self-signed certs
  • 459279f fixup! Update Docker health checks with self-signed certs
  • 02c9488 fixup! Add documentation for self-signed cert healthchecks
  • 4946851 fixup! Update Docker health checks with self-signed certs
  • 84fcc9c [autofix.ci] apply automated fixes
  • b2a19d1 fixup! Add documentation for self-signed cert healthchecks

📊 Changes

3 files changed (+17 additions, -0 deletions)

View changed files

📝 packages/docs/docs/config/https.md (+9 -0)
📝 packages/sync-server/docker-compose.yml (+2 -0)
➕ upcoming-release-notes/7397.md (+6 -0)

📄 Description

Description

Adds instruction to set NODE_EXTRA_CA_CERTS in docker-compose healthcheck commands so Node.js can trust the certificate.

The issue was that when using self-signed certs, the docker healthcheck was reporting unhealthy when it should be healthy.

Related issue(s)

Fixes #7135

Testing

If there is a better or more general solution I'll be happy to update this PR. I locally implemented this solution and its working for me.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7397 **Author:** [@Kennedy242](https://github.com/Kennedy242) **Created:** 4/6/2026 **Status:** ✅ Merged **Merged:** 4/7/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `update/self-host-docs` --- ### 📝 Commits (10+) - [`607064c`](https://github.com/actualbudget/actual/commit/607064c4f553b1e215f0689280433221349d198b) Add documentation for self-signed cert healthchecks - [`6f60913`](https://github.com/actualbudget/actual/commit/6f609135148bcaf6f93501d3531e4a46b3329a08) [autofix.ci] apply automated fixes - [`35c0671`](https://github.com/actualbudget/actual/commit/35c067163fe1a0625504023b95be4b2fa022827b) fixup! Add documentation for self-signed cert healthchecks - [`13f5887`](https://github.com/actualbudget/actual/commit/13f5887a5c7ad4f69230263d6f07720d6db8cbdb) [autofix.ci] apply automated fixes - [`bb4e8cf`](https://github.com/actualbudget/actual/commit/bb4e8cf0daabc5d114059067d074294e9a52ff83) Update Docker health checks with self-signed certs - [`459279f`](https://github.com/actualbudget/actual/commit/459279fba02f7cfae30bd9158f52a1367bf7197d) fixup! Update Docker health checks with self-signed certs - [`02c9488`](https://github.com/actualbudget/actual/commit/02c94883a5dfda1073f410121b632d1df851b844) fixup! Add documentation for self-signed cert healthchecks - [`4946851`](https://github.com/actualbudget/actual/commit/49468518781ff96ea66ae2b4423e5436541a970a) fixup! Update Docker health checks with self-signed certs - [`84fcc9c`](https://github.com/actualbudget/actual/commit/84fcc9ce6725c85ba254dee2abbfb49ea59acf26) [autofix.ci] apply automated fixes - [`b2a19d1`](https://github.com/actualbudget/actual/commit/b2a19d1c8cd1c3973e7e411b42a15507a34b9109) fixup! Add documentation for self-signed cert healthchecks ### 📊 Changes **3 files changed** (+17 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/docs/docs/config/https.md` (+9 -0) 📝 `packages/sync-server/docker-compose.yml` (+2 -0) ➕ `upcoming-release-notes/7397.md` (+6 -0) </details> ### 📄 Description ## Description Adds instruction to set NODE_EXTRA_CA_CERTS in docker-compose healthcheck commands so Node.js can trust the certificate. The issue was that when using self-signed certs, the docker healthcheck was reporting unhealthy when it should be healthy. ## Related issue(s) Fixes #7135 ## Testing If there is a better or more general solution I'll be happy to update this PR. I locally implemented this solution and its working for me. ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 04:18:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#56437
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?