github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #7364] [AI] Fix iOS: auto-focus Amount field when adding a transaction #56413

New Issue
Open
opened 2026-05-01 04:16:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 04:16:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7364
Author: @jj33
Created: 4/3/2026
Status: 🔄 Open

Base: master ← Head: fix/ios-amount-autofocus

📝 Commits (6)

  • 67b52ff [AI] Fix iOS mobile: auto-focus Amount field when adding a transaction
  • 25e113f [autofix.ci] apply automated fixes
  • d7e604c [AI] Add release notes for #7364
  • 81e97ea [AI] Fix stale timeout race in iOS keyboard proxy
  • 025c9e2 [AI] Fix import paths after rebase onto master
  • fdc808f Merge branch 'master' into fix/ios-amount-autofocus

📊 Changes

5 files changed (+90 additions, -9 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/transactions/AddTransactionButton.tsx (+16 -0)
📝 packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx (+11 -2)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+2 -7)
➕ packages/desktop-client/src/components/mobile/transactions/iosKeyboardProxy.ts (+55 -0)
➕ upcoming-release-notes/7364.md (+6 -0)

📄 Description

Summary

  • On iOS Safari, tapping "Add Transaction" opens the form but does not focus the Amount field or open the keyboard — requiring an extra tap. Android does not have this issue.
  • Root cause: iOS blocks programmatic input.focus() from opening the keyboard unless called inside a synchronous user-gesture handler. By the time TransactionEdit mounts, the gesture chain is broken.
  • Fix: use a proxy-input technique — focus a hidden <input> synchronously during the tap, then transfer focus to the real Amount input when the page mounts. The keyboard stays open through the transition.

Test plan

  • On iOS Safari (iPhone): tap Add Transaction → Amount field should be focused with keyboard open immediately
  • On Android Chrome: behavior unchanged — Amount field auto-focuses as before
  • On Desktop: behavior unchanged
  • Verify the keyboard proxy is cleaned up (no orphaned hidden inputs in DOM after navigation)
  • Verify the 3s safety timeout cleans up the proxy if navigation is somehow cancelled

🤖 Generated with Claude Code

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 → 35 13.88 MB → 14.01 MB (+123.69 kB) +0.87%
loot-core 1 5.27 MB 0%
api 2 3.89 MB 0%
cli 1 7.97 MB 0%
crdt 1 41.83 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 → 35 13.88 MB → 14.01 MB (+123.69 kB) +0.87%
Changeset
File Δ Size
locale/ru.json 🆕 +121.6 kB 0 B → 121.6 kB
src/components/mobile/transactions/iosKeyboardProxy.ts 🆕 +1.71 kB 0 B → 1.71 kB
src/components/mobile/transactions/AddTransactionButton.tsx 📈 +81 B (+6.19%) 1.28 kB → 1.36 kB
src/languages.ts 📈 +99 B (+6.17%) 1.57 kB → 1.66 kB
src/components/mobile/transactions/FocusableAmountInput.tsx 📈 +87 B (+0.68%) 12.45 kB → 12.54 kB
locale/zh-Hans.json 📈 +143 B (+0.12%) 119.74 kB → 119.88 kB
src/components/mobile/transactions/TransactionEdit.tsx 📉 -21 B (-0.03%) 61.1 kB → 61.08 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
static/js/ru.js 0 B → 121.6 kB (+121.6 kB) -

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/TransactionEdit.js 186.56 kB → 188.33 kB (+1.77 kB) +0.95%
static/js/zh-Hans.js 119.74 kB → 119.88 kB (+143 B) +0.12%
static/js/extends.js 518.66 kB → 518.76 kB (+99 B) +0.02%
static/js/narrow.js 364.31 kB → 364.39 kB (+81 B) +0.02%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.87 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/PayeeRuleCountLabel.js 52.52 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/ScheduleEditForm.js 145.68 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.94 MB 0%
static/js/ca.js 191.46 kB 0%
static/js/chart-theme.js 796.5 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 104.22 kB 0%
static/js/de.js 173.88 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.89 kB 0%
static/js/es.js 182.25 kB 0%
static/js/fr.js 182.5 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 168.33 kB 0%
static/js/nb-NO.js 151.39 kB 0%
static/js/nl.js 108.46 kB 0%
static/js/pl.js 88.14 kB 0%
static/js/pt-BR.js 193.24 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.63 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 212.03 kB 0%
static/js/useFormatList.js 8.63 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.27 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.tCyo0gRC.js 5.27 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.89 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 41.83 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 41.83 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7364 **Author:** [@jj33](https://github.com/jj33) **Created:** 4/3/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/ios-amount-autofocus` --- ### 📝 Commits (6) - [`67b52ff`](https://github.com/actualbudget/actual/commit/67b52ff5754cf2b722fe32a4871c462f1011cf01) [AI] Fix iOS mobile: auto-focus Amount field when adding a transaction - [`25e113f`](https://github.com/actualbudget/actual/commit/25e113f266afb093af401849b31a7292a1a7dfcb) [autofix.ci] apply automated fixes - [`d7e604c`](https://github.com/actualbudget/actual/commit/d7e604c94931a5e4b571055c91cd49afb55e2791) [AI] Add release notes for #7364 - [`81e97ea`](https://github.com/actualbudget/actual/commit/81e97ea980d144a355e21951bc0cc9c58620cd06) [AI] Fix stale timeout race in iOS keyboard proxy - [`025c9e2`](https://github.com/actualbudget/actual/commit/025c9e2355b87b71ab851eaf4ca13aa722e7011b) [AI] Fix import paths after rebase onto master - [`fdc808f`](https://github.com/actualbudget/actual/commit/fdc808f4734cbe88f9233a82d03bf6b3b0f536e9) Merge branch 'master' into fix/ios-amount-autofocus ### 📊 Changes **5 files changed** (+90 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/transactions/AddTransactionButton.tsx` (+16 -0) 📝 `packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx` (+11 -2) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+2 -7) ➕ `packages/desktop-client/src/components/mobile/transactions/iosKeyboardProxy.ts` (+55 -0) ➕ `upcoming-release-notes/7364.md` (+6 -0) </details> ### 📄 Description ## Summary - On iOS Safari, tapping "Add Transaction" opens the form but **does not focus the Amount field** or open the keyboard — requiring an extra tap. Android does not have this issue. - Root cause: iOS blocks programmatic `input.focus()` from opening the keyboard unless called inside a synchronous user-gesture handler. By the time `TransactionEdit` mounts, the gesture chain is broken. - Fix: use a proxy-input technique — focus a hidden `<input>` synchronously during the tap, then transfer focus to the real Amount input when the page mounts. The keyboard stays open through the transition. ## Test plan - [ ] On **iOS Safari** (iPhone): tap Add Transaction → Amount field should be focused with keyboard open immediately - [ ] On **Android Chrome**: behavior unchanged — Amount field auto-focuses as before - [ ] On **Desktop**: behavior unchanged - [ ] Verify the keyboard proxy is cleaned up (no orphaned hidden inputs in DOM after navigation) - [ ] Verify the 3s safety timeout cleans up the proxy if navigation is somehow cancelled 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 → 35 | 13.88 MB → 14.01 MB (+123.69 kB) | +0.87% loot-core | 1 | 5.27 MB | 0% api | 2 | 3.89 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 41.83 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 → 35 | 13.88 MB → 14.01 MB (+123.69 kB) | +0.87% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `locale/ru.json` | 🆕 +121.6 kB | 0 B → 121.6 kB `src/components/mobile/transactions/iosKeyboardProxy.ts` | 🆕 +1.71 kB | 0 B → 1.71 kB `src/components/mobile/transactions/AddTransactionButton.tsx` | 📈 +81 B (+6.19%) | 1.28 kB → 1.36 kB `src/languages.ts` | 📈 +99 B (+6.17%) | 1.57 kB → 1.66 kB `src/components/mobile/transactions/FocusableAmountInput.tsx` | 📈 +87 B (+0.68%) | 12.45 kB → 12.54 kB `locale/zh-Hans.json` | 📈 +143 B (+0.12%) | 119.74 kB → 119.88 kB `src/components/mobile/transactions/TransactionEdit.tsx` | 📉 -21 B (-0.03%) | 61.1 kB → 61.08 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- static/js/ru.js | 0 B → 121.6 kB (+121.6 kB) | - **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/TransactionEdit.js | 186.56 kB → 188.33 kB (+1.77 kB) | +0.95% static/js/zh-Hans.js | 119.74 kB → 119.88 kB (+143 B) | +0.12% static/js/extends.js | 518.66 kB → 518.76 kB (+99 B) | +0.02% static/js/narrow.js | 364.31 kB → 364.39 kB (+81 B) | +0.02% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.87 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/PayeeRuleCountLabel.js | 52.52 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 145.68 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.94 MB | 0% static/js/ca.js | 191.46 kB | 0% static/js/chart-theme.js | 796.5 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 104.22 kB | 0% static/js/de.js | 173.88 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.89 kB | 0% static/js/es.js | 182.25 kB | 0% static/js/fr.js | 182.5 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 168.33 kB | 0% static/js/nb-NO.js | 151.39 kB | 0% static/js/nl.js | 108.46 kB | 0% static/js/pl.js | 88.14 kB | 0% static/js/pt-BR.js | 193.24 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.63 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 212.03 kB | 0% static/js/useFormatList.js | 8.63 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.27 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.tCyo0gRC.js | 5.27 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.89 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 41.83 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 41.83 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 04:16:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#56413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?