github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4859] [MERGED] Move loot-core to vitest #5626

New Issue
Closed
opened 2026-02-28 21:15:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:15:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4859
Author: @jfdoming
Created: 4/20/2025
Status: ✅ Merged
Merged: 4/20/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/vitest-4

📝 Commits (6)

  • 8772aee Update build + dependencies to work with vitest
  • 83339ad Update tests to use vitest
  • 7e85b07 Update snapshots to vitest format
  • c095a39 Update sql.js loading in tests to work with vitest
  • 474e335 Update crdt package loading to work with vitest
  • 5098340 Add release notes

📊 Changes

44 files changed (+486 additions, -1280 deletions)

View changed files

📝 eslint.config.mjs (+0 -1)
📝 packages/crdt/index.ts (+1 -1)
📝 packages/crdt/src/index.ts (+0 -0)
📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/setupTests.js (+1 -1)
➖ packages/loot-core/jest.config.js (+0 -23)
➖ packages/loot-core/jest.web.config.js (+0 -20)
📝 packages/loot-core/package.json (+4 -8)
➖ packages/loot-core/peg-transform.mjs (+0 -27)
📝 packages/loot-core/src/client/query-helpers.test.ts (+6 -3)
📝 packages/loot-core/src/mocks/setup.ts (+13 -9)
📝 packages/loot-core/src/mocks/util.ts (+21 -0)
📝 packages/loot-core/src/platform/server/fs/index.web.test.ts (+4 -2)
📝 packages/loot-core/src/platform/server/sqlite/index.web.test.ts (+11 -6)
📝 packages/loot-core/src/platform/server/sqlite/index.web.ts (+4 -2)
📝 packages/loot-core/src/server/__snapshots__/main.test.ts.snap (+9 -9)
📝 packages/loot-core/src/server/__snapshots__/sheet.test.ts.snap (+5 -5)
📝 packages/loot-core/src/server/accounts/__snapshots__/sync.test.ts.snap (+4 -4)
📝 packages/loot-core/src/server/accounts/sync.test.ts (+7 -7)
📝 packages/loot-core/src/server/api.test.ts (+4 -4)

...and 24 more files

📄 Description

Follow-up PR to https://github.com/actualbudget/actual/pull/4856, https://github.com/actualbudget/actual/pull/4851, and https://github.com/actualbudget/actual/pull/4840. Strongly suggest reviewing by commit since there are many needed changes, but each commit is self-contained.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4859 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 4/20/2025 **Status:** ✅ Merged **Merged:** 4/20/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/vitest-4` --- ### 📝 Commits (6) - [`8772aee`](https://github.com/actualbudget/actual/commit/8772aee5dd8efed6b60b8843b2df43a636e250e9) Update build + dependencies to work with vitest - [`83339ad`](https://github.com/actualbudget/actual/commit/83339ad982aedecbe9734f01e8db14e97651a394) Update tests to use vitest - [`7e85b07`](https://github.com/actualbudget/actual/commit/7e85b07305ba5adf31ba75a33a3e7d6afaf55186) Update snapshots to vitest format - [`c095a39`](https://github.com/actualbudget/actual/commit/c095a3991a1d0462c5cf6fa3e2467c06b720c4e7) Update sql.js loading in tests to work with vitest - [`474e335`](https://github.com/actualbudget/actual/commit/474e335e5e39ebb029d05b9b1f53e792868e7b3d) Update crdt package loading to work with vitest - [`5098340`](https://github.com/actualbudget/actual/commit/50983403111ab2bd065de3f06021db2696c46cec) Add release notes ### 📊 Changes **44 files changed** (+486 additions, -1280 deletions) <details> <summary>View changed files</summary> 📝 `eslint.config.mjs` (+0 -1) 📝 `packages/crdt/index.ts` (+1 -1) 📝 `packages/crdt/src/index.ts` (+0 -0) 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/setupTests.js` (+1 -1) ➖ `packages/loot-core/jest.config.js` (+0 -23) ➖ `packages/loot-core/jest.web.config.js` (+0 -20) 📝 `packages/loot-core/package.json` (+4 -8) ➖ `packages/loot-core/peg-transform.mjs` (+0 -27) 📝 `packages/loot-core/src/client/query-helpers.test.ts` (+6 -3) 📝 `packages/loot-core/src/mocks/setup.ts` (+13 -9) 📝 `packages/loot-core/src/mocks/util.ts` (+21 -0) 📝 `packages/loot-core/src/platform/server/fs/index.web.test.ts` (+4 -2) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.test.ts` (+11 -6) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.ts` (+4 -2) 📝 `packages/loot-core/src/server/__snapshots__/main.test.ts.snap` (+9 -9) 📝 `packages/loot-core/src/server/__snapshots__/sheet.test.ts.snap` (+5 -5) 📝 `packages/loot-core/src/server/accounts/__snapshots__/sync.test.ts.snap` (+4 -4) 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+7 -7) 📝 `packages/loot-core/src/server/api.test.ts` (+4 -4) _...and 24 more files_ </details> ### 📄 Description Follow-up PR to https://github.com/actualbudget/actual/pull/4856, https://github.com/actualbudget/actual/pull/4851, and https://github.com/actualbudget/actual/pull/4840. Strongly suggest [reviewing by commit](https://github.com/actualbudget/actual/pull/4859/commits/8772aee5dd8efed6b60b8843b2df43a636e250e9) since there are many needed changes, but each commit is self-contained. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:15:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5626
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?