github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6627] [MERGED] Copy all old colors from colors.ts to palette.ts #55941

New Issue
Closed
opened 2026-05-01 03:22:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 03:22:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6627
Author: @Juulz
Created: 1/11/2026
Status: ✅ Merged
Merged: 1/14/2026
Merged by: @youngcw

Base: master ← Head: colors-to-palette

📝 Commits (10+)

  • b129147 Update color palette with old color values
  • 505c662 Update color palette with new values
  • f57b261 Replace old color imports with old color definitions
  • 35318e3 Update color exports to use consistent casing
  • b0a7b18 Fix export statements for color constants
  • 9d3bf81 Clean up palette.ts by removing old import comment
  • a133dba Add oldColor hex color definitions to palette.ts
  • 9a50e72 Delete packages/desktop-client/src/style/colors.ts
  • 5be3ab7 Disable colors export due to file deletion
  • b190de3 [autofix.ci] apply automated fixes

📊 Changes

4 files changed (+75 additions, -142 deletions)

View changed files

➖ packages/desktop-client/src/style/colors.ts (+0 -70)
📝 packages/desktop-client/src/style/index.ts (+0 -2)
📝 packages/desktop-client/src/style/palette.ts (+69 -70)
➕ upcoming-release-notes/6627.md (+6 -0)

📄 Description

Finding theme colors is very difficult due to palette colors referring to old colors in colors.ts

Palette.ts names colors in smaller to larger numbers in saturation order while colors.ts does this backwards making it very confusing when looking up colors. For example purple500 and p5 match, but purple50 is p11 and purple900 is p1.

This PR copies the color definitions directly into palette.ts from colors.ts The commit history shows them side-by-side before the oldColor.x is removed. (505c662)

Bad bunny!! I did this by hand!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6627 **Author:** [@Juulz](https://github.com/Juulz) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 1/14/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `colors-to-palette` --- ### 📝 Commits (10+) - [`b129147`](https://github.com/actualbudget/actual/commit/b129147b76e91683782574dc1b529ecb76c6cb8e) Update color palette with old color values - [`505c662`](https://github.com/actualbudget/actual/commit/505c66212f0199e05a32119b3f1bca780ff9e07e) Update color palette with new values - [`f57b261`](https://github.com/actualbudget/actual/commit/f57b261379ea147aba8247b534932a3ecd4555e9) Replace old color imports with old color definitions - [`35318e3`](https://github.com/actualbudget/actual/commit/35318e3b4b55efd6f9924fb7356772afa666f691) Update color exports to use consistent casing - [`b0a7b18`](https://github.com/actualbudget/actual/commit/b0a7b18a00f30c44d3340cec1ed3fcd34ea792fc) Fix export statements for color constants - [`9d3bf81`](https://github.com/actualbudget/actual/commit/9d3bf8182dc574a2a9bcc52957467ee97b43653d) Clean up palette.ts by removing old import comment - [`a133dba`](https://github.com/actualbudget/actual/commit/a133dbae4ff687efc5b47b6767e16c9af5fb94af) Add oldColor hex color definitions to palette.ts - [`9a50e72`](https://github.com/actualbudget/actual/commit/9a50e72ad7fa70185bcc55804b249ac174fb0808) Delete packages/desktop-client/src/style/colors.ts - [`5be3ab7`](https://github.com/actualbudget/actual/commit/5be3ab717cd19280052cde846584645239dfd26c) Disable colors export due to file deletion - [`b190de3`](https://github.com/actualbudget/actual/commit/b190de3ce3747276b81b30b86db1e69bec69c6aa) [autofix.ci] apply automated fixes ### 📊 Changes **4 files changed** (+75 additions, -142 deletions) <details> <summary>View changed files</summary> ➖ `packages/desktop-client/src/style/colors.ts` (+0 -70) 📝 `packages/desktop-client/src/style/index.ts` (+0 -2) 📝 `packages/desktop-client/src/style/palette.ts` (+69 -70) ➕ `upcoming-release-notes/6627.md` (+6 -0) </details> ### 📄 Description Finding theme colors is very difficult due to palette colors referring to old colors in colors.ts Palette.ts names colors in smaller to larger numbers in saturation order while colors.ts does this backwards making it very confusing when looking up colors. For example purple500 and p5 match, but purple50 is p11 and purple900 is p1. This PR copies the color definitions directly into palette.ts from colors.ts The commit history shows them side-by-side before the oldColor.x is removed. (505c662) Bad bunny!! I did this by hand! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 03:22:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55941
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?