github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6568] [CLOSED] [WIP] fix: use user's date format for month filter value display #55911

New Issue
Closed
opened 2026-05-01 03:18:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 03:18:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6568
Author: @majiayu000
Created: 1/6/2026
Status: ❌ Closed

Base: master ← Head: fix/6341-date-format-filter

📝 Commits (1)

  • a289f64 fix: use user's date format for month filter value display

📊 Changes

2 files changed (+12 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/filters/FiltersMenu.tsx (+6 -3)
➕ upcoming-release-notes/6341.md (+6 -0)

📄 Description

Summary

  • Fixes month filter using wrong date format when editing filter value
  • Uses user's date format preference instead of hardcoded MM/yyyy format

Changes

  • Gets user's date format using useDateFormat() hook in ConfigureField component
  • Uses parseDate() and formatDate() with getMonthYearFormat(dateFormat) to convert stored format to user's preferred format
  • Adds dateFormat to formattedValue dependencies

Test Plan

  • Verified yarn typecheck passes
  • Verified yarn lint:fix passes
  • Verified yarn test passes
  • Manual testing: edit month filter with different date format settings

Fixes #6341

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6568 **Author:** [@majiayu000](https://github.com/majiayu000) **Created:** 1/6/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/6341-date-format-filter` --- ### 📝 Commits (1) - [`a289f64`](https://github.com/actualbudget/actual/commit/a289f64b1a66ec03170912483537c11a4a48e70d) fix: use user's date format for month filter value display ### 📊 Changes **2 files changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/filters/FiltersMenu.tsx` (+6 -3) ➕ `upcoming-release-notes/6341.md` (+6 -0) </details> ### 📄 Description ## Summary - Fixes month filter using wrong date format when editing filter value - Uses user's date format preference instead of hardcoded MM/yyyy format ## Changes - Gets user's date format using `useDateFormat()` hook in `ConfigureField` component - Uses `parseDate()` and `formatDate()` with `getMonthYearFormat(dateFormat)` to convert stored format to user's preferred format - Adds `dateFormat` to `formattedValue` dependencies ## Test Plan - [x] Verified `yarn typecheck` passes - [x] Verified `yarn lint:fix` passes - [x] Verified `yarn test` passes - [x] Manual testing: edit month filter with different date format settings Fixes #6341 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 03:18:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?