github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 09:38:37 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #6312] [MERGED] Lint: port react and import rules from eslint to oxc #55746

New Issue
Closed
opened 2026-05-01 02:59:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 02:59:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6312
Author: @MatissJanis
Created: 12/5/2025
Status: ✅ Merged
Merged: 12/12/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/eslint-jsx-extension-enforcement

📝 Commits (10+)

  • a9a4d29 Enforce JSX file extensions for React components
  • fbcf69f Fix: Rename react-hooks/exhaustive-deps to react/exhaustive-deps
  • 992bfaa Enhance ESLint configuration and update import rules
  • 98e8789 Merge branch 'matiss/eslint-jsx-extension-enforcement' of github.com:actualbudget/actual into matiss/eslint-jsx-extension-enforcement
  • 18db3f4 Refactor ESLint configuration to enhance import order rules and add eslint-plugin-import
  • 51af8b5 Fix ESLint directive comments in API files to use correct syntax
  • 2f25db3 Fix
  • e459e53 Fix ESLint directive comments and update import/extensions rule in configuration
  • e295cfc Merge remote-tracking branch 'origin' into matiss/eslint-jsx-extension-enforcement
  • 163baa0 Refactor ESLint configuration to enforce JSX extension rules and improve code clarity

📊 Changes

20 files changed (+107 additions, -331 deletions)

View changed files

📝 .oxlintrc.json (+71 -3)
📝 eslint.config.mjs (+1 -135)
📝 package.json (+0 -2)
📝 packages/desktop-client/playwright.config.ts (+0 -1)
📝 packages/desktop-client/src/browser-preload.browser.js (+0 -1)
📝 packages/desktop-client/src/components/Modals.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/graphs/CrossoverGraph.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx (+1 -1)
📝 packages/desktop-electron/beforePackHook.ts (+1 -1)
📝 packages/desktop-electron/e2e/fixtures.ts (+1 -1)
📝 packages/desktop-electron/playwright.config.ts (+0 -1)
📝 packages/docs/docs/api/APIList.jsx (+0 -0)
📝 packages/docs/docs/api/types.jsx (+0 -0)
📝 packages/docs/src/components/HomepageFeatures/index.jsx (+0 -0)
📝 packages/docs/src/pages/index.jsx (+5 -5)
📝 packages/docs/src/theme/Layout/index.jsx (+0 -0)
📝 packages/loot-core/vite.api.config.ts (+0 -1)
📝 packages/loot-core/vite.desktop.config.ts (+0 -1)
➕ upcoming-release-notes/6312.md (+6 -0)
📝 yarn.lock (+19 -176)

📄 Description

  • Update eslint config to enforce .jsx/.tsx extensions for files containing JSX
  • Convert docs package JS files to JSX where they contain React code
  • Fix unstable nested components in CrossoverGraph and NetWorthGraph
  • Update oxlint configuration
  • Update e2e fixtures

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6312 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/5/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/eslint-jsx-extension-enforcement` --- ### 📝 Commits (10+) - [`a9a4d29`](https://github.com/actualbudget/actual/commit/a9a4d29443d14cedc898d0551ad339a226aabac9) Enforce JSX file extensions for React components - [`fbcf69f`](https://github.com/actualbudget/actual/commit/fbcf69fff33bcd3ed8dc82dfb6cee4382337a313) Fix: Rename react-hooks/exhaustive-deps to react/exhaustive-deps - [`992bfaa`](https://github.com/actualbudget/actual/commit/992bfaa359a6cdec05fea7ea17f2398195844fc4) Enhance ESLint configuration and update import rules - [`98e8789`](https://github.com/actualbudget/actual/commit/98e878946d18315185859ae83d298aed3fb846ea) Merge branch 'matiss/eslint-jsx-extension-enforcement' of github.com:actualbudget/actual into matiss/eslint-jsx-extension-enforcement - [`18db3f4`](https://github.com/actualbudget/actual/commit/18db3f4afb2d7272633f39ea0e9172b911cfbe2d) Refactor ESLint configuration to enhance import order rules and add eslint-plugin-import - [`51af8b5`](https://github.com/actualbudget/actual/commit/51af8b5636c1f0d27709aef56fad6891dc45b741) Fix ESLint directive comments in API files to use correct syntax - [`2f25db3`](https://github.com/actualbudget/actual/commit/2f25db3d0cfd5e4110d47c99de5decb35308d457) Fix - [`e459e53`](https://github.com/actualbudget/actual/commit/e459e53cd2e0f1b4c144cc912c97c147d2fff5a1) Fix ESLint directive comments and update import/extensions rule in configuration - [`e295cfc`](https://github.com/actualbudget/actual/commit/e295cfc74b041cc2ecfb45d016a54b73e2e5f1f0) Merge remote-tracking branch 'origin' into matiss/eslint-jsx-extension-enforcement - [`163baa0`](https://github.com/actualbudget/actual/commit/163baa095bb364ab155da6f066daea40f1476bb5) Refactor ESLint configuration to enforce JSX extension rules and improve code clarity ### 📊 Changes **20 files changed** (+107 additions, -331 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+71 -3) 📝 `eslint.config.mjs` (+1 -135) 📝 `package.json` (+0 -2) 📝 `packages/desktop-client/playwright.config.ts` (+0 -1) 📝 `packages/desktop-client/src/browser-preload.browser.js` (+0 -1) 📝 `packages/desktop-client/src/components/Modals.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/graphs/CrossoverGraph.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx` (+1 -1) 📝 `packages/desktop-electron/beforePackHook.ts` (+1 -1) 📝 `packages/desktop-electron/e2e/fixtures.ts` (+1 -1) 📝 `packages/desktop-electron/playwright.config.ts` (+0 -1) 📝 `packages/docs/docs/api/APIList.jsx` (+0 -0) 📝 `packages/docs/docs/api/types.jsx` (+0 -0) 📝 `packages/docs/src/components/HomepageFeatures/index.jsx` (+0 -0) 📝 `packages/docs/src/pages/index.jsx` (+5 -5) 📝 `packages/docs/src/theme/Layout/index.jsx` (+0 -0) 📝 `packages/loot-core/vite.api.config.ts` (+0 -1) 📝 `packages/loot-core/vite.desktop.config.ts` (+0 -1) ➕ `upcoming-release-notes/6312.md` (+6 -0) 📝 `yarn.lock` (+19 -176) </details> ### 📄 Description - Update eslint config to enforce .jsx/.tsx extensions for files containing JSX - Convert docs package JS files to JSX where they contain React code - Fix unstable nested components in CrossoverGraph and NetWorthGraph - Update oxlint configuration - Update e2e fixtures --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 02:59:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?