github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 00:13:45 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4757] [MERGED] 🔧 added eslint auto-fix to the lint-staged step #5570

New Issue
Closed
opened 2026-02-28 21:14:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:14:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4757
Author: @MatissJanis
Created: 4/6/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/eslint-autofix

📝 Commits (1)

  • 5721f0f 🔧 added eslint auto-fix to the lint-staged step

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 package.json (+4 -1)
➕ upcoming-release-notes/4757.md (+6 -0)

📄 Description

This might be controversial so I am looking for 2+ maintainer approvals and NO disapprovals.

After the change in https://github.com/actualbudget/actual/pull/4710 - eslint has become much quicker. So quick in fact that I would propose to run it in the lint-staged step.

What does this entail?

lint-staged runs the lint jobs on the staged (read: changed) files. It does not run it on ALL the files. Since the amount of files it runs on is small - the operation is super quick (for me the whole lint-staged operation takes ~2s).

Running both eslint & prettier as part of this step allows us to surface issues quicker. Instead of having to wait for CI jobs to finish - we can identify new issues quickly on your local machine prior to pushing.

This might not matter much for active contributors, but for newcomers or less-so-active folks - this change allows them to catch lint issues before they open a PR. Thus makes the development experience for newcomers slightly more convenient.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4757 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/6/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/eslint-autofix` --- ### 📝 Commits (1) - [`5721f0f`](https://github.com/actualbudget/actual/commit/5721f0fb139082f10b524b0cf8176e369d8ea171) :wrench: added eslint auto-fix to the lint-staged step ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+4 -1) ➕ `upcoming-release-notes/4757.md` (+6 -0) </details> ### 📄 Description This might be controversial so I am looking for 2+ maintainer approvals and NO disapprovals. After the change in https://github.com/actualbudget/actual/pull/4710 - eslint has become much quicker. So quick in fact that I would propose to run it in the `lint-staged` step. **What does this entail?** `lint-staged` runs the lint jobs on the staged (read: changed) files. It does **not** run it on ALL the files. Since the amount of files it runs on is small - the operation is super quick (for me the whole lint-staged operation takes ~2s). Running both eslint & prettier as part of this step allows us to surface issues quicker. Instead of having to wait for CI jobs to finish - we can identify new issues quickly on your local machine prior to pushing. This might not matter much for active contributors, but for newcomers or less-so-active folks - this change allows them to catch lint issues before they open a PR. Thus makes the development experience for newcomers slightly more convenient. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:14:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5570
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?