[PR #4757] [MERGED] 🔧 added eslint auto-fix to the lint-staged step #5570

New Issue

GiteaMirror · 2026-02-28T21:14:36-06:00

GiteaMirror commented

2026-02-28 21:14:36 -06:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4757
Author: @MatissJanis
Created: 4/6/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/eslint-autofix

📝 Commits (1)

5721f0f 🔧 added eslint auto-fix to the lint-staged step

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 package.json (+4 -1)
➕ upcoming-release-notes/4757.md (+6 -0)

📄 Description

This might be controversial so I am looking for 2+ maintainer approvals and NO disapprovals.

After the change in https://github.com/actualbudget/actual/pull/4710 - eslint has become much quicker. So quick in fact that I would propose to run it in the lint-staged step.

What does this entail?

lint-staged runs the lint jobs on the staged (read: changed) files. It does not run it on ALL the files. Since the amount of files it runs on is small - the operation is super quick (for me the whole lint-staged operation takes ~2s).

Running both eslint & prettier as part of this step allows us to surface issues quicker. Instead of having to wait for CI jobs to finish - we can identify new issues quickly on your local machine prior to pushing.

This might not matter much for active contributors, but for newcomers or less-so-active folks - this change allows them to catch lint issues before they open a PR. Thus makes the development experience for newcomers slightly more convenient.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4757 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/6/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/eslint-autofix` --- ### 📝 Commits (1) - [`5721f0f`](https://github.com/actualbudget/actual/commit/5721f0fb139082f10b524b0cf8176e369d8ea171) :wrench: added eslint auto-fix to the lint-staged step ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+4 -1) ➕ `upcoming-release-notes/4757.md` (+6 -0) </details> ### 📄 Description This might be controversial so I am looking for 2+ maintainer approvals and NO disapprovals. After the change in https://github.com/actualbudget/actual/pull/4710 - eslint has become much quicker. So quick in fact that I would propose to run it in the `lint-staged` step. **What does this entail?** `lint-staged` runs the lint jobs on the staged (read: changed) files. It does **not** run it on ALL the files. Since the amount of files it runs on is small - the operation is super quick (for me the whole lint-staged operation takes ~2s). Running both eslint & prettier as part of this step allows us to surface issues quicker. Instead of having to wait for CI jobs to finish - we can identify new issues quickly on your local machine prior to pushing. This might not matter much for active contributors, but for newcomers or less-so-active folks - this change allows them to catch lint issues before they open a PR. Thus makes the development experience for newcomers slightly more convenient. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-02-28 21:14:36 -06:00

GiteaMirror closed this issue