github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6100] [MERGED] Fix mobile settings page horizontal scroll #55627

New Issue
Closed
opened 2026-05-01 02:45:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 02:45:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6100
Author: @MatissJanis
Created: 11/9/2025
Status: ✅ Merged
Merged: 11/17/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/fix-mobile-settings-page-horizontal-scroll-6ee8

📝 Commits (8)

  • 740bb28 Fix: Improve layout and overflow handling in settings
  • c448d54 Refactor: Remove unnecessary overflow properties and adjust layout in Page and Settings components
  • 9935641 Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8
  • 6ab41f3 Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8
  • 5402eb3 Update VRT screenshots
  • 2797178 Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8
  • 21866a5 Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8
  • 3ad2bbf Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8

📊 Changes

5 files changed (+16 additions, -3 deletions)

View changed files

📝 packages/desktop-client/e2e/settings.mobile.test.ts-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.mobile.test.ts-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.mobile.test.ts-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/settings/index.tsx (+9 -3)
➕ upcoming-release-notes/6100.md (+7 -0)

📄 Description

Fix: Prevent horizontal scrolling on mobile settings page

This PR addresses an issue where the mobile settings page would stretch beyond the viewport, causing horizontal scrolling.

Changes include:

  • Adding overflowX: 'hidden' to the Page component's main content area.
  • Adjusting flex properties and widths in the Settings component to ensure content (specifically the FormField and Button row) correctly fits within the mobile viewport.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6100 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 11/9/2025 **Status:** ✅ Merged **Merged:** 11/17/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/fix-mobile-settings-page-horizontal-scroll-6ee8` --- ### 📝 Commits (8) - [`740bb28`](https://github.com/actualbudget/actual/commit/740bb28d98c5fb00733dbaa35b6126312eab7a48) Fix: Improve layout and overflow handling in settings - [`c448d54`](https://github.com/actualbudget/actual/commit/c448d540a37c41a6143d9e0e74c3499a53fa7439) Refactor: Remove unnecessary overflow properties and adjust layout in Page and Settings components - [`9935641`](https://github.com/actualbudget/actual/commit/99356416d087d5a4b554e8d3470a516eddd71ef5) Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8 - [`6ab41f3`](https://github.com/actualbudget/actual/commit/6ab41f372babaa69fb365091d8fe66353887e4bb) Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8 - [`5402eb3`](https://github.com/actualbudget/actual/commit/5402eb33ccce6304869685c03076f334a91ae1f8) Update VRT screenshots - [`2797178`](https://github.com/actualbudget/actual/commit/27971784279ab6d383d924e7b3e49c68f8221b8b) Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8 - [`21866a5`](https://github.com/actualbudget/actual/commit/21866a5dbd52ca5faa6d3ce6bc631ef03988d9d3) Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8 - [`3ad2bbf`](https://github.com/actualbudget/actual/commit/3ad2bbf0be3e545ac6ce8ad687c6737f7fc29ce8) Merge branch 'master' into cursor/fix-mobile-settings-page-horizontal-scroll-6ee8 ### 📊 Changes **5 files changed** (+16 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/settings.mobile.test.ts-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.mobile.test.ts-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.mobile.test.ts-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/settings/index.tsx` (+9 -3) ➕ `upcoming-release-notes/6100.md` (+7 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Fix: Prevent horizontal scrolling on mobile settings page This PR addresses an issue where the mobile settings page would stretch beyond the viewport, causing horizontal scrolling. Changes include: * Adding `overflowX: 'hidden'` to the `Page` component's main content area. * Adjusting flex properties and widths in the `Settings` component to ensure content (specifically the `FormField` and `Button` row) correctly fits within the mobile viewport. --- <a href="https://cursor.com/background-agent?bcId=bc-20e47ebd-75d2-4422-be69-5ccfaa995f7a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-20e47ebd-75d2-4422-be69-5ccfaa995f7a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 02:45:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55627
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?