github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6092] [MERGED] Default custom reports to include hidden categories and uncategorized transactions #55622

New Issue
Closed
opened 2026-05-01 02:44:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 02:44:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6092
Author: @Copilot
Created: 11/8/2025
Status: ✅ Merged
Merged: 11/9/2025
Merged by: @MatissJanis

Base: master ← Head: copilot/fix-hidden-reconciliation-calculation

📝 Commits (5)

  • 45dfa82 Initial plan
  • ac2a031 Change default values for custom reports to show hidden categories and uncategorized transactions
  • 27bb081 Merge branch 'master' into copilot/fix-hidden-reconciliation-calculation
  • 3cdfc42 Add release notes for #6092
  • ae2ca5f Update authors and category in release notes

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+2 -2)
➕ upcoming-release-notes/6092.md (+6 -0)

📄 Description

✅ Task Completed: Custom Reports Default Values

Summary

Successfully updated the default values for custom reports to include hidden categories and uncategorized transactions by default, fixing the issue where custom report calculations were ignoring reconciliation transactions.

Changes Made

Modified packages/desktop-client/src/components/reports/ReportOptions.ts:

  • ✅ Changed showHiddenCategories: false → showHiddenCategories: true (line 28)
  • ✅ Changed showUncategorized: false → showUncategorized: true (line 30)
  • ✅ Kept showEmpty: false unchanged (as per requirements)
  • ✅ Added release notes file upcoming-release-notes/6092.md

Validation Complete

  • ✅ Type checking: Passed
  • ✅ Linting: Passed
  • ✅ Unit tests: CategorySelector and Change tests passed
  • ✅ Security scan (CodeQL): No vulnerabilities found

Impact

This change ensures that custom reports now match the behavior of summary reports by default, showing:

  • Hidden categories (including reconciliation transactions)
  • Uncategorized transactions
  • Transfer transactions
  • Off-budget transactions

Users will no longer encounter the confusing scenario where the summary card shows "1000" while the custom report shows "0" due to hidden categories being excluded.

Original prompt

This section details on the original issue you should resolve

<issue_title>custom reports - ignores hidden reconciliation transactions in calculations</issue_title>
<issue_description>### Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

This is a tricky one, but it all boils down to: hidden categories for reconciliation transactions are ignored in custom reports. Thus the results custom reports produces are flawed.

Image

How can we reproduce the issue?

Example budget: 2025-10-26-Test Budget.zip

Open the report page. You will see "1000" in the summary report card (this is correct), but "0" values in custom report card (this is wrong - the two values must match).

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None</issue_description>

Comments on the Issue (you are @copilot in this section)

@MatissJanis Ok, seems to actually be a user error.

If I check "show hidden categories" and "show uncategorized" in the custom report - the numbers match again.

Which makes me think.. should we make the default value for these two options "true" in custom reports? This is a really easy mistake to make.</comment_new>
<comment_new>@youngcw
I would be ok with making show hidden and show uncategorized be true by default. The category filter will show hidden categories as an option always, so it makes sense that the report defaults to allowing them. As long as "show empty rows" is still defaulted to false.</comment_new>
<comment_new>@MatissJanis

I would be ok with making show hidden and show uncategorized be true by default. The category filter will show hidden categories as an option always, so it makes sense that the report defaults to allowing them. As long as "show empty rows" is still defaulted to false.

@cursor implement this please</comment_new>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Note

Default custom reports now include hidden categories and uncategorized transactions.

  • Reports (Desktop Client):
    • Update defaultReport in packages/desktop-client/src/components/reports/ReportOptions.ts:
      • showHiddenCategories: true (was false)
      • showUncategorized: true (was false)
  • Release Notes:
    • Add upcoming-release-notes/6092.md documenting the enhancement.

Written by Cursor Bugbot for commit ae2ca5f87f. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6092 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 11/8/2025 **Status:** ✅ Merged **Merged:** 11/9/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `copilot/fix-hidden-reconciliation-calculation` --- ### 📝 Commits (5) - [`45dfa82`](https://github.com/actualbudget/actual/commit/45dfa82571630524fde301e2ee84b8f9082e89c5) Initial plan - [`ac2a031`](https://github.com/actualbudget/actual/commit/ac2a031aab7cc68e764eba28cf6b19cec7cea0c7) Change default values for custom reports to show hidden categories and uncategorized transactions - [`27bb081`](https://github.com/actualbudget/actual/commit/27bb081c212aec4e8ecccd805289f3b95e044ca5) Merge branch 'master' into copilot/fix-hidden-reconciliation-calculation - [`3cdfc42`](https://github.com/actualbudget/actual/commit/3cdfc42065854c0ead4c02b8f7dfb94cf7816564) Add release notes for #6092 - [`ae2ca5f`](https://github.com/actualbudget/actual/commit/ae2ca5f87fc62851eed9e6e3eb7c6967b97a9959) Update authors and category in release notes ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+2 -2) ➕ `upcoming-release-notes/6092.md` (+6 -0) </details> ### 📄 Description ## ✅ Task Completed: Custom Reports Default Values ### Summary Successfully updated the default values for custom reports to include hidden categories and uncategorized transactions by default, fixing the issue where custom report calculations were ignoring reconciliation transactions. ### Changes Made Modified `packages/desktop-client/src/components/reports/ReportOptions.ts`: - ✅ Changed `showHiddenCategories: false` → `showHiddenCategories: true` (line 28) - ✅ Changed `showUncategorized: false` → `showUncategorized: true` (line 30) - ✅ Kept `showEmpty: false` unchanged (as per requirements) - ✅ Added release notes file `upcoming-release-notes/6092.md` ### Validation Complete - ✅ Type checking: Passed - ✅ Linting: Passed - ✅ Unit tests: CategorySelector and Change tests passed - ✅ Security scan (CodeQL): No vulnerabilities found ### Impact This change ensures that custom reports now match the behavior of summary reports by default, showing: - Hidden categories (including reconciliation transactions) - Uncategorized transactions - Transfer transactions - Off-budget transactions Users will no longer encounter the confusing scenario where the summary card shows "1000" while the custom report shows "0" due to hidden categories being excluded. <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>custom reports - ignores hidden reconciliation transactions in calculations</issue_title> > <issue_description>### Verified issue does not already exist? > > - [x] I have searched and found no existing issue > > ### What happened? > > This is a tricky one, but it all boils down to: hidden categories for reconciliation transactions are ignored in custom reports. Thus the results custom reports produces are flawed. > > <img width="1042" height="542" alt="Image" src="https://github.com/user-attachments/assets/dfca0498-d3b3-4c69-a509-040843245a13" /> > > ### How can we reproduce the issue? > > Example budget: [2025-10-26-Test Budget.zip](https://github.com/user-attachments/files/23153648/2025-10-26-Test.Budget.zip) > > Open the report page. You will see "1000" in the summary report card (this is correct), but "0" values in custom report card (this is wrong - the two values must match). > > ### Where are you hosting Actual? > > None > > ### What browsers are you seeing the problem on? > > _No response_ > > ### Operating System > > None</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@MatissJanis</author><body> > Ok, seems to actually be a user error. > > If I check "show hidden categories" and "show uncategorized" in the custom report - the numbers match again. > > Which makes me think.. should we make the default value for these two options "true" in custom reports? This is a really easy mistake to make.</body></comment_new> > <comment_new><author>@youngcw</author><body> > I would be ok with making show hidden and show uncategorized be true by default. The category filter will show hidden categories as an option always, so it makes sense that the report defaults to allowing them. As long as "show empty rows" is still defaulted to false.</body></comment_new> > <comment_new><author>@MatissJanis</author><body> > > I would be ok with making show hidden and show uncategorized be true by default. The category filter will show hidden categories as an option always, so it makes sense that the report defaults to allowing them. As long as "show empty rows" is still defaulted to false. > > @cursor implement this please</body></comment_new> > </comments> > </details> - Fixes actualbudget/actual#6004 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/actualbudget/actual/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Default custom reports now include hidden categories and uncategorized transactions. > > - **Reports (Desktop Client)**: > - Update `defaultReport` in `packages/desktop-client/src/components/reports/ReportOptions.ts`: > - `showHiddenCategories: true` (was `false`) > - `showUncategorized: true` (was `false`) > - **Release Notes**: > - Add `upcoming-release-notes/6092.md` documenting the enhancement. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ae2ca5f87fc62851eed9e6e3eb7c6967b97a9959. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 02:44:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55622
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?