github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4731] [CLOSED] [WIP] Fix/hidden categories group total #5560

New Issue
Closed
opened 2026-02-28 21:14:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:14:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4731
Author: @kevingatera
Created: 4/3/2025
Status: ❌ Closed

Base: master ← Head: fix/hidden-categories-group-total

📝 Commits (3)

  • 4dc3cfa fix: Exclude hidden categories and groups from budget totals
  • 40ff517 docs: Add release notes for bugfix on budget totals calculation due to hidden categories and groups
  • e297de6 chore: Clean up test and base files by removing unnecessary comments and linting

📊 Changes

5 files changed (+317 additions, -59 deletions)

View changed files

📝 packages/loot-core/src/server/budget/base.test.ts (+161 -0)
📝 packages/loot-core/src/server/budget/base.ts (+124 -45)
📝 packages/loot-core/src/server/budget/envelope.ts (+16 -10)
📝 packages/loot-core/src/server/budget/report.ts (+10 -4)
➕ upcoming-release-notes/4730.md (+6 -0)

📄 Description

Fixes #4730

Changes:

  • Added logic to exclude hidden categories from group totals by dynamically tracking their hidden status.
  • Updated group sum calculations to only include visible categories.
  • Modified budget totals to exclude hidden groups and their associated categories.
  • Added tests to verify the correct exclusion of hidden categories and groups from totals.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4731 **Author:** [@kevingatera](https://github.com/kevingatera) **Created:** 4/3/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/hidden-categories-group-total` --- ### 📝 Commits (3) - [`4dc3cfa`](https://github.com/actualbudget/actual/commit/4dc3cfa2a26e6ac4653ed63e10a5909a7cb8f737) fix: Exclude hidden categories and groups from budget totals - [`40ff517`](https://github.com/actualbudget/actual/commit/40ff51758f1c1a26150ddf7b2c3ea300fa093e4c) docs: Add release notes for bugfix on budget totals calculation due to hidden categories and groups - [`e297de6`](https://github.com/actualbudget/actual/commit/e297de6ca09a77a5806846acf8b8cbd852542fb3) chore: Clean up test and base files by removing unnecessary comments and linting ### 📊 Changes **5 files changed** (+317 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/base.test.ts` (+161 -0) 📝 `packages/loot-core/src/server/budget/base.ts` (+124 -45) 📝 `packages/loot-core/src/server/budget/envelope.ts` (+16 -10) 📝 `packages/loot-core/src/server/budget/report.ts` (+10 -4) ➕ `upcoming-release-notes/4730.md` (+6 -0) </details> ### 📄 Description Fixes #4730 ## Changes: - Added logic to exclude hidden categories from group totals by dynamically tracking their hidden status. - Updated group sum calculations to only include visible categories. - Modified budget totals to exclude hidden groups and their associated categories. - Added tests to verify the correct exclusion of hidden categories and groups from totals. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:14:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5560
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?