github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5978] [MERGED] 📱 add bank sync settings page to mobile #55552

New Issue
Closed
opened 2026-05-01 02:33:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 02:33:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5978
Author: @matt-fidd
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @matt-fidd

Base: master ← Head: mobile/bank-sync

📝 Commits (10+)

📊 Changes

83 files changed (+1306 additions, -243 deletions)

View changed files

➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts (+64 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-page-handles-empty-state-gracefully-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-page-handles-empty-state-gracefully-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-page-handles-empty-state-gracefully-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-searches-for-accounts-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-searches-for-accounts-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-searches-for-accounts-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.test.ts (+35 -0)
➕ packages/desktop-client/e2e/bank-sync.test.ts-snapshots/Bank-Sync-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.test.ts-snapshots/Bank-Sync-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/bank-sync.test.ts-snapshots/Bank-Sync-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/page-models/bank-sync-page.ts (+13 -0)
➕ packages/desktop-client/e2e/page-models/mobile-bank-sync-page.ts (+28 -0)
📝 packages/desktop-client/e2e/page-models/mobile-navigation.ts (+10 -0)
📝 packages/desktop-client/e2e/page-models/navigation.ts (+14 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-2-chromium-linux.png (+0 -0)

...and 63 more files

📄 Description

Helping with the effort for mobile parity

While I was there I generalised some of the duplicated things to tidy up and make it easier to maintain, also added some basic VRT. We don't use a server in VRT so there's no way to test for the mapping pages with linked accounts.

With only one type of account:
image

With multiple types:
image

Edit page:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5978 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `mobile/bank-sync` --- ### 📝 Commits (10+) - [`e1c8bfe`](https://github.com/actualbudget/actual/commit/e1c8bfef3dc9fa5081a11b26f4b4a5132b8cb652) add mobile bank sync page - [`c5fe5da`](https://github.com/actualbudget/actual/commit/c5fe5dad131c07c87aab22bae951b5bdf6db934c) add vrt - [`81d1341`](https://github.com/actualbudget/actual/commit/81d13415cd5997d66d3debef8d51be9bb126533e) new screenshots - [`803ae8b`](https://github.com/actualbudget/actual/commit/803ae8bb229dd52b8259194fdedf3f44762a3aa5) updated screenshots - [`17c4697`](https://github.com/actualbudget/actual/commit/17c46979f6531d8b776abee5a47bd094f570db0c) note - [`2f85b9c`](https://github.com/actualbudget/actual/commit/2f85b9c391bda742ba38c1834b4c868e7c859b53) coderabbit - [`1864b84`](https://github.com/actualbudget/actual/commit/1864b841b7fb392da01bb09ed707b038b775c94e) remove test sleeps - [`df9860f`](https://github.com/actualbudget/actual/commit/df9860fceb686e9c4d2dd8c4f07015a4f4e20866) undo the rabbit... - [`a9ee69f`](https://github.com/actualbudget/actual/commit/a9ee69f8bc5129786f13f483c6cbf3597b667f03) fix types and use Stack - [`ad43a72`](https://github.com/actualbudget/actual/commit/ad43a727fd38183e22d0b3ee6486c5c54231f1b1) fix table headings and select width ### 📊 Changes **83 files changed** (+1306 additions, -243 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts` (+64 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-page-handles-empty-state-gracefully-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-page-handles-empty-state-gracefully-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-page-handles-empty-state-gracefully-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-searches-for-accounts-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-searches-for-accounts-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.mobile.test.ts-snapshots/Mobile-Bank-Sync-searches-for-accounts-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.test.ts` (+35 -0) ➕ `packages/desktop-client/e2e/bank-sync.test.ts-snapshots/Bank-Sync-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.test.ts-snapshots/Bank-Sync-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/bank-sync.test.ts-snapshots/Bank-Sync-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/page-models/bank-sync-page.ts` (+13 -0) ➕ `packages/desktop-client/e2e/page-models/mobile-bank-sync-page.ts` (+28 -0) 📝 `packages/desktop-client/e2e/page-models/mobile-navigation.ts` (+10 -0) 📝 `packages/desktop-client/e2e/page-models/navigation.ts` (+14 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-2-chromium-linux.png` (+0 -0) _...and 63 more files_ </details> ### 📄 Description Helping with the effort for mobile parity While I was there I generalised some of the duplicated things to tidy up and make it easier to maintain, also added some basic VRT. We don't use a server in VRT so there's no way to test for the mapping pages with linked accounts. With only one type of account: <img width="475" height="651" alt="image" src="https://github.com/user-attachments/assets/add7cfd5-b0bb-4604-83f9-d31a79ac9635" /> With multiple types: <img width="432" height="510" alt="image" src="https://github.com/user-attachments/assets/d9400a24-60b5-462a-b5e6-c05c2a6e12cc" /> Edit page: <img width="441" height="485" alt="image" src="https://github.com/user-attachments/assets/6dc495b0-6484-45b8-a00d-194465272471" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 02:33:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?