github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-09 10:45:04 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #4716] [MERGED] 🐛 fix menu not closing when menu item is clicked #5552

New Issue
Closed
opened 2026-02-28 21:14:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:14:17 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4716
Author: @MatissJanis
Created: 3/31/2025
Status: ✅ Merged
Merged: 3/31/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-menu

📝 Commits (2)

  • ee779cd 🐛 fix menu not closing when menu item is clicked
  • 9739961 Small patches

📊 Changes

7 files changed (+235 additions, -182 deletions)

View changed files

📝 packages/component-library/src/Menu.tsx (+11 -8)
📝 packages/desktop-client/e2e/page-models/mobile-budget-page.ts (+25 -5)
📝 packages/desktop-client/e2e/page-models/mobile-category-menu-modal.ts (+5 -1)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+33 -27)
📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+48 -40)
📝 packages/desktop-client/src/components/reports/Overview.tsx (+107 -101)
➕ upcoming-release-notes/4716.md (+6 -0)

📄 Description

Related: https://github.com/actualbudget/actual/pull/4619/files#r2000984899

Reproduction:

  1. open an account
  2. open the account menu (three dots)
  3. select one of the options - i.e. "export"
  4. the menu should close

This is especially annoying for multi-step scenarios (i.e. "link account" opens a modal, but the menu remains open)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4716 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-menu` --- ### 📝 Commits (2) - [`ee779cd`](https://github.com/actualbudget/actual/commit/ee779cdd97df2fa3360beccb58a9788fd924361a) :bug: fix menu not closing when menu item is clicked - [`9739961`](https://github.com/actualbudget/actual/commit/97399613b9b48e2584ed8205470caa3d1498d826) Small patches ### 📊 Changes **7 files changed** (+235 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/Menu.tsx` (+11 -8) 📝 `packages/desktop-client/e2e/page-models/mobile-budget-page.ts` (+25 -5) 📝 `packages/desktop-client/e2e/page-models/mobile-category-menu-modal.ts` (+5 -1) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+33 -27) 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+48 -40) 📝 `packages/desktop-client/src/components/reports/Overview.tsx` (+107 -101) ➕ `upcoming-release-notes/4716.md` (+6 -0) </details> ### 📄 Description Related: https://github.com/actualbudget/actual/pull/4619/files#r2000984899 Reproduction: 1. open an account 2. open the account menu (three dots) 3. select one of the options - i.e. "export" 4. the menu should close This is especially annoying for multi-step scenarios (i.e. "link account" opens a modal, but the menu remains open) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:14:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5552