github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4714] [MERGED] Unlink account via bank sync page #5550

New Issue
Closed
opened 2026-02-28 21:14:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:14:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4714
Author: @Triscal
Created: 3/31/2025
Status: ✅ Merged
Merged: 4/13/2025
Merged by: @matt-fidd

Base: master ← Head: bank-sync-ui-tweak

📝 Commits (10+)

  • 7f53f27 adding unlink and account name to modal
  • 2b719d8 fixing dispatch and some style updates
  • c2a1fd3 release notes
  • d15e253 catching a few missed "bank-sync" phrases
  • a8bb638 linting
  • 2943078 Merge branch 'master' into bank-sync-ui-tweak
  • 9c3b993 Addressing comments
  • 0106945 Merge branch 'master' into bank-sync-ui-tweak
  • d08ca21 Merge branch 'master' into bank-sync-ui-tweak
  • 0eaa22c Addressing comments

📊 Changes

11 files changed (+88 additions, -25 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+1 -0)
📝 packages/desktop-client/src/components/banksync/AccountRow.tsx (+6 -1)
📝 packages/desktop-client/src/components/banksync/EditSyncAccount.tsx (+56 -13)
📝 packages/desktop-client/src/components/modals/ConfirmUnlinkAccountModal.tsx (+12 -5)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/GoCardlessInitialiseModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/PluggyAiInitialiseModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx (+2 -2)
📝 packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx (+1 -1)
📝 packages/loot-core/src/client/modals/modalsSlice.ts (+1 -0)
➕ upcoming-release-notes/4714.md (+6 -0)

📄 Description

First Pull request, so please take a close look and provide feedback. I would be very happy to learn. (Also if I'm overstepping in any of my edits please let me know, I want to respect the great work done by the team). :)

Summary of changes:

  • Added unlink button to bank sync edit modal. (Sidebar > Bank sync > Edit).
  • Updated bank sync edit modal title to contain account name.
  • Replace user facing bank-sync with bank sync to have the same name everywhere.

I built this feature because it was something I was looking for. There are currently two other ways to unlink accounts (from the account list over flow menu) and after loading the available accounts from the bank-sync providers (simplefin for example). But for me, when I was looking for the function, I thought the sidebar "bank sync" option would be able to help me do it, especially because it allows me to link accounts.

I also updated the other times we refer to bank sync in the UI. The sidebar item is called bank sync and the link account modal has bank sync for gocardless but for a couple other spots we refer to it as bank-sync. Just for consistency I updated user / ui text to all be bank sync.

We already imported the account into the modal, so I only needed to import and call the unlink function. I also updated the modal's title to make it easier to tell which account you are editing.

One potential edit / discussion point. Is that in the account menu you get a confirmation that you want to unlink, but in the "link account modal" you can do it with out confirmation. Since you are directly editing the bank sync settings, I didn't add a confirmation, but should there be one?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4714 **Author:** [@Triscal](https://github.com/Triscal) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 4/13/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `bank-sync-ui-tweak` --- ### 📝 Commits (10+) - [`7f53f27`](https://github.com/actualbudget/actual/commit/7f53f2777a24fd84bb05a13169c002da29df387b) adding unlink and account name to modal - [`2b719d8`](https://github.com/actualbudget/actual/commit/2b719d802f464967923f0f72b7fd713883c0bdca) fixing dispatch and some style updates - [`c2a1fd3`](https://github.com/actualbudget/actual/commit/c2a1fd3c032ef9886f2d92a5a64d906027d6d43d) release notes - [`d15e253`](https://github.com/actualbudget/actual/commit/d15e25313193457c09c170c5c9487ad6f8a6edfa) catching a few missed "bank-sync" phrases - [`a8bb638`](https://github.com/actualbudget/actual/commit/a8bb6383bb31354cdecffc242251ff2025c48c4c) linting - [`2943078`](https://github.com/actualbudget/actual/commit/29430784f60e191e0fb4fb9fc64071e2c71978be) Merge branch 'master' into bank-sync-ui-tweak - [`9c3b993`](https://github.com/actualbudget/actual/commit/9c3b99372af20da9cab9708d03c06e5de7674cd2) Addressing comments - [`0106945`](https://github.com/actualbudget/actual/commit/0106945a77fd13843c10a7e40c1412e44ab55089) Merge branch 'master' into bank-sync-ui-tweak - [`d08ca21`](https://github.com/actualbudget/actual/commit/d08ca218c131b11692873c6ef9d77a8b0cb447bd) Merge branch 'master' into bank-sync-ui-tweak - [`0eaa22c`](https://github.com/actualbudget/actual/commit/0eaa22c6fa2a72f25e1e70a2c9a7a990f203dfe0) Addressing comments ### 📊 Changes **11 files changed** (+88 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/banksync/AccountRow.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/banksync/EditSyncAccount.tsx` (+56 -13) 📝 `packages/desktop-client/src/components/modals/ConfirmUnlinkAccountModal.tsx` (+12 -5) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/GoCardlessInitialiseModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/PluggyAiInitialiseModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx` (+1 -1) 📝 `packages/loot-core/src/client/modals/modalsSlice.ts` (+1 -0) ➕ `upcoming-release-notes/4714.md` (+6 -0) </details> ### 📄 Description First Pull request, so please take a close look and provide feedback. I would be very happy to learn. (Also if I'm overstepping in any of my edits please let me know, I want to respect the great work done by the team). :) Summary of changes: - Added unlink button to bank sync edit modal. (Sidebar > Bank sync > Edit). - Updated bank sync edit modal title to contain account name. - Replace user facing `bank-sync` with `bank sync` to have the same name everywhere. I built this feature because it was something I was looking for. There are currently two other ways to unlink accounts (from the account list over flow menu) and after loading the available accounts from the bank-sync providers (simplefin for example). But for me, when I was looking for the function, I thought the sidebar "bank sync" option would be able to help me do it, especially because it allows me to link accounts. I also updated the other times we refer to `bank sync` in the UI. The sidebar item is called `bank sync` and the link account modal has `bank sync` for gocardless but for a couple other spots we refer to it as `bank-sync`. Just for consistency I updated user / ui text to all be `bank sync`. We already imported the account into the modal, so I only needed to import and call the unlink function. I also updated the modal's title to make it easier to tell which account you are editing. One potential edit / discussion point. Is that in the account menu you get a confirmation that you want to unlink, but in the "link account modal" you can do it with out confirmation. Since you are directly editing the bank sync settings, I didn't add a confirmation, but should there be one? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:14:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?