github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 09:38:37 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #5871] [MERGED] Add swipe to delete to mobile rules #55481

New Issue
Closed
opened 2026-05-01 02:24:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 02:24:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5871
Author: @MatissJanis
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/add-swipe-to-delete-to-mobile-rules-5367

📝 Commits (10+)

  • e212eba feat: Add delete rule functionality to mobile rules page
  • a8dc6ce Refactor: Prevent rule deletion with active schedules
  • bc5a47d Refactor: Simplify rule deletion logic and improve error message
  • 00e5756 Checkpoint before follow-up message
  • f940e5b Refactor rule deletion to use rule-delete-all endpoint
  • 217bbba Checkpoint before follow-up message
  • 99dad28 Checkpoint before follow-up message
  • 627b7ea Refactor mobile rule edit page schedule fetching
  • ade679f Fix: Add rules to list dependencies
  • 82e2290 Fix: Refresh rules list on undo

📊 Changes

12 files changed (+123 additions, -11 deletions)

View changed files

📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/mobile/rules/MobileRuleEditPage.tsx (+19 -2)
📝 packages/desktop-client/src/components/mobile/rules/MobileRulesPage.tsx (+63 -1)
📝 packages/desktop-client/src/components/mobile/rules/RulesList.tsx (+12 -2)
📝 packages/desktop-client/src/components/mobile/rules/RulesListItem.tsx (+22 -5)
📝 packages/loot-core/src/server/rules/app.ts (+1 -1)
➕ upcoming-release-notes/5871.md (+6 -0)

📄 Description

Add swipe-to-delete functionality to the mobile rules page to match the existing behavior on the mobile payees page.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5871 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/add-swipe-to-delete-to-mobile-rules-5367` --- ### 📝 Commits (10+) - [`e212eba`](https://github.com/actualbudget/actual/commit/e212eba93a27b347d8d9356cd22aa9209042503f) feat: Add delete rule functionality to mobile rules page - [`a8dc6ce`](https://github.com/actualbudget/actual/commit/a8dc6ce728e60f53f7b3ea3e1c2b5b18d9860d5d) Refactor: Prevent rule deletion with active schedules - [`bc5a47d`](https://github.com/actualbudget/actual/commit/bc5a47d8cf1abcb375efc412e037153e3f58504a) Refactor: Simplify rule deletion logic and improve error message - [`00e5756`](https://github.com/actualbudget/actual/commit/00e575681c3f637fee16e8fdda30882fcd01c0f0) Checkpoint before follow-up message - [`f940e5b`](https://github.com/actualbudget/actual/commit/f940e5b12f8e613d1ab9b5ad94ecbb22b47aa90f) Refactor rule deletion to use rule-delete-all endpoint - [`217bbba`](https://github.com/actualbudget/actual/commit/217bbbac8d19d87633f2261a716c483ec7b68309) Checkpoint before follow-up message - [`99dad28`](https://github.com/actualbudget/actual/commit/99dad284cc2470c5f69a9cf24d67c82932758781) Checkpoint before follow-up message - [`627b7ea`](https://github.com/actualbudget/actual/commit/627b7eacb31ef01f2c29ccaeba037c104d243521) Refactor mobile rule edit page schedule fetching - [`ade679f`](https://github.com/actualbudget/actual/commit/ade679f08026adf57e496e86b8916dfad006a3e9) Fix: Add rules to list dependencies - [`82e2290`](https://github.com/actualbudget/actual/commit/82e22908f1257ce1e37f46ed470fc28616a8bc10) Fix: Refresh rules list on undo ### 📊 Changes **12 files changed** (+123 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/mobile/rules/MobileRuleEditPage.tsx` (+19 -2) 📝 `packages/desktop-client/src/components/mobile/rules/MobileRulesPage.tsx` (+63 -1) 📝 `packages/desktop-client/src/components/mobile/rules/RulesList.tsx` (+12 -2) 📝 `packages/desktop-client/src/components/mobile/rules/RulesListItem.tsx` (+22 -5) 📝 `packages/loot-core/src/server/rules/app.ts` (+1 -1) ➕ `upcoming-release-notes/5871.md` (+6 -0) </details> ### 📄 Description Add swipe-to-delete functionality to the mobile rules page to match the existing behavior on the mobile payees page. --- <a href="https://cursor.com/background-agent?bcId=bc-18d39afb-a114-427e-b17e-3be02e0e5987"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-18d39afb-a114-427e-b17e-3be02e0e5987"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 02:24:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?