github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4710] [MERGED] 🔧 improving typechecker and lint local performance #5548

New Issue
Closed
opened 2026-02-28 21:14:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:14:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4710
Author: @MatissJanis
Created: 3/30/2025
Status: ✅ Merged
Merged: 4/6/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/lint-performance

📝 Commits (2)

  • b7ffa1b 🔧 improving typechecker and lint local performance
  • b6be9aa Merge branch 'master' into matiss/lint-performance

📊 Changes

20 files changed (+99 additions, -101 deletions)

View changed files

📝 .devcontainer/devcontainer.json (+7 -10)
📝 .gitignore (+3 -0)
📝 .prettierignore (+29 -0)
📝 README.md (+1 -1)
📝 docker-compose.yml (+0 -1)
📝 eslint.config.mjs (+9 -3)
📝 package.json (+4 -5)
📝 packages/desktop-client/README.md (+3 -0)
📝 packages/desktop-client/bin/remove-untranslated-languages (+4 -2)
📝 packages/desktop-client/globals.d.ts (+0 -1)
📝 packages/desktop-client/src/fonts.scss (+1 -1)
📝 packages/desktop-electron/.babelrc (+1 -3)
📝 packages/desktop-electron/loading.html (+2 -4)
📝 packages/loot-core/src/mocks/files/default-budget-template/metadata.json (+6 -1)
📝 packages/loot-core/src/types/server-handlers.d.ts (+2 -3)
📝 packages/loot-core/tsconfig.api.json (+16 -11)
📝 packages/sync-server/src/app-gocardless/README.md (+3 -0)
📝 tsconfig.json (+1 -0)
➕ upcoming-release-notes/4710.md (+6 -0)
📝 yarn.lock (+1 -55)

📄 Description

Applying some small quirks we can do to make lint & typechecker faster.

https://typescript-eslint.io/troubleshooting/typed-linting/performance/

yarn typecheck

before:
38.29s user 2.34s system 169% cpu 24.005 total

with --incremental:
38.89s user 2.43s system 164% cpu 25.111 tota

with --incremental 2nd run:
17.20s user 1.74s system 155% cpu 12.193 total

yarn lint

before:
110.63s user 7.36s system 205% cpu 57.361 total

after:
97.88s user 6.99s system 186% cpu 56.181 total

(not a massive difference here yet.. however, I have some more changes I'd like to do that should boost this quite a bit.. but those changes might be controversial, so I'll split them in a separate PR)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4710 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/30/2025 **Status:** ✅ Merged **Merged:** 4/6/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/lint-performance` --- ### 📝 Commits (2) - [`b7ffa1b`](https://github.com/actualbudget/actual/commit/b7ffa1b356b35dabc8c39358ece13e4c1c551a87) :wrench: improving typechecker and lint local performance - [`b6be9aa`](https://github.com/actualbudget/actual/commit/b6be9aa70bd3f2dc780f3651e07f72f5a4351a96) Merge branch 'master' into matiss/lint-performance ### 📊 Changes **20 files changed** (+99 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/devcontainer.json` (+7 -10) 📝 `.gitignore` (+3 -0) 📝 `.prettierignore` (+29 -0) 📝 `README.md` (+1 -1) 📝 `docker-compose.yml` (+0 -1) 📝 `eslint.config.mjs` (+9 -3) 📝 `package.json` (+4 -5) 📝 `packages/desktop-client/README.md` (+3 -0) 📝 `packages/desktop-client/bin/remove-untranslated-languages` (+4 -2) 📝 `packages/desktop-client/globals.d.ts` (+0 -1) 📝 `packages/desktop-client/src/fonts.scss` (+1 -1) 📝 `packages/desktop-electron/.babelrc` (+1 -3) 📝 `packages/desktop-electron/loading.html` (+2 -4) 📝 `packages/loot-core/src/mocks/files/default-budget-template/metadata.json` (+6 -1) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+2 -3) 📝 `packages/loot-core/tsconfig.api.json` (+16 -11) 📝 `packages/sync-server/src/app-gocardless/README.md` (+3 -0) 📝 `tsconfig.json` (+1 -0) ➕ `upcoming-release-notes/4710.md` (+6 -0) 📝 `yarn.lock` (+1 -55) </details> ### 📄 Description Applying some small quirks we can do to make lint & typechecker faster. https://typescript-eslint.io/troubleshooting/typed-linting/performance/ --- ## yarn typecheck ``` before: 38.29s user 2.34s system 169% cpu 24.005 total with --incremental: 38.89s user 2.43s system 164% cpu 25.111 tota with --incremental 2nd run: 17.20s user 1.74s system 155% cpu 12.193 total ``` ### yarn lint ``` before: 110.63s user 7.36s system 205% cpu 57.361 total after: 97.88s user 6.99s system 186% cpu 56.181 total ``` (not a massive difference here yet.. however, I have some more changes I'd like to do that should boost this quite a bit.. but those changes might be controversial, so I'll split them in a separate PR) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:14:13 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5548
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?