github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 20:38:54 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #5634] [MERGED] [fix] Adjust modal styles and text wrapping in TransactionError #55346

New Issue
Closed
opened 2026-05-01 02:09:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 02:09:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5634
Author: @milanalexandre
Created: 8/26/2025
Status: ✅ Merged
Merged: 8/27/2025
Merged by: @matt-fidd

Base: master ← Head: fix/change_style_split_modal

📝 Commits (2)

📊 Changes

2 files changed (+13 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+7 -2)
➕ upcoming-release-notes/5634.md (+6 -0)

📄 Description

Context

The transactionError modal was displaying its content across two lines due to insufficient width constraints.

Summary of Changes

  • Updated the style property of the modal to set maxWidth and minWidth.
  • Added whiteSpace: 'nowrap' to the Text component inside the TransactionError to ensure the text remains on a single line.

How to test

  • Create a split transaction.
  • Modify the transaction value so that the amount is less than the total value.
  • Confirm that the modal's width adjusts within the defined constraints.
from to
Capture d’écran 2025-08-24 à 11 27 45 Capture d’écran 2025-08-24 à 11 29 00

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5634 **Author:** [@milanalexandre](https://github.com/milanalexandre) **Created:** 8/26/2025 **Status:** ✅ Merged **Merged:** 8/27/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix/change_style_split_modal` --- ### 📝 Commits (2) - [`1b5dc3e`](https://github.com/actualbudget/actual/commit/1b5dc3ebaace135d4b272628bd94de4d4d797956) adaptive size of the modal - [`f4275f0`](https://github.com/actualbudget/actual/commit/f4275f080e7850133b4f4be01e84c61a848914cf) add relese note ### 📊 Changes **2 files changed** (+13 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+7 -2) ➕ `upcoming-release-notes/5634.md` (+6 -0) </details> ### 📄 Description ## Context The transactionError modal was displaying its content across two lines due to insufficient width constraints. ## Summary of Changes - Updated the `style` property of the modal to set `maxWidth` and `minWidth`. - Added `whiteSpace: 'nowrap'` to the `Text` component inside the `TransactionError` to ensure the text remains on a single line. ## How to test - Create a split transaction. - Modify the transaction value so that the amount is less than the total value. - Confirm that the modal's width adjusts within the defined constraints. |from|to| |--|--| | <img width="684" height="111" alt="Capture d’écran 2025-08-24 à 11 27 45" src="https://github.com/user-attachments/assets/cd2de29e-f5da-4727-a83f-785641b28305" /> | <img width="684" height="327" alt="Capture d’écran 2025-08-24 à 11 29 00" src="https://github.com/user-attachments/assets/f3396a79-9fa5-41c6-87a0-1b6928adc1f5" /> | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 02:09:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?