github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4668] [MERGED] :electron: Fix electron loot core resolutions #5524

New Issue
Closed
opened 2026-02-28 21:13:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:13:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4668
Author: @MikesGlitch
Created: 3/20/2025
Status: ✅ Merged
Merged: 3/21/2025
Merged by: @MikesGlitch

Base: master ← Head: fix/electron-resolutions

📝 Commits (8)

📊 Changes

3 files changed (+13 additions, -0 deletions)

View changed files

📝 packages/desktop-electron/package.json (+3 -0)
📝 tsconfig.json (+4 -0)
➕ upcoming-release-notes/4668.md (+6 -0)

📄 Description

This is a temporary fix for an Electron issue that was brought in by: https://github.com/actualbudget/actual/pull/4592/files

Basically the app wont start because it's resolving the wrong files in loot-core. I think the API will be broken too, I haven't tested it though.

I think there's more than one issue with that exports list so I couldn't fix it without spending a lot of time. This will make edge builds work again until we sort it out.

Example of the issue:

    "./client/platform": {
      "node": "./src/client/platform.electron.ts",
      "default": "./src/client/platform.web.ts"
    },

Node doesn't get resolved by electron.

Another issue:

    "./platform/server/fetch": "./src/platform/server/fetch/index.web.ts",

Server fetch is always resolving the web. If we're in Electron it should resolve the electron extension.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4668 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 3/20/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `fix/electron-resolutions` --- ### 📝 Commits (8) - [`5f3b7a3`](https://github.com/actualbudget/actual/commit/5f3b7a3b1199ca9830718b066c6c1ebc79023d05) fix electron resolutions - [`c6141b9`](https://github.com/actualbudget/actual/commit/c6141b92d53fc7a1d26c07160d6f30126723ab1a) temp fix - [`90f6a2a`](https://github.com/actualbudget/actual/commit/90f6a2a79bbd5cd7d3d14ef35414172a6ce88a4c) dont include build-electron in the web bundle assuming its built - [`f1a693c`](https://github.com/actualbudget/actual/commit/f1a693c19bd210b3ee2cd5b86b8e4e7eb027b3cc) lowering size of build - [`3fba648`](https://github.com/actualbudget/actual/commit/3fba6481313e4fbc2d2c7827c2371820c26e436e) removing exports - [`8fc1705`](https://github.com/actualbudget/actual/commit/8fc170531f056040c0a58ea2b552047b42f9f545) release notes - [`8a88bf4`](https://github.com/actualbudget/actual/commit/8a88bf476a2e0624088b123555899cd0daccbeb4) adding bits back - [`20aea13`](https://github.com/actualbudget/actual/commit/20aea13dcaa273a1d59a65d6143470d614f5a394) remove bad config ### 📊 Changes **3 files changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-electron/package.json` (+3 -0) 📝 `tsconfig.json` (+4 -0) ➕ `upcoming-release-notes/4668.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> This is a temporary fix for an Electron issue that was brought in by: https://github.com/actualbudget/actual/pull/4592/files Basically the app wont start because it's resolving the wrong files in loot-core. I think the API will be broken too, I haven't tested it though. I think there's more than one issue with that exports list so I couldn't fix it without spending a lot of time. This will make edge builds work again until we sort it out. Example of the issue: ``` "./client/platform": { "node": "./src/client/platform.electron.ts", "default": "./src/client/platform.web.ts" }, ``` Node doesn't get resolved by electron. Another issue: ``` "./platform/server/fetch": "./src/platform/server/fetch/index.web.ts", ``` Server fetch is always resolving the web. If we're in Electron it should resolve the electron extension. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:13:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?