github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5279] [MERGED] Run rules on transactions created by a transfer. #55159

New Issue
Closed
opened 2026-05-01 01:47:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 01:47:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5279
Author: @Rapha149
Created: 7/3/2025
Status: ✅ Merged
Merged: 7/7/2025
Merged by: @youngcw

Base: master ← Head: transfer-rules

📝 Commits (3)

  • 3ad5a00 Run rules on transactions created by a transfer.
  • 5c6620b [autofix.ci] apply automated fixes
  • aa5af0c [autofix.ci] apply automated fixes (attempt 2/3)

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/transactions/transfer.ts (+9 -1)
➕ upcoming-release-notes/5279.md (+6 -0)

📄 Description

Implements #5154: running rules on transactions created by a transfer, until now when you manually or automatically create a transfer transaction the rules are only applied to the original transaction, not the transaction created by the transfer on the other account.
I implemented this, but only for the fields notes and cleared because if other fields were changed then the transactions from the transfer would not have the same/complementary information anymore (e.g. changing the payee/amount/...).
What I didn't add is tests in the transfer.test.ts file because the rules are already tested in transaction-rules.test.ts but if that's needed there as well, I can add it.
I hope I did everything right in the code / in the pr because this is my first time with Typescript and with contributing to this project.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5279 **Author:** [@Rapha149](https://github.com/Rapha149) **Created:** 7/3/2025 **Status:** ✅ Merged **Merged:** 7/7/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `transfer-rules` --- ### 📝 Commits (3) - [`3ad5a00`](https://github.com/actualbudget/actual/commit/3ad5a00467e5853b2dcf1b2048a934b148ef47bb) Run rules on transactions created by a transfer. - [`5c6620b`](https://github.com/actualbudget/actual/commit/5c6620b21eba0c676681db4be1d118de0ed46fd0) [autofix.ci] apply automated fixes - [`aa5af0c`](https://github.com/actualbudget/actual/commit/aa5af0ccfdee858e90aaf88cbb49e50ef113aa05) [autofix.ci] apply automated fixes (attempt 2/3) ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/transactions/transfer.ts` (+9 -1) ➕ `upcoming-release-notes/5279.md` (+6 -0) </details> ### 📄 Description Implements #5154: running rules on transactions created by a transfer, until now when you manually or automatically create a transfer transaction the rules are only applied to the original transaction, not the transaction created by the transfer on the other account. I implemented this, but only for the fields `notes` and `cleared` because if other fields were changed then the transactions from the transfer would not have the same/complementary information anymore (e.g. changing the payee/amount/...). What I didn't add is tests in the `transfer.test.ts` file because the rules are already tested in `transaction-rules.test.ts` but if that's needed there as well, I can add it. I hope I did everything right in the code / in the pr because this is my first time with Typescript and with contributing to this project. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 01:47:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#55159
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?