mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 14:43:36 -05:00
[Maintenance] TypeScript migration #549
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#549
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MatissJanis on GitHub (Aug 7, 2023).
We are currently at around 50% TypeScript. There is still lots of work to be done to get to 100%.
Feel free to help out by converting a file here and there. Also hardening the existing TS files is welcome (i.e. converting
unknownandanyto more strict types).Please do not send massive migration PRs. Try to keep it small and isolated.
Remaining files:
@doggan commented on GitHub (Sep 6, 2023):
While looking at this, I found a cool package (https://github.com/codemix/deprank) that uses PageRank algorithm to find the 'most important' files in the project and list out dependencies. This can give a good idea of which files are good to tackle first for JS -> TS conversion (and which files may be more challenging).
Here's the command I ran for
desktop-client:npx deprank --ext=".js,.jsx" --deps-first ./packages/desktop-client/src | grep -v "/icons/"@kymckay commented on GitHub (Nov 20, 2023):
One thought I had on this (may have been discussed previously). For truly strict typing, the function components themselves should be typed as
FunctionComponent. Is there any objection to doing so? The only reason I can think would be stylistic preference.Edit: Decided to look into this and seems latest consensus is that it's not needed. Will stick with the
functionstyle already in use.@joel-jeremy commented on GitHub (Apr 9, 2024):
@MatissJanis I think we should pin this so that community is aware that the project is still accepting typescript PRs.
@MatissJanis commented on GitHub (Apr 13, 2024):
That makes sense @joel-jeremy , but we can only pin 3x issues. Perhaps lets wait for one of the experimental features to be released and then pin this one?
@MatissJanis commented on GitHub (Jul 8, 2024):
The majority of the codebase has been migrated to TypeScript.
Pinning this issue to give it more visibility. If folks want to contribute - working on the TS migration is an easy way to learn more about the Actual codebase while also benefiting the community.
@MatissJanis commented on GitHub (Aug 24, 2024):
Updated the root description with a list of files remaining. Not much to go to be 100% TS compliant!
@cindywu commented on GitHub (Nov 21, 2024):
I'm going to try to chip away at this over the next few weeks.
@baruchiro commented on GitHub (Apr 1, 2025):
Hi, I want to add types to the npm package, but I'm unsure what the conventions are and where to put types (not "entities"). Can someone guide me?
Here is my first proposal:
https://github.com/actualbudget/actual/pull/4720
@ahmed-n-abdeltwab commented on GitHub (May 5, 2025):
Hey, I’d like to start working on this.
@HenriqueOmena commented on GitHub (May 10, 2025):
I can see some Files are not been checked could you please update the checks for each files was done already ?
for example this one were done 4 months ago
https://github.com/actualbudget/actual/pull/4047
@ahmed-n-abdeltwab commented on GitHub (May 10, 2025):
I will look into it and see what I can do.
You mean by that this PR #4047 is outdated and needs to be updated, is that correct?
@jfdoming commented on GitHub (May 10, 2025):
Updated the list. For future reference, you can get the most up-to-date list of files using:
git ls-files "*.js"