github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 08:52:49 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4619] [CLOSED] [Mobile] Fix autocomplete autofocus #5488

New Issue
Closed
opened 2026-02-28 21:13:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:13:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4619
Author: @joel-jeremy
Created: 3/13/2025
Status: ❌ Closed

Base: master ← Head: fix-mobile-autocomplete-autofocus

📝 Commits (9)

  • d8f4cc7 [Mobile] Fix autocomplete autofocus
  • 536b2e4 Release notes
  • 7f57ce5 openOnFocus
  • 5e16b73 Autofocus
  • 59d69fd Revert some changes
  • a2b6f5b Update VRT
  • 629882d Remove autocomplete autoFocus prop
  • c247fca Merge branch 'master' into fix-mobile-autocomplete-autofocus
  • 8053053 Merge branch 'master' into fix-mobile-autocomplete-autofocus

📊 Changes

17 files changed (+6 additions, -17 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+0 -2)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+0 -5)
📝 packages/desktop-client/src/components/modals/AccountAutocompleteModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/CategoryAutocompleteModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/CloseAccountModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/ConfirmCategoryDeleteModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/PayeeAutocompleteModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx (+0 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+0 -3)
➕ upcoming-release-notes/4619.md (+6 -0)

📄 Description

Fix error on autocomplete modals:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4619 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 3/13/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-mobile-autocomplete-autofocus` --- ### 📝 Commits (9) - [`d8f4cc7`](https://github.com/actualbudget/actual/commit/d8f4cc7f06ba84928b83caf0f31c5538115f3206) [Mobile] Fix autocomplete autofocus - [`536b2e4`](https://github.com/actualbudget/actual/commit/536b2e42b748cb22d7d943416d219d0e9f477a6d) Release notes - [`7f57ce5`](https://github.com/actualbudget/actual/commit/7f57ce565e9b3f00466c74a410dcfad66102a1c2) openOnFocus - [`5e16b73`](https://github.com/actualbudget/actual/commit/5e16b739e0d85e48c4a27179e1a1f128c813d77f) Autofocus - [`59d69fd`](https://github.com/actualbudget/actual/commit/59d69fde905f197ed0669b0692d68ede357b0aef) Revert some changes - [`a2b6f5b`](https://github.com/actualbudget/actual/commit/a2b6f5b8615e5d0cda37bbf7daac4a7ad55e4c90) Update VRT - [`629882d`](https://github.com/actualbudget/actual/commit/629882d19819f908a8e176dcf3b7a7e03fe2ac3a) Remove autocomplete autoFocus prop - [`c247fca`](https://github.com/actualbudget/actual/commit/c247fcacffd83214d6953979894f63af5769c9b3) Merge branch 'master' into fix-mobile-autocomplete-autofocus - [`8053053`](https://github.com/actualbudget/actual/commit/80530538077732ed36ffe1cec809474bc57bed48) Merge branch 'master' into fix-mobile-autocomplete-autofocus ### 📊 Changes **17 files changed** (+6 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+0 -2) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+0 -5) 📝 `packages/desktop-client/src/components/modals/AccountAutocompleteModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/CategoryAutocompleteModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/CloseAccountModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/ConfirmCategoryDeleteModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/PayeeAutocompleteModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx` (+0 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+0 -3) ➕ `upcoming-release-notes/4619.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Fix error on autocomplete modals: ![image](https://github.com/user-attachments/assets/59ff7ad8-c5d2-456b-a630-978bd112e4bc) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:13:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?