github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4555] [MERGED] ♻️ removing usages of MenuButton #5449

New Issue
Closed
opened 2026-02-28 21:12:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:12:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4555
Author: @MatissJanis
Created: 3/6/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/remove-menu-button

📝 Commits (1)

  • 63eda35 ♻️ removing usages of MenuButton

📊 Changes

5 files changed (+194 additions, -219 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Header.tsx (+50 -59)
➖ packages/desktop-client/src/components/common/MenuButton.tsx (+0 -23)
📝 packages/desktop-client/src/components/reports/Overview.tsx (+122 -133)
📝 packages/desktop-client/src/components/reports/ReportCard.tsx (+16 -4)
➕ upcoming-release-notes/4555.md (+6 -0)

📄 Description

MenuButton common component is not a great abstraction. It's basically a wrapper around Button that uses an explicit icon.

Removing the few usages of this component in favour of directly using Button + the icon.

This also allows to translate the aria-label of this component (which is not something we could do if the component was moved to the component library package).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4555 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/6/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/remove-menu-button` --- ### 📝 Commits (1) - [`63eda35`](https://github.com/actualbudget/actual/commit/63eda3515efe07f2c7b986d99eec0acb16755295) :recycle: removing usages of MenuButton ### 📊 Changes **5 files changed** (+194 additions, -219 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+50 -59) ➖ `packages/desktop-client/src/components/common/MenuButton.tsx` (+0 -23) 📝 `packages/desktop-client/src/components/reports/Overview.tsx` (+122 -133) 📝 `packages/desktop-client/src/components/reports/ReportCard.tsx` (+16 -4) ➕ `upcoming-release-notes/4555.md` (+6 -0) </details> ### 📄 Description `MenuButton` common component is not a great abstraction. It's basically a wrapper around `Button` that uses an explicit icon. Removing the few usages of this component in favour of directly using `Button` + the icon. This also allows to translate the aria-label of this component (which is not something we could do if the component was moved to the component library package). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:12:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5449
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?