github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #3793] [MERGED] Check gocardless bank data type before setting state #54365

New Issue
Closed
opened 2026-04-30 23:58:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 23:58:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3793
Author: @thraizz
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (1)

  • 8dab978 fix: check gocardless bank data before setting state

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx (+1 -1)
➕ upcoming-release-notes/3793.md (+6 -0)

📄 Description

Hey, thanks for the great work on actual. I had a smaller issue and could fix it myself, so I'm raising this PR.
I had the issue that I deleted my token in GoCardless and then GoCardless would give back an error object instead of an array in the useAvailableBanks hook. This would cause errors down the line, for example when giving this as sugggestions to the Autocomplete component.
Checking if the response is an array prevents the app from crashing and also displays the correct "Failed loading available banks: GoCardless access credentials might be misconfigured. Please set them up again." error message.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3793 **Author:** [@thraizz](https://github.com/thraizz) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`8dab978`](https://github.com/actualbudget/actual/commit/8dab978b819120adb53f98ae1bce2c5e15d26020) fix: check gocardless bank data before setting state ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx` (+1 -1) ➕ `upcoming-release-notes/3793.md` (+6 -0) </details> ### 📄 Description Hey, thanks for the great work on actual. I had a smaller issue and could fix it myself, so I'm raising this PR. I had the issue that I deleted my token in GoCardless and then GoCardless would give back an error object instead of an array in the `useAvailableBanks` hook. This would cause errors down the line, for example when giving this as `sugggestions` to the `Autocomplete` component. Checking if the response is an array prevents the app from crashing and also displays the correct "Failed loading available banks: GoCardless access credentials might be misconfigured. Please set them up again." error message. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 23:58:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#54365
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?