github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 20:40:08 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4476] [MERGED] [Mobile] Drag and drop on accounts to re-order #5407

New Issue
Closed
opened 2026-02-28 21:11:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4476
Author: @joel-jeremy
Created: 2/27/2025
Status: ✅ Merged
Merged: 3/7/2025
Merged by: @joel-jeremy

Base: master ← Head: mobile-accounts-dnd

📝 Commits (10+)

📊 Changes

7 files changed (+243 additions, -128 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/accounts/Accounts.tsx (+230 -122)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx (+3 -2)
📝 packages/loot-core/src/client/accounts/accountsSlice.ts (+1 -1)
📝 packages/loot-core/src/server/accounts/app.ts (+1 -1)
📝 packages/loot-core/src/server/db/index.ts (+1 -1)
📝 packages/loot-core/src/server/db/sort.ts (+1 -1)
➕ upcoming-release-notes/4476.md (+6 -0)

📄 Description

Drag and drop doesn't seem to work with the Chrome mobile simulator but it works when the demo link is opened in an actual mobile phone.

At the moment, this only supports Chromium based browsers due to some quirks on how drag and drop works on other browsers. The plan is to push through with this limited support for now and check future releases of react aria and/or browsers once they add proper support/functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4476 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 2/27/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `mobile-accounts-dnd` --- ### 📝 Commits (10+) - [`fdbe72c`](https://github.com/actualbudget/actual/commit/fdbe72ceae880e20433bdd38619ff505992e04e3) Drag and drop on mobile accounts page - [`62c7076`](https://github.com/actualbudget/actual/commit/62c707622049ad5b291fba04f2c0ffc96aab8b90) Fix width - [`5bbd719`](https://github.com/actualbudget/actual/commit/5bbd71968e8d722e3d097d02cb60833d98603def) Move account in DB - [`cf10f59`](https://github.com/actualbudget/actual/commit/cf10f5964823e0be0cfc1f88163b04732078f9af) Update onReorder - [`5788284`](https://github.com/actualbudget/actual/commit/5788284c98ac70bc346f07eb2279d85bf3c22258) Use ID as key - [`6fbcaec`](https://github.com/actualbudget/actual/commit/6fbcaec8e47df4cc993e1478d8f91fd239035b50) Fix typecheck error - [`63dbaef`](https://github.com/actualbudget/actual/commit/63dbaef1b537b32f142811c4299a3d24d4ade1f2) Rename prop - [`2c53850`](https://github.com/actualbudget/actual/commit/2c538500151db90610ea21c3231a137aadc5e130) Alert for debugging - [`04fc049`](https://github.com/actualbudget/actual/commit/04fc0499529eb474b67b048a20c5e412a3d5de93) Fix retrieval of keys - [`08418fa`](https://github.com/actualbudget/actual/commit/08418fab2244d0e4aa895ee0a4be7229ef82e586) Update after logic ### 📊 Changes **7 files changed** (+243 additions, -128 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/accounts/Accounts.tsx` (+230 -122) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx` (+3 -2) 📝 `packages/loot-core/src/client/accounts/accountsSlice.ts` (+1 -1) 📝 `packages/loot-core/src/server/accounts/app.ts` (+1 -1) 📝 `packages/loot-core/src/server/db/index.ts` (+1 -1) 📝 `packages/loot-core/src/server/db/sort.ts` (+1 -1) ➕ `upcoming-release-notes/4476.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Drag and drop doesn't seem to work with the Chrome mobile simulator but it works when the demo link is opened in an actual mobile phone. At the moment, this only supports Chromium based browsers due to some quirks on how drag and drop works on other browsers. The plan is to push through with this limited support for now and check future releases of react aria and/or browsers once they add proper support/functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5407
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?