github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: mobile - footer color #539

New Issue
Closed
opened 2026-02-28 19:08:14 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-02-28 19:08:14 -06:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Aug 2, 2023).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

The footer color has changed in the last release. Must have been an accident. We should revert it back to the previous colors.

Current:
Screenshot 2023-08-02 at 21 41 06

Previous:
Screenshot 2023-08-02 at 21 40 51

What error did you receive?

No response

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Aug 2, 2023). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? The footer color has changed in the last release. Must have been an accident. We should revert it back to the previous colors. Current: <img width="382" alt="Screenshot 2023-08-02 at 21 41 06" src="https://github.com/actualbudget/actual/assets/886567/9825f1af-1ec2-4f0c-b27a-14afb70606f0"> Previous: <img width="366" alt="Screenshot 2023-08-02 at 21 40 51" src="https://github.com/actualbudget/actual/assets/886567/5794adc7-2cfc-414d-8774-b6a64c790ba8"> ### What error did you receive? _No response_ ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the regressiongood first issueresponsivebug labels 2026-02-28 19:08:14 -06:00
GiteaMirror commented 2026-02-28 19:08:15 -06:00
Author
Owner
Copy Link

@aleetsaiya commented on GitHub (Aug 3, 2023):

Reference PR: #1391

Here're the color that footer used:
e7f8288244/packages/desktop-client/src/components/FinancesApp.tsx (L185)
e7f8288244/packages/desktop-client/src/components/FinancesApp.tsx (L166-L168)

Reference to the light theme colors
e7f8288244/packages/desktop-client/src/style/themes/light.ts (L37-L44)

I can help to change the color but I didn't engage in the dark theme developing. Should I hardcode the light theme colors to the order version color?

@aleetsaiya commented on GitHub (Aug 3, 2023): Reference PR: #1391 Here're the color that footer used: https://github.com/actualbudget/actual/blob/e7f828824485f8ac56f3d3e485dee6824a23a266/packages/desktop-client/src/components/FinancesApp.tsx#L185 https://github.com/actualbudget/actual/blob/e7f828824485f8ac56f3d3e485dee6824a23a266/packages/desktop-client/src/components/FinancesApp.tsx#L166-L168 Reference to the light theme colors https://github.com/actualbudget/actual/blob/e7f828824485f8ac56f3d3e485dee6824a23a266/packages/desktop-client/src/style/themes/light.ts#L37-L44 I can help to change the color but I didn't engage in the dark theme developing. Should I hardcode the light theme colors to the order version color?
GiteaMirror commented 2026-02-28 19:08:16 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Aug 3, 2023):

Maybe we can create a new constant variable for these color?

mobileNavBackground etc.

@MatissJanis commented on GitHub (Aug 3, 2023): Maybe we can create a new constant variable for these color? `mobileNavBackground` etc.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue regression responsive
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?