mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-10 04:02:38 -05:00
[Bug] [Budget templates]: "up to" template not handling category negative Spent #538
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#538
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dugite-code on GitHub (Aug 2, 2023).
Verified issue does not already exist?
What happened?
-383.44and a balance-44.80with over1300to budget#template 300 up to 350Expected result: to have
300applied to category budgetActual result:
11.36applied to category budgetIt looks like the spent amount is taken as a positive and the balance subtracted to determine the amount to budget:
Additional details
What error did you receive?
No response
Where are you hosting Actual?
Docker
What browsers are you seeing the problem on?
Firefox
Operating System
Linux
@shall0pass commented on GitHub (Aug 2, 2023):
I'm unable to reproduce this issue. I created a fresh budget to test, added one account, added one payment transaction to the food category in the amount of 315, place a -40 in the budgeted field, and applied #template 300 up to 350. The result was 300 budgeted with a balance of -15. (-315+300).
Did I miss something?
@kyrias commented on GitHub (Aug 2, 2023):
#template 300 up to 350.Result: Food category has budgeted 11.36, spent -383.44, and balance -33.44.
@Kidglove57 commented on GitHub (Aug 2, 2023):
I can also reproduce this. I tried using the “overwrite” feature but it made no difference
@shall0pass commented on GitHub (Aug 2, 2023):
Ah ok. What's happening is that the template doesn't take into consideration any current month spending. If you didn't have the spent value, your category balance for the month would be 350 and you would have hit the limit for the category. Lines 717 and 718 of the goal templates file are where the calculation is being modified from 300 to 11 to max the category at 350 if someone wants to take a look.
Fix: line 717
else if(to_budget +balance >limit) {
to_budget = limit - balance;
}
I'm traveling today so I can't push this until tonight, maybe tomorrow. If someone else wants to check this and push 🎉
@youngcw commented on GitHub (Aug 2, 2023):
This seems to be acting as expected. Select few templates consider the spent value in their calculations. Any overspending should be taken care by clicking the the negative balance and then "cover overspending" to pull in funds from a different category. Other options to clean up the overspending are to get rid of the limit, increase the limit, or use the end of month cleanup.
@shall0pass commented on GitHub (Aug 2, 2023):
Here is the definition of this template from the documentation.
<html>The way I read this, is that it will budget 50 into the category until the category has a maximum amount of 300. Reading it that way, I agree with @youngcw that it is behaving as described. The difference in this bug report is that spending has already occurred when the template was run.
If we change your example slightly, and remove the spending. The template still would have budgeted 11.36 because your category would have been capped at 350 which was specified.
If you have read the description differently, I'm interested in hearing how you think it reads. Maybe we can make it more clear. I think you would be more satisfied with just
#template 300for this application, since you always want to budget 300 into the category. This will not place an upper limit on how much to save.@dugite-code commented on GitHub (Aug 2, 2023):
Right I see where it's going wrong here. But is it really expected? From my read it's up to 350 from when the template is applied and I would expect it would take spending into account. If you have spent the funds you no longer have up to 350 so it should be fine adding the entire 300 as the cap no longer applies, It's certainly not what I expect would happen.
I don't want to use the
#template 300because this category can vary quite a bit but when I do my budget I still want a maximum of 350 in that category. I always have some spending because I get payed in the middle of the month so I do my budget in the middle of the month.@shall0pass commented on GitHub (Aug 2, 2023):
Please try the PR https://github.com/actualbudget/actual/pull/1448 to see if this would resolve your issue. @youngcw , I'd really appreciate a review from you as well when you have time :)
@dugite-code commented on GitHub (Aug 3, 2023):
@shall0pass Yes, just tested on netlify and that resolves my issue.