github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2715] [MERGED] 🐛 remove mac electron app code-signing #53773

New Issue
Closed
opened 2026-04-30 22:44:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 22:44:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2715
Author: @MatissJanis
Created: 5/6/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/remove-csc

📝 Commits (9)

📊 Changes

9 files changed (+593 additions, -563 deletions)

View changed files

📝 .github/workflows/electron-master.yml (+2 -2)
📝 bin/package-electron (+1 -1)
📝 packages/api/package.json (+2 -2)
📝 packages/crdt/package.json (+2 -2)
📝 packages/desktop-client/package.json (+9 -9)
📝 packages/desktop-client/vite.config.mts (+12 -9)
📝 packages/loot-core/package.json (+4 -4)
➕ upcoming-release-notes/2715.md (+6 -0)
📝 yarn.lock (+555 -534)

📄 Description

Code signing was pre-requisite for publishing to mac app store. However, I never fully got the mac-apps-store version (it was crashing after publishing). So removing the code signing (for now).

Also applying a patch for https://github.com/actualbudget/actual/issues/2705 (Electron app not working on mac):

  • upgraded vite/swc dependencies
  • removed PWA usage from electron apps (this is the root cause of the problem)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2715 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 5/6/2024 **Status:** ✅ Merged **Merged:** 5/7/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/remove-csc` --- ### 📝 Commits (9) - [`edbff3c`](https://github.com/actualbudget/actual/commit/edbff3caf1bc49d3ca7a2daa229e4a73b300974d) :bug: remove mac electron app code-signing - [`417b6dc`](https://github.com/actualbudget/actual/commit/417b6dcd12449e506d904378a0740215f6ff7449) Release notes - [`93c7e5c`](https://github.com/actualbudget/actual/commit/93c7e5c541a7cd6af8905a60ffb270b05ad599f1) WIP: disable PWA - [`4d72368`](https://github.com/actualbudget/actual/commit/4d72368d193c333c85637a565f1f4cb83f10169a) WIP: attempt to bundle more things in electron - [`1cca62c`](https://github.com/actualbudget/actual/commit/1cca62c4123dbd6a190cbd42a7d257a6821b7308) WIP: update vite/swc - [`b0bdf9b`](https://github.com/actualbudget/actual/commit/b0bdf9b7cd4c81b61029bcfca2f725ac90eaaaa7) WIP: dedupe - [`346e0c5`](https://github.com/actualbudget/actual/commit/346e0c576d5e84b6ff3d9d91995864786807f893) WIP: disable PWA plugin - [`fc0524e`](https://github.com/actualbudget/actual/commit/fc0524e4e6724e254fc2f56895288ca333b33eab) WIP: another go - [`7397e6b`](https://github.com/actualbudget/actual/commit/7397e6b47c784ade7bfdcf5dd7d65843d4c45742) Add desktop mode ### 📊 Changes **9 files changed** (+593 additions, -563 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/electron-master.yml` (+2 -2) 📝 `bin/package-electron` (+1 -1) 📝 `packages/api/package.json` (+2 -2) 📝 `packages/crdt/package.json` (+2 -2) 📝 `packages/desktop-client/package.json` (+9 -9) 📝 `packages/desktop-client/vite.config.mts` (+12 -9) 📝 `packages/loot-core/package.json` (+4 -4) ➕ `upcoming-release-notes/2715.md` (+6 -0) 📝 `yarn.lock` (+555 -534) </details> ### 📄 Description Code signing was pre-requisite for publishing to mac app store. However, I never fully got the mac-apps-store version (it was crashing after publishing). So removing the code signing (for now). Also applying a patch for https://github.com/actualbudget/actual/issues/2705 (Electron app not working on mac): - upgraded vite/swc dependencies - removed PWA usage from electron apps (this is the root cause of the problem) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 22:44:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53773
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?