github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #4413] [MERGED] prevent bank sync from crashing when payee not found #5370

New Issue
Closed
opened 2026-02-28 21:11:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4413
Author: @matt-fidd
Created: 2/20/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @matt-fidd

Base: master ← Head: sync-crash

📝 Commits (3)

📊 Changes

2 files changed (+10 additions, -3 deletions)

View changed files

📝 packages/loot-core/src/server/transactions/transfer.ts (+4 -3)
➕ upcoming-release-notes/4413.md (+6 -0)

📄 Description

This issue has been reported a few times on Discord, most recently https://discord.com/channels/937901803608096828/1335338862125256704

There seems to be an edge case where the payee is not found when processing the transfers, this stops it from crashing the sync. The transaction still goes through, but is not considered as a transfer.

main.ts:1121 Bank Sync operation for account: xxxx
sync.ts:194 Pulling transactions from SimpleFin
sync.ts:244 Response: {transactions: Array(xx), accountBalance: Array(xx), startingBalance: xxxx}
sync.ts:398 Performing transaction reconciliation
sync.ts:516 Performing transaction reconciliation matching
index.web.ts:4 [Exception] TypeError: Failed syncing account “xxxx”
    at gg (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:137027)
    at async gE (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:138352)
    at async Promise.all (index 0)
    at async https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:139547
    at async lU (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:116:1007)
    at async gO (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:139490)
    at async yr (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:206:5818)
    at async https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:214:1860
Notifications.tsx:111 Internal error: TypeError: Cannot destructure property 'transfer_acct' of '(intermediate value)' as it is null.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4413 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 2/20/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `sync-crash` --- ### 📝 Commits (3) - [`01cd747`](https://github.com/actualbudget/actual/commit/01cd747cee2705838906d868066febd7935a051f) debug sync crash - [`34a4f46`](https://github.com/actualbudget/actual/commit/34a4f46ac295dd6c0a6d652a2bf0e682e48d0cfd) note - [`b1667c4`](https://github.com/actualbudget/actual/commit/b1667c40a5635a65bdf8adda3215e1b8033484aa) Update transfer.ts ### 📊 Changes **2 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/transactions/transfer.ts` (+4 -3) ➕ `upcoming-release-notes/4413.md` (+6 -0) </details> ### 📄 Description This issue has been reported a few times on Discord, most recently https://discord.com/channels/937901803608096828/1335338862125256704 There seems to be an edge case where the payee is not found when processing the transfers, this stops it from crashing the sync. The transaction still goes through, but is not considered as a transfer. ``` main.ts:1121 Bank Sync operation for account: xxxx sync.ts:194 Pulling transactions from SimpleFin sync.ts:244 Response: {transactions: Array(xx), accountBalance: Array(xx), startingBalance: xxxx} sync.ts:398 Performing transaction reconciliation sync.ts:516 Performing transaction reconciliation matching index.web.ts:4 [Exception] TypeError: Failed syncing account “xxxx” at gg (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:137027) at async gE (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:138352) at async Promise.all (index 0) at async https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:139547 at async lU (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:116:1007) at async gO (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:199:139490) at async yr (https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:206:5818) at async https://localhost:5006/kcab/kcab.worker.1e21d5133f60a8255cff.js:214:1860 Notifications.tsx:111 Internal error: TypeError: Cannot destructure property 'transfer_acct' of '(intermediate value)' as it is null. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?