github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #2584] [CLOSED] [WIP] Typescript migration: Convert accounts.jsx to accounts.tsx #53688

New Issue
Closed
opened 2026-04-30 22:33:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 22:33:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2584
Author: @IzStriker
Created: 4/11/2024
Status: ❌ Closed

Base: master ← Head: typescript-migration

📝 Commits (9)

  • 04b35f5 refactor: started converting to typescript
  • 3d46a30 refactor: more typescript migration work
  • 42e25fe refactor: mostly finish migration
  • 9f137b0 Merge branch 'master' into typescript-migration
  • 4d21cad fixes
  • 2c1682b Merge branch 'master' into typescript-migration
  • eb0aacf fixes
  • 64a6999 Merge branch 'typescript-migration' of github.com:IzStriker/actual into typescript-migration
  • 58a0853 wip

📊 Changes

10 files changed (+287 additions, -86 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+259 -77)
📝 packages/desktop-client/src/components/table.tsx (+6 -2)
📝 packages/desktop-client/src/hooks/useSelected.tsx (+2 -2)
📝 packages/loot-core/src/client/data-hooks/schedules.tsx (+2 -2)
📝 packages/loot-core/src/client/query-helpers.ts (+1 -1)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+6 -2)
📝 packages/loot-core/src/types/models/transaction.d.ts (+1 -0)
📝 packages/loot-core/src/types/prefs.d.ts (+1 -0)
📝 yarn.lock (+8 -0)

📄 Description

#1483
Any feedback would be much appreicated.
(bigger than I hoped it would be, but I guess one file at a time)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2584 **Author:** [@IzStriker](https://github.com/IzStriker) **Created:** 4/11/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `typescript-migration` --- ### 📝 Commits (9) - [`04b35f5`](https://github.com/actualbudget/actual/commit/04b35f580f27a706294edeb922969a31a887ae8a) refactor: started converting to typescript - [`3d46a30`](https://github.com/actualbudget/actual/commit/3d46a30f68e4aad791734ca767ee3a3952b52b79) refactor: more typescript migration work - [`42e25fe`](https://github.com/actualbudget/actual/commit/42e25fef2965790546b24ee8410540c414e27bff) refactor: mostly finish migration - [`9f137b0`](https://github.com/actualbudget/actual/commit/9f137b0bf935cf6a3f390f86bb3b88a3c15e3abd) Merge branch 'master' into typescript-migration - [`4d21cad`](https://github.com/actualbudget/actual/commit/4d21cad331f7d775174213176efeb5b28565ee71) fixes - [`2c1682b`](https://github.com/actualbudget/actual/commit/2c1682b63206e19a271235629bf260debfcafce7) Merge branch 'master' into typescript-migration - [`eb0aacf`](https://github.com/actualbudget/actual/commit/eb0aacfc5073531b8d22aaeae88a9aa0d4da5f3d) fixes - [`64a6999`](https://github.com/actualbudget/actual/commit/64a699930661950c7c4e345a829fa9396d6e3497) Merge branch 'typescript-migration' of github.com:IzStriker/actual into typescript-migration - [`58a0853`](https://github.com/actualbudget/actual/commit/58a08535879869ccc82d83a125af2da607eb02be) wip ### 📊 Changes **10 files changed** (+287 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+259 -77) 📝 `packages/desktop-client/src/components/table.tsx` (+6 -2) 📝 `packages/desktop-client/src/hooks/useSelected.tsx` (+2 -2) 📝 `packages/loot-core/src/client/data-hooks/schedules.tsx` (+2 -2) 📝 `packages/loot-core/src/client/query-helpers.ts` (+1 -1) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+6 -2) 📝 `packages/loot-core/src/types/models/transaction.d.ts` (+1 -0) 📝 `packages/loot-core/src/types/prefs.d.ts` (+1 -0) 📝 `yarn.lock` (+8 -0) </details> ### 📄 Description #1483 Any feedback would be much appreicated. (bigger than I hoped it would be, but I guess one file at a time) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 22:33:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53688
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?