github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 12:59:01 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #2535] [MERGED] Goals: Up To Template calculation with negative category balance #53657

New Issue
Closed
opened 2026-04-30 22:29:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 22:29:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2535
Author: @shall0pass
Created: 3/31/2024
Status: ✅ Merged
Merged: 4/2/2024
Merged by: @shall0pass

Base: master ← Head: goals_upto

📝 Commits (3)

📊 Changes

3 files changed (+9 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goals/goalsSimple.ts (+2 -1)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+1 -0)
➕ upcoming-release-notes/2535.md (+6 -0)

📄 Description

If using a template such as #template up to 1000, the budgeted amount would not reach 1000 if a negative balance was rolled over from the previous month. This change allows for rolling over a negative balance from a previous month.

I've tested 3 scenarios:
Category balance of -500. Budgeted amount is 1500.
Category balance of 0. Budgeted amount is 1000.
Category balance of 500. Budgeted amount is 500.

All scenarios result in a final category balance of 1000, which I believe is the expected behavior of 'up to'.

Discord report: https://discord.com/channels/937901803608096828/1223925566583865354/1223925566583865354

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2535 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 3/31/2024 **Status:** ✅ Merged **Merged:** 4/2/2024 **Merged by:** [@shall0pass](https://github.com/shall0pass) **Base:** `master` ← **Head:** `goals_upto` --- ### 📝 Commits (3) - [`2b07083`](https://github.com/actualbudget/actual/commit/2b070837349ed54f35445c7a7783eb1657fbe053) 'up to' calculation - [`66b3903`](https://github.com/actualbudget/actual/commit/66b3903befccedb4943c7b6c8561e22ec208d44f) note - [`8c9b49c`](https://github.com/actualbudget/actual/commit/8c9b49cb88c4f62f41b698962a6093660d89d03e) update to last months balance ### 📊 Changes **3 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goals/goalsSimple.ts` (+2 -1) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+1 -0) ➕ `upcoming-release-notes/2535.md` (+6 -0) </details> ### 📄 Description If using a template such as #template up to 1000, the budgeted amount would not reach 1000 if a negative balance was rolled over from the previous month. This change allows for rolling over a negative balance from a previous month. I've tested 3 scenarios: Category balance of -500. Budgeted amount is 1500. Category balance of 0. Budgeted amount is 1000. Category balance of 500. Budgeted amount is 500. All scenarios result in a final category balance of 1000, which I believe is the expected behavior of 'up to'. Discord report: https://discord.com/channels/937901803608096828/1223925566583865354/1223925566583865354 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 22:29:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?