github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4403] [MERGED] update mapping data for existing synced transactions and always show direction dropdown #5363

New Issue
Closed
opened 2026-02-28 21:11:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4403
Author: @matt-fidd
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @matt-fidd

Base: master ← Head: bank-sync-update-existing

📝 Commits (4)

  • 825830f update sync mapping data for existing transactions on sync
  • bcc33c2 show payment direction dropdown regardless of sample data
  • 84a5ef2 note
  • 8678187 ignore changes in raw_synced_data

📊 Changes

4 files changed (+117 additions, -98 deletions)

View changed files

📝 packages/desktop-client/src/components/banksync/EditSyncAccount.tsx (+7 -16)
📝 packages/desktop-client/src/components/banksync/FieldMapping.tsx (+92 -81)
📝 packages/loot-core/src/server/accounts/sync.ts (+12 -1)
➕ upcoming-release-notes/4403.md (+6 -0)

📄 Description

From feedback in #4253

@matt-fidd Some edge cases Ive found testing in my instance.

Old transactions don't pick up the raw data from the sync so only new data is available to use for the mapper. (this is a cause of below)
If there is only data for Payments and not Deposits, you can open the account mapper settings and change to Deposits, but cant change back to Payments. This is because there are no Deposits that have raw data so you get the message about needing data. (The selection box for switching between Payment and Deposit should either always show, or show if either of them have data)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4403 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `bank-sync-update-existing` --- ### 📝 Commits (4) - [`825830f`](https://github.com/actualbudget/actual/commit/825830fbdf4cbcfeffcfebab6fef04781ea3030e) update sync mapping data for existing transactions on sync - [`bcc33c2`](https://github.com/actualbudget/actual/commit/bcc33c280dd4568e131b0cdb2e917afd5c9d1dd1) show payment direction dropdown regardless of sample data - [`84a5ef2`](https://github.com/actualbudget/actual/commit/84a5ef225e91a5fc56df9424e5c47146d8a24801) note - [`8678187`](https://github.com/actualbudget/actual/commit/86781871e52dd8484524a46a7f675823978ea81f) ignore changes in raw_synced_data ### 📊 Changes **4 files changed** (+117 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/banksync/EditSyncAccount.tsx` (+7 -16) 📝 `packages/desktop-client/src/components/banksync/FieldMapping.tsx` (+92 -81) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+12 -1) ➕ `upcoming-release-notes/4403.md` (+6 -0) </details> ### 📄 Description From feedback in #4253 > @matt-fidd Some edge cases Ive found testing in my instance. > > Old transactions don't pick up the raw data from the sync so only new data is available to use for the mapper. (this is a cause of below) > If there is only data for Payments and not Deposits, you can open the account mapper settings and change to Deposits, but cant change back to Payments. This is because there are no Deposits that have raw data so you get the message about needing data. (The selection box for switching between Payment and Deposit should either always show, or show if either of them have data) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5363
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?